1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
|
<?php
/**
* Copyright (c) 2015 Thomas Müller <deepdiver@owncloud.com>
* This file is licensed under the Affero General Public License version 3 or
* later.
* See the COPYING-README file. */
namespace Test\Files;
use OC\Files\Storage\Local;
use OC\Files\View;
use OCP\Files\InvalidPathException;
/**
* Class PathVerificationTest
*
* @group DB
*
* @package Test\Files
*/
class PathVerificationTest extends \Test\TestCase {
/**
* @var \OC\Files\View
*/
private $view;
protected function setUp() {
parent::setUp();
$this->view = new View();
}
/**
* @expectedException \OCP\Files\InvalidPathException
* @expectedExceptionMessage File name is too long
*/
public function testPathVerificationFileNameTooLong() {
$fileName = str_repeat('a', 500);
$this->view->verifyPath('', $fileName);
}
/**
* @dataProvider providesEmptyFiles
* @expectedException \OCP\Files\InvalidPathException
* @expectedExceptionMessage Empty filename is not allowed
*/
public function testPathVerificationEmptyFileName($fileName) {
$this->view->verifyPath('', $fileName);
}
public function providesEmptyFiles() {
return [
[''],
[' '],
];
}
/**
* @dataProvider providesDotFiles
* @expectedException \OCP\Files\InvalidPathException
* @expectedExceptionMessage Dot files are not allowed
*/
public function testPathVerificationDotFiles($fileName) {
$this->view->verifyPath('', $fileName);
}
public function providesDotFiles() {
return [
['.'],
['..'],
[' .'],
[' ..'],
['. '],
['.. '],
[' . '],
[' .. '],
];
}
/**
* @dataProvider providesAstralPlane
*/
public function testPathVerificationAstralPlane($fileName) {
$connection = \OC::$server->getDatabaseConnection();
if (!$connection->supports4ByteText()) {
$this->expectException(InvalidPathException::class);
$this->expectExceptionMessage('File name contains at least one invalid character');
}
$this->view->verifyPath('', $fileName);
}
public function providesAstralPlane() {
return [
// this is the monkey emoji - http://en.wikipedia.org/w/index.php?title=%F0%9F%90%B5&redirect=no
['🐵'],
['🐵.txt'],
['txt.💩'],
['💩🐵.txt'],
['💩🐵'],
];
}
/**
* @dataProvider providesInvalidCharsPosix
* @expectedException \OCP\Files\InvalidCharacterInPathException
*/
public function testPathVerificationInvalidCharsPosix($fileName) {
$storage = new Local(['datadir' => '']);
$fileName = " 123{$fileName}456 ";
self::invokePrivate($storage, 'verifyPosixPath', [$fileName]);
}
public function providesInvalidCharsPosix() {
return [
[\chr(0)],
[\chr(1)],
[\chr(2)],
[\chr(3)],
[\chr(4)],
[\chr(5)],
[\chr(6)],
[\chr(7)],
[\chr(8)],
[\chr(9)],
[\chr(10)],
[\chr(11)],
[\chr(12)],
[\chr(13)],
[\chr(14)],
[\chr(15)],
[\chr(16)],
[\chr(17)],
[\chr(18)],
[\chr(19)],
[\chr(20)],
[\chr(21)],
[\chr(22)],
[\chr(23)],
[\chr(24)],
[\chr(25)],
[\chr(26)],
[\chr(27)],
[\chr(28)],
[\chr(29)],
[\chr(30)],
[\chr(31)],
['/'],
['\\'],
];
}
/**
* @dataProvider providesValidPosixPaths
*/
public function testPathVerificationValidPaths($fileName) {
$storage = new Local(['datadir' => '']);
self::invokePrivate($storage, 'verifyPosixPath', [$fileName]);
// nothing thrown
$this->assertTrue(true);
}
public function providesValidPosixPaths() {
return [
['simple'],
['simple.txt'],
['\''],
['`'],
['%'],
['()'],
['[]'],
['!'],
['$'],
['_'],
];
}
}
|