aboutsummaryrefslogtreecommitdiffstats
path: root/tests/lib/Repair/NC29/SanitizeAccountPropertiesJobTest.php
blob: 2a4f6e9ecf10bc038a4cb02b616c54a5924c74d5 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
<?php

declare(strict_types=1);

/**
 * SPDX-FileCopyrightText: 2025 Nextcloud GmbH and Nextcloud contributors
 * SPDX-License-Identifier: AGPL-3.0-or-later
 */
namespace OC\Repair\NC29;

use InvalidArgumentException;
use OCP\Accounts\IAccount;
use OCP\Accounts\IAccountManager;
use OCP\Accounts\IAccountProperty;
use OCP\AppFramework\Utility\ITimeFactory;
use OCP\IUser;
use OCP\IUserManager;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Log\LoggerInterface;
use Test\TestCase;

class SanitizeAccountPropertiesJobTest extends TestCase {

	private IUserManager&MockObject $userManager;
	private IAccountManager&MockObject $accountManager;
	private LoggerInterface&MockObject $logger;

	private SanitizeAccountPropertiesJob $job;

	protected function setUp(): void {
		$this->userManager = $this->createMock(IUserManager::class);
		$this->accountManager = $this->createMock(IAccountManager::class);
		$this->logger = $this->createMock(LoggerInterface::class);

		$this->job = new SanitizeAccountPropertiesJob(
			$this->createMock(ITimeFactory::class),
			$this->userManager,
			$this->accountManager,
			$this->logger,
		);
	}

	public function testParallel() {
		self::assertFalse($this->job->getAllowParallelRuns());
	}

	public function testRun(): void {
		$users = [
			$this->createMock(IUser::class),
			$this->createMock(IUser::class),
			$this->createMock(IUser::class),
		];
		$this->userManager
			->expects(self::once())
			->method('callForSeenUsers')
			->willReturnCallback(fn ($fn) => array_map($fn, $users));

		$property = $this->createMock(IAccountProperty::class);
		$property->expects(self::once())->method('getName')->willReturn(IAccountManager::PROPERTY_PHONE);
		$property->expects(self::once())->method('getScope')->willReturn(IAccountManager::SCOPE_LOCAL);

		$account1 = $this->createMock(IAccount::class);
		$account1->expects(self::once())
			->method('getProperty')
			->with(IAccountManager::PROPERTY_PHONE)
			->willReturn($property);
		$account1->expects(self::once())
			->method('setProperty')
			->with(IAccountManager::PROPERTY_PHONE, '', IAccountManager::SCOPE_LOCAL, IAccountManager::NOT_VERIFIED);
		$account1->expects(self::once())
			->method('jsonSerialize')
			->willReturn([
				IAccountManager::PROPERTY_DISPLAYNAME => [],
				IAccountManager::PROPERTY_PHONE => [],
			]);

		$account2 = $this->createMock(IAccount::class);
		$account2->expects(self::never())
			->method('getProperty');
		$account2->expects(self::once())
			->method('jsonSerialize')
			->willReturn([
				IAccountManager::PROPERTY_DISPLAYNAME => [],
				IAccountManager::PROPERTY_PHONE => [],
			]);

		$account3 = $this->createMock(IAccount::class);
		$account3->expects(self::never())
			->method('getProperty');
		$account3->expects(self::once())
			->method('jsonSerialize')
			->willReturn([
				IAccountManager::PROPERTY_DISPLAYNAME => [],
			]);

		$this->accountManager
			->expects(self::exactly(3))
			->method('getAccount')
			->willReturnMap([
				[$users[0], $account1],
				[$users[1], $account2],
				[$users[2], $account3],
			]);
		$valid = false;
		$this->accountManager->expects(self::exactly(3))
			->method('updateAccount')
			->willReturnCallback(function (IAccount $account) use (&$account1, &$valid): void {
				if (!$valid && $account === $account1) {
					$valid = true;
					throw new InvalidArgumentException(IAccountManager::PROPERTY_PHONE);
				}
			});

		self::invokePrivate($this->job, 'run', [null]);
	}
}
class="nv">$view->file_put_contents('localFolder/localFile.txt', 'local file'); $view->rename($this->folder, 'localFolder/' . $this->folder); // share mount point should now be moved to the subfolder $this->assertFalse($view->file_exists($this->folder)); $this->assertTrue($view->file_exists('localFolder/' .$this->folder)); $view->unlink('localFolder'); $this->loginHelper(self::TEST_FILES_SHARING_API_USER2); // shared folder should be unshared $foldersShared = $this->shareManager->getSharesBy(self::TEST_FILES_SHARING_API_USER1, IShare::TYPE_USER); $this->assertCount(0, $foldersShared); // trashbin should contain the local file but not the mount point $rootView = new \OC\Files\View('/' . self::TEST_FILES_SHARING_API_USER2); $trashContent = \OCA\Files_Trashbin\Helper::getTrashFiles('/', self::TEST_FILES_SHARING_API_USER2); $this->assertSame(1, count($trashContent)); $firstElement = reset($trashContent); $timestamp = $firstElement['mtime']; $this->assertTrue($rootView->file_exists('files_trashbin/files/localFolder.d' . $timestamp . '/localFile.txt')); $this->assertFalse($rootView->file_exists('files_trashbin/files/localFolder.d' . $timestamp . '/' . $this->folder)); //cleanup $rootView->deleteAll('files_trashin'); if ($status === false) { \OC::$server->getAppManager()->disableApp('files_trashbin'); } \OC\Files\Filesystem::getLoader()->removeStorageWrapper('oc_trashbin'); } public function shareFolderProvider() { return [ ['/'], ['/my_shares'], ]; } /** * if a file gets shared the etag for the recipients root should change * * @dataProvider shareFolderProvider * * @param string $shareFolder share folder to use */ public function testShareFile($shareFolder): void { $config = \OC::$server->getConfig(); $oldShareFolder = $config->getSystemValue('share_folder'); $config->setSystemValue('share_folder', $shareFolder); $this->loginHelper(self::TEST_FILES_SHARING_API_USER2); $beforeShareRoot = \OC\Files\Filesystem::getFileInfo(''); $etagBeforeShareRoot = $beforeShareRoot->getEtag(); \OC\Files\Filesystem::mkdir($shareFolder); $beforeShareDir = \OC\Files\Filesystem::getFileInfo($shareFolder); $etagBeforeShareDir = $beforeShareDir->getEtag(); $this->loginHelper(self::TEST_FILES_SHARING_API_USER1); $share = $this->share( IShare::TYPE_USER, $this->folder, self::TEST_FILES_SHARING_API_USER1, self::TEST_FILES_SHARING_API_USER2, \OCP\Constants::PERMISSION_ALL ); $this->loginHelper(self::TEST_FILES_SHARING_API_USER2); $afterShareRoot = \OC\Files\Filesystem::getFileInfo(''); $etagAfterShareRoot = $afterShareRoot->getEtag(); $afterShareDir = \OC\Files\Filesystem::getFileInfo($shareFolder); $etagAfterShareDir = $afterShareDir->getEtag(); $this->assertTrue(is_string($etagBeforeShareRoot)); $this->assertTrue(is_string($etagBeforeShareDir)); $this->assertTrue(is_string($etagAfterShareRoot)); $this->assertTrue(is_string($etagAfterShareDir)); $this->assertTrue($etagBeforeShareRoot !== $etagAfterShareRoot); $this->assertTrue($etagBeforeShareDir !== $etagAfterShareDir); // cleanup $this->loginHelper(self::TEST_FILES_SHARING_API_USER1); $this->shareManager->deleteShare($share); $config->setSystemValue('share_folder', $oldShareFolder); } /** * if a folder gets renamed all children mount points should be renamed too */ public function testRename(): void { $fileinfo = \OC\Files\Filesystem::getFileInfo($this->folder); $share = $this->share( IShare::TYPE_USER, $this->folder, self::TEST_FILES_SHARING_API_USER1, self::TEST_FILES_SHARING_API_USER2, \OCP\Constants::PERMISSION_ALL ); $this->loginHelper(self::TEST_FILES_SHARING_API_USER2); // make sure that the shared folder exists $this->assertTrue(\OC\Files\Filesystem::file_exists($this->folder)); \OC\Files\Filesystem::mkdir('oldTarget'); \OC\Files\Filesystem::mkdir('oldTarget/subfolder'); \OC\Files\Filesystem::mkdir('newTarget'); \OC\Files\Filesystem::rename($this->folder, 'oldTarget/subfolder/' . $this->folder); // re-login to make sure that the new mount points are initialized $this->loginHelper(self::TEST_FILES_SHARING_API_USER2); \OC\Files\Filesystem::rename('/oldTarget', '/newTarget/oldTarget'); // re-login to make sure that the new mount points are initialized $this->loginHelper(self::TEST_FILES_SHARING_API_USER2); $this->assertTrue(\OC\Files\Filesystem::file_exists('/newTarget/oldTarget/subfolder/' . $this->folder)); // cleanup $this->shareManager->deleteShare($share); } /** * If a folder gets moved into shared folder, children shares should have their uid_owner and permissions adjusted * user1 * |-folder1 --> shared with user2 * user2 * |-folder2 --> shared with user3 and moved into folder1 * |-subfolder1 --> shared with user3 * |-file1.txt --> shared with user3 * |-subfolder2 * |-file2.txt --> shared with user3 */ public function testMovedIntoShareChangeOwner(): void { $this->markTestSkipped('Skipped because this is failing with S3 as primary as file id are change when moved.'); // user1 creates folder1 $viewUser1 = new \OC\Files\View('/' . self::TEST_FILES_SHARING_API_USER1 . '/files'); $folder1 = 'folder1'; $viewUser1->mkdir($folder1); // user1 shares folder1 to user2 $folder1Share = $this->share( IShare::TYPE_USER, $folder1, self::TEST_FILES_SHARING_API_USER1, self::TEST_FILES_SHARING_API_USER2, \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE ); $this->loginHelper(self::TEST_FILES_SHARING_API_USER2); $viewUser2 = new \OC\Files\View('/' . self::TEST_FILES_SHARING_API_USER2 . '/files'); // Create user2 files $folder2 = 'folder2'; $viewUser2->mkdir($folder2); $file1 = 'folder2/file1.txt'; $viewUser2->touch($file1); $subfolder1 = 'folder2/subfolder1'; $viewUser2->mkdir($subfolder1); $subfolder2 = 'folder2/subfolder2'; $viewUser2->mkdir($subfolder2); $file2 = 'folder2/subfolder2/file2.txt'; $viewUser2->touch($file2); // user2 shares folder2 to user3 $folder2Share = $this->share( IShare::TYPE_USER, $folder2, self::TEST_FILES_SHARING_API_USER2, self::TEST_FILES_SHARING_API_USER3, \OCP\Constants::PERMISSION_ALL ); // user2 shares folder2/file1 to user3 $file1Share = $this->share( IShare::TYPE_USER, $file1, self::TEST_FILES_SHARING_API_USER2, self::TEST_FILES_SHARING_API_USER3, \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE ); // user2 shares subfolder1 to user3 $subfolder1Share = $this->share( IShare::TYPE_USER, $subfolder1, self::TEST_FILES_SHARING_API_USER2, self::TEST_FILES_SHARING_API_USER3, \OCP\Constants::PERMISSION_ALL ); // user2 shares subfolder2/file2.txt to user3 $file2Share = $this->share( IShare::TYPE_USER, $file2, self::TEST_FILES_SHARING_API_USER2, self::TEST_FILES_SHARING_API_USER3, \OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE ); // user2 moves folder2 into folder1 $viewUser2->rename($folder2, $folder1.'/'.$folder2); $folder2Share = $this->shareManager->getShareById($folder2Share->getFullId()); $file1Share = $this->shareManager->getShareById($file1Share->getFullId()); $subfolder1Share = $this->shareManager->getShareById($subfolder1Share->getFullId()); $file2Share = $this->shareManager->getShareById($file2Share->getFullId()); // Expect uid_owner of both shares to be user1 $this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $folder2Share->getShareOwner()); $this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $file1Share->getShareOwner()); $this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $subfolder1Share->getShareOwner()); $this->assertEquals(self::TEST_FILES_SHARING_API_USER1, $file2Share->getShareOwner()); // Expect permissions to be limited by the permissions of the destination share $this->assertEquals(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE, $folder2Share->getPermissions()); $this->assertEquals(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE, $file1Share->getPermissions()); $this->assertEquals(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE, $subfolder1Share->getPermissions()); $this->assertEquals(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE, $file2Share->getPermissions()); // user2 moves folder2 out of folder1 $viewUser2->rename($folder1.'/'.$folder2, $folder2); $folder2Share = $this->shareManager->getShareById($folder2Share->getFullId()); $file1Share = $this->shareManager->getShareById($file1Share->getFullId()); $subfolder1Share = $this->shareManager->getShareById($subfolder1Share->getFullId()); $file2Share = $this->shareManager->getShareById($file2Share->getFullId()); // Expect uid_owner of both shares to be user2 $this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $folder2Share->getShareOwner()); $this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $file1Share->getShareOwner()); $this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $subfolder1Share->getShareOwner()); $this->assertEquals(self::TEST_FILES_SHARING_API_USER2, $file2Share->getShareOwner()); // Expect permissions to not change $this->assertEquals(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE, $folder2Share->getPermissions()); $this->assertEquals(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE, $file1Share->getPermissions()); $this->assertEquals(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE, $subfolder1Share->getPermissions()); $this->assertEquals(\OCP\Constants::PERMISSION_READ | \OCP\Constants::PERMISSION_SHARE, $file2Share->getPermissions()); // cleanup $this->shareManager->deleteShare($folder1Share); $this->shareManager->deleteShare($folder2Share); $this->shareManager->deleteShare($file1Share); $this->shareManager->deleteShare($subfolder1Share); $this->shareManager->deleteShare($file2Share); } }