Enforce dependencies versions (#150)

1 files changed, 141 insertions, 0 deletions

diff --git a/pf4j/src/test/java/ro/fortsoft/pf4j/DependencyResolverTest.java b/pf4j/src/test/java/ro/fortsoft/pf4j/DependencyResolverTest.java
new file mode 100644
index 0000000..e8d1749
--- /dev/null
+++ b/pf4j/src/test/java/ro/fortsoft/pf4j/DependencyResolverTest.java
@@ -0,0 +1,141 @@
+/*
+ * Copyright 2017 Decebal Suiu
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package ro.fortsoft.pf4j;
+
+import com.github.zafarkhaja.semver.Version;
+import org.junit.Test;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * @author Decebal Suiu
+ */
+public class DependencyResolverTest {
+
+    @Test
+    public void sortedPlugins() {
+        // create incomplete plugin descriptor (ignore some attributes)
+        PluginDescriptor pd1 = new PluginDescriptor()
+            .setPluginId("p1")
+            .setDependencies("p2");
+
+        PluginDescriptor pd2 = new PluginDescriptor()
+            .setPluginId("p2")
+            .setPluginVersion(Version.forIntegers(0)); // needed in "checkDependencyVersion" method
+
+        List<PluginDescriptor> plugins = new ArrayList<>();
+        plugins.add(pd1);
+        plugins.add(pd2);
+
+        DependencyResolver resolver = new DependencyResolver();
+        DependencyResolver.Result result = resolver.resolve(plugins);
+
+        assertTrue(result.getNotFoundDependencies().isEmpty());
+        assertEquals(result.getSortedPlugins(), Arrays.asList("p2", "p1"));
+    }
+
+    @Test
+    public void notFoundDependencies() throws Exception {
+        PluginDescriptor pd1 = new PluginDescriptor()
+            .setPluginId("p1")
+            .setDependencies("p2, p3");
+
+        List<PluginDescriptor> plugins = new ArrayList<>();
+        plugins.add(pd1);
+
+        DependencyResolver resolver = new DependencyResolver();
+        DependencyResolver.Result result = resolver.resolve(plugins);
+
+        assertFalse(result.getNotFoundDependencies().isEmpty());
+        assertEquals(result.getNotFoundDependencies(), Arrays.asList("p2", "p3"));
+    }
+
+    @Test
+    public void cyclicDependencies() {
+        PluginDescriptor pd1 = new PluginDescriptor()
+            .setPluginId("p1")
+            .setPluginVersion(Version.forIntegers(0))
+            .setDependencies("p2");
+
+        PluginDescriptor pd2 = new PluginDescriptor()
+            .setPluginId("p2")
+            .setPluginVersion(Version.forIntegers(0))
+            .setDependencies("p3");
+
+        PluginDescriptor pd3 = new PluginDescriptor()
+            .setPluginId("p3")
+            .setPluginVersion(Version.forIntegers(0))
+            .setDependencies("p1");
+
+        List<PluginDescriptor> plugins = new ArrayList<>();
+        plugins.add(pd1);
+        plugins.add(pd2);
+        plugins.add(pd3);
+
+        DependencyResolver resolver = new DependencyResolver();
+        DependencyResolver.Result result = resolver.resolve(plugins);
+
+        assertTrue(result.hasCyclicDependency());
+    }
+
+    @Test
+    public void wrongDependencyVersion() {
+        PluginDescriptor pd1 = new PluginDescriptor()
+            .setPluginId("p1")
+//            .setDependencies("p2@2.0.0"); // simple version
+            .setDependencies("p2@>=1.5.0 & <1.6.0"); // range version
+
+        PluginDescriptor pd2 = new PluginDescriptor()
+            .setPluginId("p2")
+            .setPluginVersion(Version.forIntegers(1, 4));
+
+        List<PluginDescriptor> plugins = new ArrayList<>();
+        plugins.add(pd1);
+        plugins.add(pd2);
+
+        DependencyResolver resolver = new DependencyResolver();
+        DependencyResolver.Result result = resolver.resolve(plugins);
+
+        assertFalse(result.getWrongVersionDependencies().isEmpty());
+    }
+
+    @Test
+    public void goodDependencyVersion() {
+        PluginDescriptor pd1 = new PluginDescriptor()
+            .setPluginId("p1")
+            .setDependencies("p2@2.0.0");
+
+        PluginDescriptor pd2 = new PluginDescriptor()
+            .setPluginId("p2")
+            .setPluginVersion(Version.forIntegers(2));
+
+        List<PluginDescriptor> plugins = new ArrayList<>();
+        plugins.add(pd1);
+        plugins.add(pd2);
+
+        DependencyResolver resolver = new DependencyResolver();
+        DependencyResolver.Result result = resolver.resolve(plugins);
+
+        assertTrue(result.getWrongVersionDependencies().isEmpty());
+    }
+
+}