From 77fb6914b47a93b805baae8a6ff819f686367144 Mon Sep 17 00:00:00 2001 From: Decebal Suiu Date: Fri, 20 Dec 2019 22:59:22 +0200 Subject: Improve readability --- .../processor/ExtensionAnnotationProcessor.java | 56 +++++++++++----------- 1 file changed, 28 insertions(+), 28 deletions(-) (limited to 'pf4j/src/main/java/org') diff --git a/pf4j/src/main/java/org/pf4j/processor/ExtensionAnnotationProcessor.java b/pf4j/src/main/java/org/pf4j/processor/ExtensionAnnotationProcessor.java index 2faf143..797fe04 100644 --- a/pf4j/src/main/java/org/pf4j/processor/ExtensionAnnotationProcessor.java +++ b/pf4j/src/main/java/org/pf4j/processor/ExtensionAnnotationProcessor.java @@ -172,6 +172,34 @@ public class ExtensionAnnotationProcessor extends AbstractProcessor { return storage; } + private void processExtensionElement(Element element) { + // check if @Extension is put on class and not on method or constructor + if (!(element instanceof TypeElement)) { + error(element, "Put annotation only on classes (no methods, no fields)"); + return; + } + + // check if class extends/implements an extension point + if (!ignoreExtensionPoint && !isExtension(element.asType())) { + error(element, "%s is not an extension (it doesn't implement ExtensionPoint)", element); + return; + } + + TypeElement extensionElement = (TypeElement) element; + List extensionPointElements = findExtensionPoints(extensionElement); + if (extensionPointElements.isEmpty()) { + error(element, "No extension points found for extension %s", extensionElement); + return; + } + + String extension = getBinaryName(extensionElement); + for (TypeElement extensionPointElement : extensionPointElements) { + String extensionPoint = getBinaryName(extensionPointElement); + Set extensionPoints = extensions.computeIfAbsent(extensionPoint, k -> new TreeSet<>()); + extensionPoints.add(extension); + } + } + @SuppressWarnings("unchecked") private List findExtensionPoints(TypeElement extensionElement) { List extensionPointElements = new ArrayList<>(); @@ -263,34 +291,6 @@ public class ExtensionAnnotationProcessor extends AbstractProcessor { System.getProperty(IGNORE_EXTENSION_POINT) != null; } - private void processExtensionElement(Element element) { - // check if @Extension is put on class and not on method or constructor - if (!(element instanceof TypeElement)) { - error(element, "Put annotation only on classes (no methods, no fields)"); - return; - } - - // check if class extends/implements an extension point - if (!ignoreExtensionPoint && !isExtension(element.asType())) { - error(element, "%s is not an extension (it doesn't implement ExtensionPoint)", element); - return; - } - - TypeElement extensionElement = (TypeElement) element; - List extensionPointElements = findExtensionPoints(extensionElement); - if (extensionPointElements.isEmpty()) { - error(element, "No extension points found for extension %s", extensionElement); - return; - } - - String extension = getBinaryName(extensionElement); - for (TypeElement extensionPointElement : extensionPointElements) { - String extensionPoint = getBinaryName(extensionPointElement); - Set extensionPoints = extensions.computeIfAbsent(extensionPoint, k -> new TreeSet<>()); - extensionPoints.add(extension); - } - } - private TypeElement getElement(TypeMirror typeMirror) { return (TypeElement) ((DeclaredType) typeMirror).asElement(); } -- cgit v1.2.3