diff options
author | Javen O'Neal <onealj@apache.org> | 2016-06-11 01:41:54 +0000 |
---|---|---|
committer | Javen O'Neal <onealj@apache.org> | 2016-06-11 01:41:54 +0000 |
commit | ce25a59b6003331ac838c181a15143209633eaf8 (patch) | |
tree | b08559a84d6d849a98f251b30088e6bd036d3f85 | |
parent | 15876029e11b366b6b48feb526ded540eb6cbcc9 (diff) | |
download | poi-ce25a59b6003331ac838c181a15143209633eaf8.tar.gz poi-ce25a59b6003331ac838c181a15143209633eaf8.zip |
add warnings that AnalysisToolPak inconsistently handles case-sensitivity of function names
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747835 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r-- | src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java b/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java index aa04f3b8d6..a0da336d77 100644 --- a/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java +++ b/src/java/org/apache/poi/ss/formula/atp/AnalysisToolPak.java @@ -71,6 +71,7 @@ public final class AnalysisToolPak implements UDFFinder { // if you save such a .xlsx workbook as .xls if(name.startsWith("_xlfn.")) name = name.substring(6); + // FIXME: inconsistent case-sensitivity return _functionsByName.get(name.toUpperCase(Locale.ROOT)); } @@ -197,6 +198,7 @@ public final class AnalysisToolPak implements UDFFinder { public static boolean isATPFunction(String name){ AnalysisToolPak inst = (AnalysisToolPak)instance; + // FIXME: inconsistent case-sensitivity return inst._functionsByName.containsKey(name); } @@ -261,6 +263,7 @@ public final class AnalysisToolPak implements UDFFinder { ". You cannot override POI's implementations of Excel functions"); } + // FIXME: inconsistent case-sensitivity inst._functionsByName.put(name, func); } } |