aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDominik Stadler <centic@apache.org>2022-07-29 17:07:05 +0000
committerDominik Stadler <centic@apache.org>2022-07-29 17:07:05 +0000
commit92b8cf9984ba767d10f224d0bc3fa41b01fbcf32 (patch)
tree633228429903b677eef970e8a43456cc8743a154
parent5c78170f5de235dc9a4bb0ded7f4afe3f0ee5a43 (diff)
downloadpoi-92b8cf9984ba767d10f224d0bc3fa41b01fbcf32.tar.gz
poi-92b8cf9984ba767d10f224d0bc3fa41b01fbcf32.zip
Also look for test-data in parent-directory
When using the IDE to run tests in one of the sub-modules uses the poi-* sub-directory, so looking for the test-data in ../test-data is useful to make executing tests work out-of-the-box git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1903103 13f79535-47bb-0310-9956-ffa450edef68
-rw-r--r--poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java11
-rw-r--r--poi-ooxml/src/test/java/org/apache/poi/ooxml/TestTriggerCoverage.java4
-rw-r--r--poi/src/test/java/org/apache/poi/hssf/dev/BaseTestIteratingXLS.java3
-rw-r--r--poi/src/test/java/org/apache/poi/hssf/model/TestDrawingAggregate.java8
4 files changed, 23 insertions, 3 deletions
diff --git a/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java b/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java
index 8c94027459..aaa1173c7c 100644
--- a/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java
+++ b/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java
@@ -33,6 +33,7 @@ import java.util.List;
import java.util.Set;
import java.util.stream.Stream;
+import org.apache.poi.POIDataSamples;
import org.apache.poi.hssf.record.crypto.Biff8EncryptionKey;
import org.apache.tools.ant.DirectoryScanner;
import org.junit.jupiter.api.function.Executable;
@@ -71,7 +72,15 @@ import org.opentest4j.AssertionFailedError;
@Execution(ExecutionMode.CONCURRENT)
public class TestAllFiles {
private static final String DEFAULT_TEST_DATA_PATH = "test-data";
- public static final File ROOT_DIR = new File(System.getProperty("POI.testdata.path", DEFAULT_TEST_DATA_PATH));
+ public static final File ROOT_DIR;
+ static {
+ File dir = new File(System.getProperty(POIDataSamples.TEST_PROPERTY, DEFAULT_TEST_DATA_PATH));
+ if (!dir.exists()) {
+ dir = new File(System.getProperty(POIDataSamples.TEST_PROPERTY, "../" + DEFAULT_TEST_DATA_PATH));
+ }
+
+ ROOT_DIR = dir;
+ }
public static final String[] SCAN_EXCLUDES = {
"**/.svn/**",
diff --git a/poi-ooxml/src/test/java/org/apache/poi/ooxml/TestTriggerCoverage.java b/poi-ooxml/src/test/java/org/apache/poi/ooxml/TestTriggerCoverage.java
index c2bf7aa2f0..8ce0ae9692 100644
--- a/poi-ooxml/src/test/java/org/apache/poi/ooxml/TestTriggerCoverage.java
+++ b/poi-ooxml/src/test/java/org/apache/poi/ooxml/TestTriggerCoverage.java
@@ -70,6 +70,10 @@ class TestTriggerCoverage {
dataDirName = "test-data";
}
+ if (!new File(dataDirName).exists()) {
+ dataDirName = "../test-data";
+ }
+
List<Arguments> files = new ArrayList<>();
findFile(files, dataDirName + "/integration");
diff --git a/poi/src/test/java/org/apache/poi/hssf/dev/BaseTestIteratingXLS.java b/poi/src/test/java/org/apache/poi/hssf/dev/BaseTestIteratingXLS.java
index 065fe6a70a..5ec8a30b23 100644
--- a/poi/src/test/java/org/apache/poi/hssf/dev/BaseTestIteratingXLS.java
+++ b/poi/src/test/java/org/apache/poi/hssf/dev/BaseTestIteratingXLS.java
@@ -50,7 +50,8 @@ public abstract class BaseTestIteratingXLS {
};
public Stream<Arguments> files() {
- String dataDirName = System.getProperty(POIDataSamples.TEST_PROPERTY, "test-data");
+ String dataDirName = System.getProperty(POIDataSamples.TEST_PROPERTY,
+ new File("test-data").exists() ? "test-data" : "../test-data");
DirectoryScanner scanner = new DirectoryScanner();
scanner.setBasedir(dataDirName);
diff --git a/poi/src/test/java/org/apache/poi/hssf/model/TestDrawingAggregate.java b/poi/src/test/java/org/apache/poi/hssf/model/TestDrawingAggregate.java
index 90bd30c3c5..6b99428aea 100644
--- a/poi/src/test/java/org/apache/poi/hssf/model/TestDrawingAggregate.java
+++ b/poi/src/test/java/org/apache/poi/hssf/model/TestDrawingAggregate.java
@@ -33,6 +33,7 @@ import java.util.Map;
import java.util.stream.Stream;
import org.apache.commons.io.output.UnsynchronizedByteArrayOutputStream;
+import org.apache.poi.POIDataSamples;
import org.apache.poi.ddf.DefaultEscherRecordFactory;
import org.apache.poi.ddf.EscherContainerRecord;
import org.apache.poi.ddf.EscherDggRecord;
@@ -127,7 +128,12 @@ class TestDrawingAggregate {
}
public static Stream<Arguments> samples() {
- File testData = new File(System.getProperty("POI.testdata.path"), "spreadsheet");
+ String property = System.getProperty(POIDataSamples.TEST_PROPERTY, "test-data");
+ File testData = new File(property, "spreadsheet");
+ if (!testData.exists()) {
+ testData = new File("../" + property, "spreadsheet");
+ }
+
File[] files = testData.listFiles((dir, name) -> name.endsWith(".xls"));
assertNotNull(files, "Need to find files in test-data path, had path: " + testData);
return Stream.of(files).map(Arguments::of);