try to fix no-scratchpad build

remove or set-to-static scratchpad dependency from modules

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1892795 13f79535-47bb-0310-9956-ffa450edef68

6 files changed, 115 insertions, 155 deletions

diff --git a/poi-integration/src/test/java/org/apache/poi/stress/FileHandlerFactory.java b/poi-integration/src/test/java/org/apache/poi/stress/FileHandlerFactory.java
deleted file mode 100644
index 8be52b35a6..0000000000
--- a/poi-integration/src/test/java/org/apache/poi/stress/FileHandlerFactory.java
+++ /dev/null
@@ -1,120 +0,0 @@
-/* ====================================================================
-   Licensed to the Apache Software Foundation (ASF) under one or more
-   contributor license agreements.  See the NOTICE file distributed with
-   this work for additional information regarding copyright ownership.
-   The ASF licenses this file to You under the Apache License, Version 2.0
-   (the "License"); you may not use this file except in compliance with
-   the License.  You may obtain a copy of the License at
-
-       http://www.apache.org/licenses/LICENSE-2.0
-
-   Unless required by applicable law or agreed to in writing, software
-   distributed under the License is distributed on an "AS IS" BASIS,
-   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-   See the License for the specific language governing permissions and
-   limitations under the License.
-==================================================================== */
-package org.apache.poi.stress;
-
-import java.util.HashMap;
-import java.util.Map;
-import java.util.regex.Pattern;
-
-public class FileHandlerFactory {
-    // map from patterns for mimetypes to the FileHandlers that should be able to
-    // work with that file
-    // use a Set<Pair> to have a defined order of applying the matches
-    private static final Map<Pattern, FileHandler> MIME_TYPES = new HashMap<>();
-    static {
-        ////////////////// Word
-
-        MIME_TYPES.put(Pattern.compile("application/vnd.ms-word.document.macroenabled.12"), new XWPFFileHandler());
-        MIME_TYPES.put(Pattern.compile("application/vnd.ms-word.template.macroenabled.12"), new XWPFFileHandler());
-
-        // application/msword
-        MIME_TYPES.put(Pattern.compile(".*msword.*"), new HWPFFileHandler());
-        // application/vnd.ms-word
-        MIME_TYPES.put(Pattern.compile(".*ms-word.*"), new HWPFFileHandler());
-
-        // application/vnd.openxmlformats-officedocument.wordprocessingml.document
-        MIME_TYPES.put(Pattern.compile(".*wordprocessingml.*"), new XWPFFileHandler());
-
-        ////////////////// Excel
-        MIME_TYPES.put(Pattern.compile("application/vnd.ms-excel.addin.macroEnabled.12"), new XSSFFileHandler());
-        MIME_TYPES.put(Pattern.compile("application/vnd.ms-excel.sheet.binary.macroEnabled.12"), new XSSFFileHandler());
-
-        // application/msexcel
-        MIME_TYPES.put(Pattern.compile(".*msexcel.*"), new HSSFFileHandler());
-        // application/vnd.ms-excel
-        MIME_TYPES.put(Pattern.compile(".*ms-excel.*"), new HSSFFileHandler());
-
-        // application/vnd.openxmlformats-officedocument.spreadsheetml.sheet
-        MIME_TYPES.put(Pattern.compile(".*spreadsheetml.*"), new XSSFFileHandler());
-
-        ////////////////// Powerpoint
-
-        // application/vnd.ms-powerpoint
-        MIME_TYPES.put(Pattern.compile("application/vnd.ms-powerpoint"), new HSLFFileHandler());
-        // application/vnd.ms-officetheme
-        MIME_TYPES.put(Pattern.compile("application/vnd.ms-officetheme"), new HSLFFileHandler());
-
-        // application/vnd.openxmlformats-officedocument.presentationml.presentation
-        MIME_TYPES.put(Pattern.compile(".*presentationml.*"), new XSLFFileHandler());
-        // application/vnd.ms-powerpoint.presentation.macroenabled.12
-        MIME_TYPES.put(Pattern.compile("application/vnd.ms-powerpoint.presentation.macroenabled.12"), new XSLFFileHandler());
-        // application/vnd.ms-powerpoint.slideshow.macroenabled.12
-        MIME_TYPES.put(Pattern.compile("application/vnd.ms-powerpoint.slideshow.macroenabled.12"), new XSLFFileHandler());
-
-        ////////////////// Mail/TNEF
-
-        // application/vnd.ms-tnef
-        MIME_TYPES.put(Pattern.compile(".*ms-tnef.*"), new HMEFFileHandler());
-
-        // application/vnd.ms-outlook
-        MIME_TYPES.put(Pattern.compile("application/vnd.ms-outlook"), new HSMFFileHandler());
-
-        ////////////////// Visio
-
-        // application/vnd.visio
-        MIME_TYPES.put(Pattern.compile("application/vnd.visio.*"), new HDGFFileHandler());
-
-        // application/vnd.ms-visio.drawing
-        MIME_TYPES.put(Pattern.compile(".*vnd.ms-visio\\."), new XDGFFileHandler());
-
-        //application/vnd.ms-visio.viewer
-        MIME_TYPES.put(Pattern.compile(".*visio.*"), new HDGFFileHandler());
-
-
-        ////////////////// Publisher
-
-        // application/x-mspublisher
-        MIME_TYPES.put(Pattern.compile("application/x-mspublisher"), new HPBFFileHandler());
-
-
-        ////////////////// Others
-
-        // special type used by Tika
-        MIME_TYPES.put(Pattern.compile("application/x-tika-ooxml.*"), new OPCFileHandler());
-        // special type used by Tika
-        MIME_TYPES.put(Pattern.compile("application/x-tika-msoffice.*"), new POIFSFileHandler());
-
-        // application/x-tika-old-excel
-        MIME_TYPES.put(Pattern.compile("application/x-tika-old-excel"), new POIFSFileHandler());
-
-        // application/vnd.openxmlformats-officedocument.drawingml.chart+xml
-        // ?!MIME_TYPES.put(Pattern.compile(".*drawingml.*"), ".dwg");
-
-        // application/vnd.openxmlformats-officedocument.vmlDrawing
-        // ?!MIME_TYPES.put(Pattern.compile(".*vmlDrawing.*"), ".dwg");
-    }
-
-    public static FileHandler getHandler(String mimeType) {
-        for(Map.Entry<Pattern,FileHandler> entry : MIME_TYPES.entrySet()) {
-            if(entry.getKey().matcher(mimeType).matches()) {
-                return entry.getValue();
-            }
-        }
-
-        return null;
-    }
-}
diff --git a/poi-integration/src/test/java/org/apache/poi/stress/FileHandlerKnown.java b/poi-integration/src/test/java/org/apache/poi/stress/FileHandlerKnown.java
index aa3c827f1f..a438574610 100644
--- a/poi-integration/src/test/java/org/apache/poi/stress/FileHandlerKnown.java
+++ b/poi-integration/src/test/java/org/apache/poi/stress/FileHandlerKnown.java
@@ -22,29 +22,33 @@ import java.util.function.Supplier;
 
 @SuppressWarnings("unused")
 public enum FileHandlerKnown {
-    HDGF(HDGFFileHandler::new),
-    HMEF(HMEFFileHandler::new),
-    HPBF(HPBFFileHandler::new),
-    HPSF(HPSFFileHandler::new),
-    HSLF(HSLFFileHandler::new),
-    HSMF(HSMFFileHandler::new),
-    HSSF(HSSFFileHandler::new),
-    HWPF(HWPFFileHandler::new),
-    OPC(OPCFileHandler::new),
-    POIFS(POIFSFileHandler::new),
-    XDGF(XDGFFileHandler::new),
-    XSLF(XSLFFileHandler::new),
-    XSSFB(XSSFBFileHandler::new),
-    XSSF(XSSFFileHandler::new),
-    XWPF(XWPFFileHandler::new),
-    OWPF(OWPFFileHandler::new),
-    NULL(NullFileHandler::new)
+    HDGF,
+    HMEF,
+    HPBF,
+    HPSF,
+    HSLF,
+    HSMF,
+    HSSF,
+    HWPF,
+    OPC,
+    POIFS,
+    XDGF,
+    XSLF,
+    XSSFB,
+    XSSF,
+    XWPF,
+    OWPF,
+    NULL
     ;
 
-    public final Supplier<FileHandler> fileHandler;
-
-    FileHandlerKnown(Supplier<FileHandler> fileHandler) {
-        this.fileHandler = fileHandler;
+    public FileHandler getHandler() {
+        try {
+            // Because of no-scratchpad handling, we need to resort to reflection here
+            String n = name().replace("NULL", "Null");
+            return (FileHandler)Class.forName("org.apache.poi.stress." + n + "FileHandler").newInstance();
+        } catch (Exception e) {
+            return new NullFileHandler();
+        }
     }
 
     private static class NullFileHandler implements FileHandler {
diff --git a/poi-integration/src/test/java/org/apache/poi/stress/HPSFFileHandler.java b/poi-integration/src/test/java/org/apache/poi/stress/HPSFFileHandler.java
index 3caf166f31..274a3880e6 100644
--- a/poi-integration/src/test/java/org/apache/poi/stress/HPSFFileHandler.java
+++ b/poi-integration/src/test/java/org/apache/poi/stress/HPSFFileHandler.java
@@ -18,6 +18,8 @@ package org.apache.poi.stress;
 
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertFalse;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.fail;
 import static org.junit.jupiter.api.Assumptions.assumeFalse;
 
@@ -31,10 +33,12 @@ import java.util.Set;
 
 import org.apache.commons.io.output.UnsynchronizedByteArrayOutputStream;
 import org.apache.poi.examples.hpsf.CopyCompare;
+import org.apache.poi.extractor.POITextExtractor;
 import org.apache.poi.hpsf.DocumentSummaryInformation;
 import org.apache.poi.hpsf.HPSFPropertiesOnlyDocument;
 import org.apache.poi.hpsf.PropertySet;
 import org.apache.poi.hpsf.SummaryInformation;
+import org.apache.poi.hpsf.extractor.HPSFPropertiesExtractor;
 import org.apache.poi.poifs.filesystem.DirectoryNode;
 import org.apache.poi.poifs.filesystem.DocumentInputStream;
 import org.apache.poi.poifs.filesystem.POIFSFileSystem;
@@ -57,6 +61,35 @@ class HPSFFileHandler extends POIFSFileHandler {
     );
 
     @Override
+    public void handleExtracting(File file) throws Exception {
+        if (!Boolean.getBoolean("scratchpad.ignore")) {
+            super.handleExtracting(file);
+            return;
+        }
+
+        long length = file.length();
+        long modified = file.lastModified();
+
+        try (POIFSFileSystem poifs = new POIFSFileSystem(file);
+             HPSFPropertiesExtractor extractor = new HPSFPropertiesExtractor(poifs)) {
+
+            String fileAndParentName = file.getParentFile().getName() + "/" + file.getName();
+            String relPath = file.getPath().replaceAll(".*test-data", "test-data").replace('\\', '/');
+
+            assertFalse(EXPECTED_EXTRACTOR_FAILURES.contains(fileAndParentName),
+                "Expected Extraction to fail for file " + relPath + " and handler " + this + ", but did not fail!");
+            assertNotNull(extractor.getDocumentSummaryInformationText());
+            assertNotNull(extractor.getSummaryInformationText());
+            String text = extractor.getText();
+            //System.out.println(text);
+            assertNotNull(text);
+        }
+
+        assertEquals(length, file.length(), "File should not be modified by extractor");
+        assertEquals(modified, file.lastModified(), "File should not be modified by extractor");
+    }
+
+    @Override
     public void handleFile(InputStream stream, String path) throws Exception {
         POIFSFileSystem poifs = new POIFSFileSystem(stream);
         HPSFPropertiesOnlyDocument hpsf = new HPSFPropertiesOnlyDocument(poifs);
diff --git a/poi-integration/src/test/java/org/apache/poi/stress/StressMap.java b/poi-integration/src/test/java/org/apache/poi/stress/StressMap.java
index f69fbfbf4f..cf533c5b4f 100644
--- a/poi-integration/src/test/java/org/apache/poi/stress/StressMap.java
+++ b/poi-integration/src/test/java/org/apache/poi/stress/StressMap.java
@@ -18,12 +18,14 @@ package org.apache.poi.stress;
 
 import java.io.File;
 import java.io.IOException;
+import java.util.AbstractMap.SimpleEntry;
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.function.BiConsumer;
+import java.util.regex.Pattern;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;
 import java.util.stream.StreamSupport;
@@ -40,7 +42,8 @@ import org.apache.poi.ss.usermodel.WorkbookFactory;
 public class StressMap {
     private final MultiValuedMap<String, ExcInfo> exMap = new ArrayListValuedHashMap<>();
     private final Map<String,String> handlerMap = new LinkedHashMap<>();
-
+    private final boolean SCRATCH_IGNORE = Boolean.getBoolean("scratchpad.ignore");
+    private final Pattern SCRATCH_HANDLER = Pattern.compile("(HSLF|HWPF|HSMF|HMEF)");
 
     public void load(File mapFile) throws IOException {
         try (Workbook wb = WorkbookFactory.create(mapFile)) {
@@ -79,7 +82,6 @@ public class StressMap {
 
         handlerMap.clear();
 
-        boolean IGNORE_SCRATCHPAD = Boolean.getBoolean("scratchpad.ignore");
         boolean isFirst = true;
         for (Row row : sh) {
             if (isFirst) {
@@ -87,7 +89,7 @@ public class StressMap {
                 continue;
             }
             Cell cell = row.getCell(2);
-            if (IGNORE_SCRATCHPAD || cell == null || cell.getCellType() != CellType.STRING) {
+            if (SCRATCH_IGNORE || cell == null || cell.getCellType() != CellType.STRING) {
                 cell = row.getCell(1);
             }
             handlerMap.put(row.getCell(0).getStringCellValue(), cell.getStringCellValue());
@@ -103,20 +105,38 @@ public class StressMap {
         exMap.clear();
 
         Iterator<Row> iter = sh.iterator();
-        List<BiConsumer<ExcInfo,String>> cols = initCols(iter.next());
+        List<Map.Entry<String, BiConsumer<ExcInfo,String>>> cols = initCols(iter.next());
+
+        int idx = 0, handlerIdx = -1;
+        for (Map.Entry<String, BiConsumer<ExcInfo, String>> e : cols) {
+            if ("Handler".equals(e.getKey())) {
+                handlerIdx = idx;
+            }
+            idx++;
+        }
 
         while (iter.hasNext()) {
+            Row row = iter.next();
+
+            if (SCRATCH_IGNORE && handlerIdx > -1) {
+                String handler = row.getCell(handlerIdx).getStringCellValue();
+                if (SCRATCH_HANDLER.matcher(handler).find()) {
+                    // ignore exception of ignored files
+                    continue;
+                }
+            }
+
             ExcInfo info = new ExcInfo();
-            for (Cell cell : iter.next()) {
+            for (Cell cell : row) {
                 if (cell.getCellType() == CellType.STRING) {
-                    cols.get(cell.getColumnIndex()).accept(info, cell.getStringCellValue());
+                    cols.get(cell.getColumnIndex()).getValue().accept(info, cell.getStringCellValue());
                 }
             }
             exMap.put(info.getFile(), info);
         }
     }
 
-    private static List<BiConsumer<ExcInfo,String>> initCols(Row row) {
+    private static List<Map.Entry<String, BiConsumer<ExcInfo,String>>> initCols(Row row) {
         Map<String,BiConsumer<ExcInfo,String>> m = new HashMap<>();
         m.put("File", ExcInfo::setFile);
         m.put("Tests", ExcInfo::setTests);
@@ -128,7 +148,7 @@ public class StressMap {
         return StreamSupport
             .stream(row.spliterator(), false)
             .map(Cell::getStringCellValue)
-            .map(v -> m.getOrDefault(v, (e,s) -> {}))
+            .map(v -> new SimpleEntry<>(v, m.getOrDefault(v, (e,s) -> {})))
             .collect(Collectors.toList());
     }
 
diff --git a/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java b/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java
index f35f3b27fb..9d803f8e06 100644
--- a/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java
+++ b/poi-integration/src/test/java/org/apache/poi/stress/TestAllFiles.java
@@ -66,7 +66,7 @@ import org.opentest4j.AssertionFailedError;
  *  that we do not remove expected sanity checks.
  */
 // also need to set JVM parameter: -Djunit.jupiter.execution.parallel.enabled=true
-@Execution(ExecutionMode.CONCURRENT)
+//@Execution(ExecutionMode.CONCURRENT)
 public class TestAllFiles {
     private static final String DEFAULT_TEST_DATA_PATH = "test-data";
     public static final File ROOT_DIR = new File(System.getProperty("POI.testdata.path", DEFAULT_TEST_DATA_PATH));
@@ -78,6 +78,27 @@ public class TestAllFiles {
         "**/right-to-left.xlsx" //the threaded comments in this file cause XSSF clone to fail
     };
 
+    // cheap workaround of skipping the few problematic files
+    public static final String[] SCAN_EXCLUDES_NOSCRATCHPAD = {
+        "**/.svn/**",
+        "lost+found",
+        "**/.git/**",
+        "**/right-to-left.xlsx",
+        "document/word2.doc",
+        "document/cpansearch.perl.org_src_tobyink_acme-rundoc-0.001_word-lib_hello_world.docm",
+        "hpsf/Test0313rur.adm",
+        "spreadsheet/43493.xls",
+        "spreadsheet/44958.xls",
+        "spreadsheet/44958_1.xls",
+        "spreadsheet/46904.xls",
+        "spreadsheet/51832.xls",
+        "spreadsheet/60284.xls",
+        "spreadsheet/testArraysAndTables.xls",
+        "spreadsheet/testEXCEL_3.xls",
+        "spreadsheet/testEXCEL_4.xls",
+        "poifs/unknown_properties.msg"
+    };
+
     private static final Set<String> EXPECTED_FAILURES = StressTestUtils.unmodifiableHashSet(
             "document/truncated62886.docx"
     );
@@ -86,10 +107,11 @@ public class TestAllFiles {
         StressMap sm = new StressMap();
         sm.load(new File(ROOT_DIR, "spreadsheet/stress.xls"));
 
+        boolean noScratch = Boolean.getBoolean("scratchpad.ignore");
+
         DirectoryScanner scanner = new DirectoryScanner();
         scanner.setBasedir(ROOT_DIR);
-        scanner.setExcludes(SCAN_EXCLUDES);
-
+        scanner.setExcludes(noScratch ? SCAN_EXCLUDES_NOSCRATCHPAD : SCAN_EXCLUDES);
         scanner.scan();
 
         final List<Arguments> result = new ArrayList<>(100);
@@ -121,7 +143,7 @@ public class TestAllFiles {
         if (StressTestUtils.excludeFile(file, EXPECTED_FAILURES)) return;
 
         System.out.println("Running extractFiles on "+file);
-        FileHandler fileHandler = handler.fileHandler.get();
+        FileHandler fileHandler = handler.getHandler();
         assertNotNull(fileHandler, "Did not find a handler for file " + file);
         Executable exec = () -> fileHandler.handleExtracting(new File(ROOT_DIR, file));
         verify(file, exec, exClass, exMessage, password);
@@ -135,7 +157,7 @@ public class TestAllFiles {
     @MethodSource("handleFiles")
     void handleFile(String file, FileHandlerKnown handler, String password, Class<? extends Throwable> exClass, String exMessage) throws IOException {
         System.out.println("Running handleFiles on "+file);
-        FileHandler fileHandler = handler.fileHandler.get();
+        FileHandler fileHandler = handler.getHandler();
         assertNotNull(fileHandler, "Did not find a handler for file " + file);
         try (InputStream stream = new BufferedInputStream(new FileInputStream(new File(ROOT_DIR, file)), 64 * 1024)) {
             Executable exec = () -> fileHandler.handleFile(stream, file);
@@ -151,7 +173,7 @@ public class TestAllFiles {
     @MethodSource("handleAdditionals")
     void handleAdditional(String file, FileHandlerKnown handler, String password, Class<? extends Throwable> exClass, String exMessage) {
         System.out.println("Running additionals on "+file);
-        FileHandler fileHandler = handler.fileHandler.get();
+        FileHandler fileHandler = handler.getHandler();
         assertNotNull(fileHandler, "Did not find a handler for file " + file);
         Executable exec = () -> fileHandler.handleAdditional(new File(ROOT_DIR, file));
         verify(file, exec, exClass, exMessage, password);
diff --git a/poi-integration/src/test/java9/module-info.java b/poi-integration/src/test/java9/module-info.java
index 782edf74db..82eb9f6591 100644
--- a/poi-integration/src/test/java9/module-info.java
+++ b/poi-integration/src/test/java9/module-info.java
@@ -24,6 +24,7 @@ module org.apache.poi.stress {
 
     requires org.apache.commons.collections4;
     requires org.apache.poi.examples;
+    requires static org.apache.poi.scratchpad;
 
     exports org.apache.poi.stress;