summaryrefslogtreecommitdiffstats
path: root/poi-ooxml
diff options
context:
space:
mode:
authorSayi <sayi@apache.org>2021-05-20 08:52:30 +0000
committerSayi <sayi@apache.org>2021-05-20 08:52:30 +0000
commit974da9f981640f1bac886459fc241d2bc9e9ec29 (patch)
tree8f9e2cf06f9010e60208161a7e97c63253b03328 /poi-ooxml
parenta6c3e6a4fd0882a6fafea9905d7dfe79a0374447 (diff)
downloadpoi-974da9f981640f1bac886459fc241d2bc9e9ec29.tar.gz
poi-974da9f981640f1bac886459fc241d2bc9e9ec29.zip
fixed unable to read comments with pictures
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1890040 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'poi-ooxml')
-rw-r--r--poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFComments.java9
-rw-r--r--poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFComments.java14
2 files changed, 21 insertions, 2 deletions
diff --git a/poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFComments.java b/poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFComments.java
index 3cf82b680c..49cbb08976 100644
--- a/poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFComments.java
+++ b/poi-ooxml/src/main/java/org/apache/poi/xwpf/usermodel/XWPFComments.java
@@ -56,8 +56,13 @@ public class XWPFComments extends POIXMLDocumentPart {
*
* @param part the package part holding the data of the footnotes,
*/
- public XWPFComments(PackagePart part) {
- super(part);
+ public XWPFComments(POIXMLDocumentPart parent, PackagePart part) {
+ super(parent, part);
+ this.document = (XWPFDocument) getParent();
+
+ if (this.document == null) {
+ throw new NullPointerException();
+ }
}
/**
diff --git a/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFComments.java b/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFComments.java
index dad5ab877b..cefbab0ef4 100644
--- a/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFComments.java
+++ b/poi-ooxml/src/test/java/org/apache/poi/xwpf/usermodel/TestXWPFComments.java
@@ -21,6 +21,7 @@ import org.junit.jupiter.api.Test;
import java.io.IOException;
import java.math.BigInteger;
+import java.util.List;
import static org.junit.jupiter.api.Assertions.*;
@@ -59,4 +60,17 @@ class TestXWPFComments {
}
}
+ @Test
+ void testReadComments() throws IOException {
+ try (XWPFDocument doc = XWPFTestDataSamples.openSampleDocument("testComment.docx")) {
+ XWPFComments docComments = doc.getDocComments();
+ assertNotNull(docComments);
+ XWPFComment[] comments = doc.getComments();
+ assertEquals(1, comments.length);
+
+ List<XWPFPictureData> allPictures = docComments.getAllPictures();
+ assertEquals(1, allPictures.size());
+ }
+ }
+
}