summaryrefslogtreecommitdiffstats
path: root/poi
diff options
context:
space:
mode:
authorPJ Fanning <fanningpj@apache.org>2022-07-15 23:03:51 +0000
committerPJ Fanning <fanningpj@apache.org>2022-07-15 23:03:51 +0000
commit51c9ac77a3c112b87a2a943fc0eaff427aa9c3a1 (patch)
treedd95690554c1de73e50b868b62e3d6ee4c5c4e92 /poi
parentdbd078af9cb15f542b1df87c85a84a53b3308ec9 (diff)
downloadpoi-51c9ac77a3c112b87a2a943fc0eaff427aa9c3a1.tar.gz
poi-51c9ac77a3c112b87a2a943fc0eaff427aa9c3a1.zip
[github-355] Tidy up some boxed variables. Thanks to XenoAmess. This closes #355
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1902759 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'poi')
-rw-r--r--poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java4
-rw-r--r--poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java2
-rw-r--r--poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java2
3 files changed, 4 insertions, 4 deletions
diff --git a/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java b/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
index b53b970736..eb0c0af009 100644
--- a/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
+++ b/poi/src/main/java/org/apache/poi/ss/formula/functions/NumberValueFunction.java
@@ -50,7 +50,7 @@ public final class NumberValueFunction implements FreeRefFunction {
String decSep = String.valueOf(decimalFormatSymbols.getDecimalSeparator());
String groupSep = String.valueOf(decimalFormatSymbols.getGroupingSeparator());
- Double result = Double.NaN;
+ double result = Double.NaN;
ValueEval v1 = null;
ValueEval v2 = null;
ValueEval v3 = null;
@@ -105,7 +105,7 @@ public final class NumberValueFunction implements FreeRefFunction {
}
try {
- result = Double.valueOf(text);
+ result = Double.parseDouble(text);
result = result / Math.pow(100, countPercent); //If the Text argument ends in one or more percent signs (%), they are used in the calculation of the result.
checkValue(result);
} catch (EvaluationException e) {
diff --git a/poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java b/poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java
index ee6f722e39..6bf4ed1a2f 100644
--- a/poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java
+++ b/poi/src/test/java/org/apache/poi/ss/formula/functions/TestIntercept.java
@@ -59,7 +59,7 @@ final class TestIntercept {
@Test
void testBasic() {
- Double exp = Math.pow(10, 7.5);
+ double exp = Math.pow(10, 7.5);
ValueEval[] yValues = {
new NumberEval(3+exp),
new NumberEval(4+exp),
diff --git a/poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java b/poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java
index 971368714a..b4f69eaf93 100644
--- a/poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java
+++ b/poi/src/test/java/org/apache/poi/ss/formula/functions/TestSlope.java
@@ -54,7 +54,7 @@ final class TestSlope {
@Test
void testBasic() {
- Double exp = Math.pow(10, 7.5);
+ double exp = Math.pow(10, 7.5);
ValueEval[] yValues = {
new NumberEval(3+exp),
new NumberEval(4+exp),