aboutsummaryrefslogtreecommitdiffstats
path: root/poi
diff options
context:
space:
mode:
authorPJ Fanning <fanningpj@apache.org>2021-11-23 20:11:07 +0000
committerPJ Fanning <fanningpj@apache.org>2021-11-23 20:11:07 +0000
commitaa92a67baf72d6a3c3cbc9c8b657d2e0ae5c34d6 (patch)
tree6b94c0b5f7e0f43d09e81de14806c709dcbf3535 /poi
parentc34c58e0afcdf86c6704595f1394f5141fc2d6df (diff)
downloadpoi-aa92a67baf72d6a3c3cbc9c8b657d2e0ae5c34d6.tar.gz
poi-aa92a67baf72d6a3c3cbc9c8b657d2e0ae5c34d6.zip
[bug-65700] do not warn if transformer factory does not support accessExternalDTD property
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1895276 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'poi')
-rw-r--r--poi/src/main/java/org/apache/poi/util/XMLHelper.java2
-rw-r--r--poi/src/test/java/org/apache/poi/util/TestXMLHelper.java8
2 files changed, 9 insertions, 1 deletions
diff --git a/poi/src/main/java/org/apache/poi/util/XMLHelper.java b/poi/src/main/java/org/apache/poi/util/XMLHelper.java
index 8e7bae2898..58917e25d4 100644
--- a/poi/src/main/java/org/apache/poi/util/XMLHelper.java
+++ b/poi/src/main/java/org/apache/poi/util/XMLHelper.java
@@ -221,7 +221,7 @@ public final class XMLHelper {
public static TransformerFactory getTransformerFactory() {
TransformerFactory factory = TransformerFactory.newInstance();
trySet(factory::setFeature, FEATURE_SECURE_PROCESSING, true);
- trySet(factory::setAttribute, ACCESS_EXTERNAL_DTD, "");
+ quietSet(factory::setAttribute, ACCESS_EXTERNAL_DTD, "");
trySet(factory::setAttribute, ACCESS_EXTERNAL_STYLESHEET, "");
quietSet(factory::setAttribute, ACCESS_EXTERNAL_SCHEMA, "");
return factory;
diff --git a/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java b/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java
index a4e8732b8d..52041ffdba 100644
--- a/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java
+++ b/poi/src/test/java/org/apache/poi/util/TestXMLHelper.java
@@ -158,4 +158,12 @@ class TestXMLHelper {
void testNewXMLEventFactory() {
assertNotNull(XMLHelper.newXMLEventFactory());
}
+
+ /**
+ * test that newTransformer returns a transformer
+ */
+ @Test
+ void testNewTransformer() throws Exception {
+ assertNotNull(XMLHelper.newTransformer());
+ }
}