diff options
| author | Javen O'Neal <onealj@apache.org> | 2016-06-13 04:42:59 +0000 |
|---|---|---|
| committer | Javen O'Neal <onealj@apache.org> | 2016-06-13 04:42:59 +0000 |
| commit | a9c0342b1d51977d656dfa469434b670ccdfeeb9 (patch) | |
| tree | dc76de058b8e7feba9d33f0538c235c5337fe7a1 /src/resources/devtools | |
| parent | 784a7a6af8aadd913c978d02879a08a45e478e23 (diff) | |
| download | poi-a9c0342b1d51977d656dfa469434b670ccdfeeb9.tar.gz poi-a9c0342b1d51977d656dfa469434b670ccdfeeb9.zip | |
findbugs: fix URF_UNREAD_FIELD warnings
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1748084 13f79535-47bb-0310-9956-ffa450edef68
Diffstat (limited to 'src/resources/devtools')
| -rw-r--r-- | src/resources/devtools/findbugs-filters.xml | 27 |
1 files changed, 20 insertions, 7 deletions
diff --git a/src/resources/devtools/findbugs-filters.xml b/src/resources/devtools/findbugs-filters.xml index 4677ffe633..b2152bcf48 100644 --- a/src/resources/devtools/findbugs-filters.xml +++ b/src/resources/devtools/findbugs-filters.xml @@ -47,18 +47,31 @@ </Or> <Bug code="Nm" /> </Match> + + <!-- ignore fields that correspond to the values in a H??F binary record --> + <Match> + <Class name="~org\.apache\.poi\.h..f\..*"/> + <Bug pattern="URF_UNREAD_FIELD" /> + <Field name="~field_[12345].*" /> + </Match> <Match> - <Class name="org.apache.poi.hpsf.Decimal"/> + <Class name="org.apache.poi.hssf.usermodel.HSSFChart"/> <Bug pattern="URF_UNREAD_FIELD" /> - <Field name="field_[12345]_.+" /> + <Field name="chartTitleFormat" /> </Match> + <Match> + <Class name="org.apache.poi.hwmf.record.HwmfWindowing"/> + <Bug pattern="URF_UNREAD_FIELD" /> + <Field name="count2" /> + </Match> + + <!-- invalid performance issues - e.g. see #57840 --> <Match> - <Class name="org.apache.poi.xssf.usermodel.XSSFRow"/> - <Bug pattern="DM_NUMBER_CTOR" /> - </Match> - <Match> - <Class name="org.apache.poi.xssf.usermodel.XSSFSheet"/> + <Or> + <Class name="org.apache.poi.xssf.usermodel.XSSFRow"/> + <Class name="org.apache.poi.xssf.usermodel.XSSFSheet"/> + </Or> <Bug pattern="DM_NUMBER_CTOR" /> </Match> |