summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* rename drawBorders(..., short color, ...) to drawColoredBorders to make it ↵ss_border_property_templateJaven O'Neal2016-06-133-24/+23
| | | | | | obvious that method changes border line style and color git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748074 13f79535-47bb-0310-9956-ffa450edef68
* test copy constructor: make changes to same range: this is a better test for ↵Javen O'Neal2016-06-131-12/+10
| | | | | | deepcopy git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748073 13f79535-47bb-0310-9956-ffa450edef68
* add copy constructorJaven O'Neal2016-06-132-0/+56
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748072 13f79535-47bb-0310-9956-ffa450edef68
* move colors in TestBorderPropertyTemplate to testclass constantsJaven O'Neal2016-06-131-40/+35
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748071 13f79535-47bb-0310-9956-ffa450edef68
* rewrite switch statements to not re-check the switch'd variableJaven O'Neal2016-06-121-180/+201
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748070 13f79535-47bb-0310-9956-ffa450edef68
* rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style ↵Javen O'Neal2016-06-121-1/+1
| | | | | | from NONE to THIN fails the unit test. What is the correct behavior? git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748068 13f79535-47bb-0310-9956-ffa450edef68
* rename borderIsNotSetOrBlank to borderIsNotSet. Changing a set border style ↵Javen O'Neal2016-06-121-5/+5
| | | | | | from NONE to THIN fails the unit test. What is the correct behavior? git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748067 13f79535-47bb-0310-9956-ffa450edef68
* move check if border line style is blank before setting the border color to ↵Javen O'Neal2016-06-121-4/+13
| | | | | | a helper function for readability git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748066 13f79535-47bb-0310-9956-ffa450edef68
* remove public convenience methods that let the user avoid creating a ↵Javen O'Neal2016-06-122-63/+50
| | | | | | CellAddress object. Having the user provide a CellAddress increases the chance the user-provided object will be reused if possible. This also moves the validation of the CellAddress object outside of this BorderPropertyTemplate class (easier to debug), improves readability, and runs slightly faster since the CellAddress is needed anyways as a key. git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748065 13f79535-47bb-0310-9956-ffa450edef68
* javadocsJaven O'Neal2016-06-121-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748063 13f79535-47bb-0310-9956-ffa450edef68
* use CellAddress in unit tests where possible to improve readabilityJaven O'Neal2016-06-121-224/+251
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748062 13f79535-47bb-0310-9956-ffa450edef68
* javadocsJaven O'Neal2016-06-121-0/+6
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748061 13f79535-47bb-0310-9956-ffa450edef68
* javadocsJaven O'Neal2016-06-122-15/+31
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1748055 13f79535-47bb-0310-9956-ffa450edef68
* make CellRangeAddresses easier to cross-reference the example with the ↵Javen O'Neal2016-06-111-8/+16
| | | | | | written out workbook git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747888 13f79535-47bb-0310-9956-ffa450edef68
* make these classes more discoverable/searchable using more specific namesJaven O'Neal2016-06-113-169/+168
| | | | | | | rename PropertyTemplate to BorderPropertyTemplate rename Extent to BorderExtent git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747884 13f79535-47bb-0310-9956-ffa450edef68
* javadoc update and boolean addLeft|Right|Top|Bottom line wrap updateJaven O'Neal2016-06-111-74/+32
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747877 13f79535-47bb-0310-9956-ffa450edef68
* fix spelling in javadocJaven O'Neal2016-06-111-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747876 13f79535-47bb-0310-9956-ffa450edef68
* fix javadocs: remove unnecessary @links, remove references to CellStyleJaven O'Neal2016-06-111-112/+63
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747873 13f79535-47bb-0310-9956-ffa450edef68
* move loop-invariants outside the loop for readability and execution speedJaven O'Neal2016-06-111-38/+67
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747871 13f79535-47bb-0310-9956-ffa450edef68
* replace usage of all deprecated CellStyle.BORDER_* constants with BorderStyle.*Javen O'Neal2016-06-113-163/+126
| | | | | | update PropertyTemplate functions to require enum instead of short borderType git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747868 13f79535-47bb-0310-9956-ffa450edef68
* continue simplifying using helper functionsJaven O'Neal2016-06-111-139/+153
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747859 13f79535-47bb-0310-9956-ffa450edef68
* continue simplifying using helper functionsJaven O'Neal2016-06-111-103/+111
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747858 13f79535-47bb-0310-9956-ffa450edef68
* add helper functions for verifying template properties were set correctlyJaven O'Neal2016-06-111-10/+25
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747855 13f79535-47bb-0310-9956-ffa450edef68
* whitespace (unwrap lines)Javen O'Neal2016-06-111-470/+224
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747854 13f79535-47bb-0310-9956-ffa450edef68
* shorten PropertyTemplate.Extent to ExtentJaven O'Neal2016-06-111-54/+54
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747853 13f79535-47bb-0310-9956-ffa450edef68
* +props svn:eol-style=nativeJaven O'Neal2016-06-113-2010/+2010
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747852 13f79535-47bb-0310-9956-ffa450edef68
* bug 58787: add PropertyTemplate, unit test, and example from Mark MurphyJaven O'Neal2016-06-113-0/+2010
| | | | | | Attachment 33684 plus changes to TestPropertyTemplate#applyBorders: replaced assertEquals(CellStyle.BORDER_*, cs.getBorder*()) with assertEquals(BorderStyle.*, cs.getBorder*()) git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747851 13f79535-47bb-0310-9956-ffa450edef68
* create branch for bug 58787 Border utility to set cell styles around a range ↵Javen O'Neal2016-06-110-0/+0
| | | | | | of cells git-svn-id: https://svn.apache.org/repos/asf/poi/branches/ss_border_property_template@1747847 13f79535-47bb-0310-9956-ffa450edef68
* +props svn:eol-style nativeJaven O'Neal2016-06-111-88/+88
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747846 13f79535-47bb-0310-9956-ffa450edef68
* methods that return lists should return unmodifiable lists; use foreach ↵Javen O'Neal2016-06-111-7/+8
| | | | | | sheet iterator when sheet index is not needed git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747843 13f79535-47bb-0310-9956-ffa450edef68
* bug 57840: re-use XSSFEvaluationWorkbook when expanding a shared formula; ↵Javen O'Neal2016-06-112-6/+19
| | | | | | patch from Greg Woolsey git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747840 13f79535-47bb-0310-9956-ffa450edef68
* whitespace (tabs to spaces); +props svn:eol-style=nativeJaven O'Neal2016-06-111-51/+51
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747839 13f79535-47bb-0310-9956-ffa450edef68
* bug 57840: cache XSSFEvaluationCell and XSSFEvaluationSheet instances (30% ↵Javen O'Neal2016-06-112-10/+64
| | | | | | evaluation speedup due to caching and faster cell lookup); patch from Greg Woolsey git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747838 13f79535-47bb-0310-9956-ffa450edef68
* bug 57840: avoid auto-boxing ints for row/column TreeTable lookups (4% ↵Javen O'Neal2016-06-112-15/+15
| | | | | | evaluation speedup at the cost of additional Integer objects); patch from Greg Woolsey git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747837 13f79535-47bb-0310-9956-ffa450edef68
* add warnings that AnalysisToolPak inconsistently handles case-sensitivity of ↵Javen O'Neal2016-06-111-0/+3
| | | | | | function names git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747835 13f79535-47bb-0310-9956-ffa450edef68
* add crude unit tests for UDFFinder classesJaven O'Neal2016-06-113-0/+118
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747834 13f79535-47bb-0310-9956-ffa450edef68
* remove deprecated o.a.p.xssf.model.IndexedUDFFinder, which was moved to ↵Javen O'Neal2016-06-111-37/+0
| | | | | | o.a.p.ss.formula.udf 3 years ago and was @Internal before that git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747828 13f79535-47bb-0310-9956-ffa450edef68
* +props svn:eol-style=nativeJaven O'Neal2016-06-110-0/+0
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747826 13f79535-47bb-0310-9956-ffa450edef68
* add @Override annotationsJaven O'Neal2016-06-114-0/+4
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747825 13f79535-47bb-0310-9956-ffa450edef68
* fix typoJaven O'Neal2016-06-111-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747824 13f79535-47bb-0310-9956-ffa450edef68
* bug 57840: initialize the column header cache with 50% empty spaceJaven O'Neal2016-06-111-3/+3
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747823 13f79535-47bb-0310-9956-ffa450edef68
* whitespace (tabs to spaces)Javen O'Neal2016-06-111-18/+18
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747822 13f79535-47bb-0310-9956-ffa450edef68
* whitespace (tabs to spaces)Javen O'Neal2016-06-111-8/+8
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747821 13f79535-47bb-0310-9956-ffa450edef68
* whitespace (tabs to spaces)Javen O'Neal2016-06-111-22/+22
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747820 13f79535-47bb-0310-9956-ffa450edef68
* bug 57840: add test using a Data Table not anchored at A1Javen O'Neal2016-06-111-4/+17
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747819 13f79535-47bb-0310-9956-ffa450edef68
* bug 57840: add data table not anchored at A1 for testing ↵Javen O'Neal2016-06-101-0/+0
| | | | | | XSSFTable.getStartColIndex()/getEndColIndex() git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747817 13f79535-47bb-0310-9956-ffa450edef68
* fix text height testAndreas Beeker2016-06-101-2/+4
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747803 13f79535-47bb-0310-9956-ffa450edef68
* bug 57840: add unit tests for XSSFTable methods; rename ↵Javen O'Neal2016-06-103-2/+105
| | | | | | XSSFTable.getNumerOfMappedColumns() to getNumberOfMappedColumn() git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747771 13f79535-47bb-0310-9956-ffa450edef68
* bug 57840: add unit test for XSSFTable.findColumnIndexJaven O'Neal2016-06-102-3/+30
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747762 13f79535-47bb-0310-9956-ffa450edef68
* bug 57840: fix to reuse XSSFEvaluationWorkbook inside itself; patch from ↵Javen O'Neal2016-06-102-4/+2
| | | | | | Greg Woolsey git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1747754 13f79535-47bb-0310-9956-ffa450edef68