aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* revert recent changesPJ Fanning2021-03-151-68/+30
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887682 13f79535-47bb-0310-9956-ffa450edef68
* Run the TestAllFiles tests as part of GradleMarius Volkhart2021-03-151-1/+0
| | | | | | I accidentally excluded these in r1887643. They should not be excluded. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887681 13f79535-47bb-0310-9956-ffa450edef68
* [bug-65184] revert due to integration test failuresPJ Fanning2021-03-141-15/+11
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887660 13f79535-47bb-0310-9956-ffa450edef68
* Try to fix sonar buildAndreas Beeker2021-03-145-1/+5
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887659 13f79535-47bb-0310-9956-ffa450edef68
* reformat filePJ Fanning2021-03-141-203/+203
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887658 13f79535-47bb-0310-9956-ffa450edef68
* [bug-65184] Improve performance of POFSMiniStore getBlockAt. Thanks to sitsPJ Fanning2021-03-142-21/+63
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887657 13f79535-47bb-0310-9956-ffa450edef68
* Implement CONCAT function #65185Nick Burch2021-03-144-12/+107
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887656 13f79535-47bb-0310-9956-ffa450edef68
* Change Gradle to use java-library pluginMarius Volkhart2021-03-141-73/+49
| | | | | | | | This plugin is specifically built for libraries. The major difference to the regular java plugin is that is allows defining dependencies as part of the api or implementation. Both are used by the project at compile/runtime, but only api dependencies are made available to dependent projects. In our current setup, this doesn't matter much. We deploy to maven central using pre-built POMs. It's more of a future-proofing, and it makes it a little bit clearer which gradle projects actually require which dependencies. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887650 13f79535-47bb-0310-9956-ffa450edef68
* xmlbeans 5.0.0 releasePJ Fanning2021-03-147-11/+9
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887648 13f79535-47bb-0310-9956-ffa450edef68
* Exclude batik-script dependency from OOXML artifactMarius Volkhart2021-03-144-6/+16
| | | | | | | | We do not make use of the batik-script dependency. While this is likely to be true of a variety of the Batik dependencies, batik-script causes problems for our users who are using JPMS. See [bug-65103]. Fixes #230 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887643 13f79535-47bb-0310-9956-ffa450edef68
* Specify more granular Batik dependenciesMarius Volkhart2021-03-143-9/+26
| | | | | | | | Batik-all is a strange artifact. It's POM declares dependencies on all the sub-JARs, but its JAR has all of the sub-jars repackaged. This results in multiple JARs with the same packages being added to consuming applications. This leads to problems for JPMS users. See [bug-65183]. The Ant build does not use batik-all, so the Maven and Gradle builds should not either. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887642 13f79535-47bb-0310-9956-ffa450edef68
* Disable parallel tests on Gradle againMarius Volkhart2021-03-141-1/+1
| | | | | | | | Something is causing parallel tests to fail on CI. I haven't been able to track down what it is. The symptoms look similar to others where the cause was a test modifying the test-data directory. The integration tests also sometimes run into OutOfMemoryErrors when I run them in parallel. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887631 13f79535-47bb-0310-9956-ffa450edef68
* Limit which tests can run in parallelMarius Volkhart2021-03-144-3/+14
| | | | | | Some tests modify global resources. Those tests cannot be run in parallel with others, as they cause problems or become flaky. Where possible, indicate to JUnit the resources in contention. Otherwise, mark the tests as needing to run in isolation. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887630 13f79535-47bb-0310-9956-ffa450edef68
* Get Gradle GitHub Action past downloading the XMLBeans JARMarius Volkhart2021-03-141-0/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887614 13f79535-47bb-0310-9956-ffa450edef68
* [bug-65184] Improve performance of POFSMiniStore getBlockAt. Thanks to sitsPJ Fanning2021-03-131-153/+151
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887604 13f79535-47bb-0310-9956-ffa450edef68
* update keyPJ Fanning2021-03-111-29/+29
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887516 13f79535-47bb-0310-9956-ffa450edef68
* Streamline HPSF CustomProperties collection retrievalMarius Volkhart2021-03-101-7/+5
| | | | | | Reduce the number of map lookups necessary to compute the return values for methods that return collections of property details. Since we maintain parity between the `props` and `dictionary` contents, when retrieving property details, we can reference the `props` directly and avoid the `dictionary` indirection. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887453 13f79535-47bb-0310-9956-ffa450edef68
* update key for kiwiwings - downrating sha1 - see ↵Andreas Beeker2021-03-091-97/+97
| | | | | | https://infra.apache.org/release-signing.html git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887398 13f79535-47bb-0310-9956-ffa450edef68
* Parse PPDrawing more deterministicallyMarius Volkhart2021-03-091-115/+28
| | | | | | The [MS-PPT] spec is very clear about what the format of the PPDrawing record must be, and parsing deterministically makes for clearer code. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887396 13f79535-47bb-0310-9956-ffa450edef68
* Additional debug logging for unknown records in HSLFMarius Volkhart2021-03-091-1/+6
| | | | | | Recently, while debugging app behavior on HSLF documents, I had to dig into the OOXML that Microsoft PowerPoint places into files saved in PPT format. Having information in the logs about when records were not parsed by POI was very helpful. The hex identifier was critical in being able to quickly search the [MS-PPT] spec for what type of record it was, and the integer identifier was helpful in quickly finding the Record type in RecordTypes.java. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887393 13f79535-47bb-0310-9956-ffa450edef68
* Cleanup documentation of EscherChildAnchorRecord and EscherClientAnchorRecordMarius Volkhart2021-03-092-4/+7
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887391 13f79535-47bb-0310-9956-ffa450edef68
* try to fix windows path issues in exception messagesAndreas Beeker2021-03-081-3/+5
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887346 13f79535-47bb-0310-9956-ffa450edef68
* raise XmlBeans to 5.0.0 (nightly) also in the gradle buildAndreas Beeker2021-03-081-3/+3
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887345 13f79535-47bb-0310-9956-ffa450edef68
* remove old batik jarAndreas Beeker2021-03-081-1/+1
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887344 13f79535-47bb-0310-9956-ffa450edef68
* Use XmlBeans 5 nightlyAndreas Beeker2021-03-081-2/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887309 13f79535-47bb-0310-9956-ffa450edef68
* add DeferredGeneration samplePJ Fanning2021-03-061-0/+5
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887250 13f79535-47bb-0310-9956-ffa450edef68
* convert tabs to spacesPJ Fanning2021-03-062-45/+45
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887239 13f79535-47bb-0310-9956-ffa450edef68
* add DeferredGeneration samplePJ Fanning2021-03-061-0/+49
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887238 13f79535-47bb-0310-9956-ffa450edef68
* Remove unnecessary array conversion in HWPF FSPATableMarius Volkhart2021-03-011-2/+2
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887044 13f79535-47bb-0310-9956-ffa450edef68
* Remove deprecated HWPF FSPA methodsMarius Volkhart2021-03-013-37/+1
| | | | | | These methods have been @Deprecated for years, and are part of @Internal structures. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887039 13f79535-47bb-0310-9956-ffa450edef68
* Improve performance of HSLFPictureData#writeMarius Volkhart2021-03-011-13/+3
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887022 13f79535-47bb-0310-9956-ffa450edef68
* Deprecate functions that duplicate functionalityMarius Volkhart2021-03-014-5/+18
| | | | | | DrawingGroupRecord#processChildRecords and AbstractEscherHolderRecord#convertRawBytesToEscherRecords duplicate the functionality of AbstractEscherHolderRecord#decode. This makes the code harder to follow, as it is not clear when certain access patterns repeat. Accordingly, these functions are deprecated and flagged for removal. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887021 13f79535-47bb-0310-9956-ffa450edef68
* Review EscherContainerRecord#getChildRecords() call sites for unnecessary workMarius Volkhart2021-03-0117-34/+29
| | | | | | | | This started off as wanting to add the EscherContainerRecord#getChildCount() function in order to do an efficient check for how many children the container has. This was desirable in new code for editing HSSF pictures. The existing option of calling getChildRecords().size() was undesirable as this requires a list copy first. In the process of finding call sites that would benefit from replacing getChildRecords().size(), I realized that several other patterns would benefit from eliminating a copy, such as iterating over the children in a for-each loop, and indexed access to specific children. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887020 13f79535-47bb-0310-9956-ffa450edef68
* Add the ability to edit HSLFPictureData contentsMarius Volkhart2021-02-2820-129/+1031
| | | | | | | | | | | | Pictures can now be edited by calling HSLFPictureData#setData(byte[]). The byte[] should contain the image data as an image viewer might read it. To enable this functionality, a tighter coupling between the EscherBSERecords of the slideshow and the HSLFPictureData was required. This ensures that changes in image data size are accurately recorded in the records. In the course of coupling the records and the HSLFPictureData, various scenarios arose where a mapping of records to pictures was non-trivial. Accordingly, the HSLFSlideShowImpl#matchPicturesAndRecords(...) function was added to perform a more sophisticated matching pass. This function is heavily exercised by org.apache.poi.hslf.usermodel.TestBugs.testFile[5] and PPTX2PNG.render[2], as well as the new TestPictures#testSlideshowWithIncorrectOffsets(). Closes #225 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887017 13f79535-47bb-0310-9956-ffa450edef68
* Make picture loading in HWPF PicturesTable easier to understandMarius Volkhart2021-02-282-10/+7
| | | | | | The recursion is no longer necessary due to the more defined structure of OfficeArtContent. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887016 13f79535-47bb-0310-9956-ffa450edef68
* Add documentation to PICFAndOfficeArtDataMarius Volkhart2021-02-282-15/+30
| | | | | | Adjust call sites based on defined behavior. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887015 13f79535-47bb-0310-9956-ffa450edef68
* change gradle build to get unreleased xmlbeans jar from ci-builds (like ant ↵PJ Fanning2021-02-281-2/+3
| | | | | | build does) git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887012 13f79535-47bb-0310-9956-ffa450edef68
* Simplify OfficeArtContent#getBStoreContainer methodMarius Volkhart2021-02-282-17/+8
| | | | | | Due to the new structure of the class, we can be more specific about how we load the BStore. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887011 13f79535-47bb-0310-9956-ffa450edef68
* change gradle build to get unreleased xmlbeans jar from ci-builds (like ant ↵PJ Fanning2021-02-282-22/+16
| | | | | | build does) git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887010 13f79535-47bb-0310-9956-ffa450edef68
* Rename EscherRecordHolder to OfficeArtContentMarius Volkhart2021-02-286-28/+29
| | | | | | While the class does indeed hold EscherRecords, due to recent refactoring it is much more structured now than it was before. The contents of the class now closely resemble the OfficeArtContent structure referenced in the MS-DOC spec. Naming the class after the specification structure makes it easier to find and understand. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887009 13f79535-47bb-0310-9956-ffa450edef68
* Rework EscherRecordHolder parsingMarius Volkhart2021-02-281-106/+86
| | | | | | Modify the parsing done by EscherRecordHolder to be more deterministic. The format of the OfficeArtContent structure, which the EscherRecordHolder represents, is well defined in the MS-DOC spec. A clear class structure makes it easier to reason about the availability of data. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887008 13f79535-47bb-0310-9956-ffa450edef68
* Add documentation to EscherRecordTypes#DG_CONTAINERMarius Volkhart2021-02-281-0/+6
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1887007 13f79535-47bb-0310-9956-ffa450edef68
* Simplify initialization of HWPF EscherRecordHolderMarius Volkhart2021-02-282-11/+12
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886999 13f79535-47bb-0310-9956-ffa450edef68
* Add documentation for HWPF FileInformationBlock DggInfo methodsMarius Volkhart2021-02-281-0/+10
| | | | | | This documentation comes from [MS-DOC] - v20191119. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886998 13f79535-47bb-0310-9956-ffa450edef68
* Revert "Replace magic constant with reference" changesMarius Volkhart2021-02-274-46/+46
| | | | | | Reverts r1886986, r1886987 and r1886988. Incorrect conversion between int and shorts led to incorrect logic. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886989 13f79535-47bb-0310-9956-ffa450edef68
* Replace magic constant use of Escher Blip End type ID with referenceMarius Volkhart2021-02-272-2/+3
| | | | | | Instead of referring to the magic constant 0xF117, reference the value in the EscherRecordTypes enum. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886988 13f79535-47bb-0310-9956-ffa450edef68
* Replace magic constant use of Escher Blip Start type ID with referenceMarius Volkhart2021-02-274-6/+7
| | | | | | Instead of referring to the magic constant 0xF018, reference the value in the EscherRecordTypes enum. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886987 13f79535-47bb-0310-9956-ffa450edef68
* Replace magic constant use of EscherBSERecord type ID with referenceMarius Volkhart2021-02-274-43/+42
| | | | | | Instead of referring to the magic constant 0xF007, reference the value in the EscherRecordTypes enum. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886986 13f79535-47bb-0310-9956-ffa450edef68
* add missing licensePJ Fanning2021-02-271-0/+17
| | | | git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886965 13f79535-47bb-0310-9956-ffa450edef68
* Fix bug with record indexes for HSSF WorkbooksMarius Volkhart2021-02-273-2/+29
| | | | | | | | We have encountered workbooks that do not have a TabIdRecord (see 55982.xls). However, the WorkbookRecordList#updateRecordPos() method would still increment the position of the TabIdRecord for such workbooks. Changing the default position of the record from 0 to -1 indicates that the record position has now been set. This bug was discovered while adding support for editing pictures in HSSF documents. git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1886963 13f79535-47bb-0310-9956-ffa450edef68
generated by cgit v1.2.3 (git 2.39.1) at 2025-01-05 17:55:55 +0000