From 06ea5add363cb246a566edd3abba238d5da0051e Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Mon, 18 Jan 2021 14:20:02 +0000 Subject: [github-215] Improve Performance of OperandResolver#parseDouble. Thanks to Robert Wenzel. This closes #215 git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1885651 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/poi/ss/formula/eval/OperandResolver.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/java/org/apache/poi/ss/formula/eval/OperandResolver.java b/src/java/org/apache/poi/ss/formula/eval/OperandResolver.java index 162410f159..59a383c3e1 100644 --- a/src/java/org/apache/poi/ss/formula/eval/OperandResolver.java +++ b/src/java/org/apache/poi/ss/formula/eval/OperandResolver.java @@ -41,8 +41,8 @@ public final class OperandResolver { "[+-]?(" + "("+Digits+"(\\.)?("+Digits+"?)("+Exp+")?)|"+ "(\\."+Digits+"("+Exp+")?))"+ - "[\\x00-\\x20]*"); - + "[\\x00-\\x20]*"); + private static final Pattern fpPattern = Pattern.compile(fpRegex); private OperandResolver() { // no instances of this class @@ -291,8 +291,8 @@ public final class OperandResolver { * @return null if the specified text cannot be parsed as a number */ public static Double parseDouble(String pText) { - - if (Pattern.matches(fpRegex, pText)) + + if (fpPattern.matcher(pText).matches()) try { return Double.parseDouble(pText); } catch (NumberFormatException e) { -- cgit v1.2.3