From 9a5dec078ba1f6ccc89452a072446940ce3754c3 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Thu, 30 Dec 2021 20:02:03 +0000 Subject: rewrite CopyCompare to remove its ThreadLocal which causes a sonar code smell git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1896536 13f79535-47bb-0310-9956-ffa450edef68 --- .../main/java/org/apache/poi/examples/hpsf/CopyCompare.java | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'poi-examples') diff --git a/poi-examples/src/main/java/org/apache/poi/examples/hpsf/CopyCompare.java b/poi-examples/src/main/java/org/apache/poi/examples/hpsf/CopyCompare.java index d933b23e22..8a9e0e2f0e 100644 --- a/poi-examples/src/main/java/org/apache/poi/examples/hpsf/CopyCompare.java +++ b/poi-examples/src/main/java/org/apache/poi/examples/hpsf/CopyCompare.java @@ -62,9 +62,8 @@ import org.apache.poi.util.TempFile; */ @SuppressWarnings({"java:S106","java:S4823"}) public final class CopyCompare { - private CopyCompare() {} - private static final ThreadLocal out = ThreadLocal.withInitial(() -> System.out); + private PrintStream out = System.out; /** * Runs the example program. The application expects one or two arguments: @@ -83,6 +82,10 @@ public final class CopyCompare { * supported. */ public static void main(final String[] args) throws IOException { + new CopyCompare().run(args); + } + + public void run(String[] args) throws IOException { String originalFileName = null; String copyFileName = null; @@ -120,12 +123,12 @@ public final class CopyCompare { POIFSFileSystem cpfs = new POIFSFileSystem(new File(copyFileName))) { final DirectoryEntry oRoot = opfs.getRoot(); final DirectoryEntry cRoot = cpfs.getRoot(); - out.get().println(EntryUtils.areDirectoriesIdentical(oRoot, cRoot) ? "Equal" : "Not equal"); + out.println(EntryUtils.areDirectoriesIdentical(oRoot, cRoot) ? "Equal" : "Not equal"); } } - public static void setOut(PrintStream ps) { - out.set(ps); + public void setOut(PrintStream ps) { + out = ps; } private interface InputStreamSupplier { -- cgit v1.2.3