From f490e43442e22850a518d51280dceab7602b4e77 Mon Sep 17 00:00:00 2001 From: Dominik Stadler Date: Sun, 2 Jun 2024 09:39:51 +0000 Subject: Apply IDE suggestions and ignore sonar false positive Use NullOutputStream.INSTANCE Rework one test slightly git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1918116 13f79535-47bb-0310-9956-ffa450edef68 --- poi-scratchpad/src/main/java/org/apache/poi/hslf/record/Record.java | 2 +- .../src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShow.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'poi-scratchpad') diff --git a/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/Record.java b/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/Record.java index 1b07189f02..f1ad6045f1 100644 --- a/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/Record.java +++ b/poi-scratchpad/src/main/java/org/apache/poi/hslf/record/Record.java @@ -169,7 +169,7 @@ public abstract class Record implements GenericRecord // From there, we instanciate the class // Any special record handling occurs once we have the class RecordTypes recordType = RecordTypes.forTypeID((short) type); - RecordConstructor c = recordType.recordConstructor; + RecordConstructor c = recordType.recordConstructor; if (c == null) { // How odd. RecordTypes normally substitutes in // a default handler class if it has heard of the record diff --git a/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShow.java b/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShow.java index 9b0d96cdfb..99888a49a2 100644 --- a/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShow.java +++ b/poi-scratchpad/src/main/java/org/apache/poi/hslf/usermodel/HSLFSlideShow.java @@ -92,7 +92,7 @@ public final class HSLFSlideShow extends POIDocument implements SlideShow loadSavePhase = new ThreadLocal<>(); + private static final ThreadLocal loadSavePhase = new ThreadLocal<>(); // NOSONAR static { // allow to clear all thread-locals via ThreadLocalUtil ThreadLocalUtil.registerCleaner(loadSavePhase::remove); -- cgit v1.2.3