From 1e43266c7a83a051b6261859527d5f16596fe9d6 Mon Sep 17 00:00:00 2001
From: PJ Fanning <fanningpj@apache.org>
Date: Fri, 18 Dec 2020 00:17:50 +0000
Subject: avoid string concats

git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884581 13f79535-47bb-0310-9956-ffa450edef68
---
 src/java/org/apache/poi/util/POILogger.java | 25 +++++++++++++++++--------
 1 file changed, 17 insertions(+), 8 deletions(-)

(limited to 'src/java')

diff --git a/src/java/org/apache/poi/util/POILogger.java b/src/java/org/apache/poi/util/POILogger.java
index 7a7e9ee135..da4fbb2d14 100644
--- a/src/java/org/apache/poi/util/POILogger.java
+++ b/src/java/org/apache/poi/util/POILogger.java
@@ -96,17 +96,26 @@ public interface POILogger {
      */
     default void log(int level, Object... objs) {
         if (!check(level)) return;
-        StringBuilder sb = new StringBuilder(32);
         Throwable lastEx = null;
-        for (int i=0; i<objs.length; i++) {
-            if (i == objs.length-1 && objs[i] instanceof Throwable) {
-                lastEx = (Throwable)objs[i];
-            } else {
-                sb.append(objs[i]);
+        String msg;
+        if (objs.length == 0) {
+            msg = "";
+        } else if (objs.length == 1) {
+            if (objs[0] instanceof Throwable) {
+                lastEx = (Throwable)objs[0];
             }
+            msg = objs[0].toString();
+        } else {
+            StringBuilder sb = new StringBuilder(32);
+            for (int i=0; i<objs.length; i++) {
+                if (i == objs.length-1 && objs[i] instanceof Throwable) {
+                    lastEx = (Throwable)objs[i];
+                } else {
+                    sb.append(objs[i]);
+                }
+            }
+            msg = sb.toString();
         }
-
-        String msg = sb.toString();
         // log forging escape
         msg = msg.replaceAll("[\r\n]+", " ");
 
-- 
cgit v1.2.3