From 2b14dc36bb091128ee5e60ae61b32dfee0d5f02a Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Thu, 17 Dec 2020 21:54:42 +0000 Subject: avoid string concats git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1884574 13f79535-47bb-0310-9956-ffa450edef68 --- .../poi/poifs/crypt/temp/SXSSFWorkbookWithCustomZipEntrySource.java | 4 ++-- .../java/org/apache/poi/xssf/streaming/SXSSFFormulaEvaluator.java | 2 +- src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java | 4 ++-- .../org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) (limited to 'src/ooxml') diff --git a/src/ooxml/java/org/apache/poi/poifs/crypt/temp/SXSSFWorkbookWithCustomZipEntrySource.java b/src/ooxml/java/org/apache/poi/poifs/crypt/temp/SXSSFWorkbookWithCustomZipEntrySource.java index 59e4ff5b99..01a0b21e18 100644 --- a/src/ooxml/java/org/apache/poi/poifs/crypt/temp/SXSSFWorkbookWithCustomZipEntrySource.java +++ b/src/ooxml/java/org/apache/poi/poifs/crypt/temp/SXSSFWorkbookWithCustomZipEntrySource.java @@ -60,8 +60,8 @@ public class SXSSFWorkbookWithCustomZipEntrySource extends SXSSFWorkbook { @Override protected SheetDataWriter createSheetDataWriter() throws IOException { //log values to ensure these values are accessible to subclasses - LOG.log(POILogger.INFO, "isCompressTempFiles: " + isCompressTempFiles()); - LOG.log(POILogger.INFO, "SharedStringSource: " + getSharedStringSource()); + LOG.log(POILogger.INFO, "isCompressTempFiles: ", isCompressTempFiles()); + LOG.log(POILogger.INFO, "SharedStringSource: ", getSharedStringSource()); return new SheetDataWriterWithDecorator(); } } diff --git a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFFormulaEvaluator.java b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFFormulaEvaluator.java index 69f704ef78..7b8526d7e0 100644 --- a/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFFormulaEvaluator.java +++ b/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFFormulaEvaluator.java @@ -111,7 +111,7 @@ public final class SXSSFFormulaEvaluator extends BaseXSSFFormulaEvaluator { int lastFlushedRowNum = ((SXSSFSheet) sheet).getLastFlushedRowNum(); if (lastFlushedRowNum > -1) { if (! skipOutOfWindow) throw new RowFlushedException(0); - logger.log(POILogger.INFO, "Rows up to " + lastFlushedRowNum + " have already been flushed, skipping"); + logger.log(POILogger.INFO, "Rows up to ", lastFlushedRowNum, " have already been flushed, skipping"); } } diff --git a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java index 667b4ff5dc..c280784553 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFBugs.java @@ -3549,14 +3549,14 @@ public final class TestXSSFBugs extends BaseTestBugzillaIssues { LOG.log(POILogger.INFO, "Autosizing columns..."); for (int i = 0; i < 3; ++i) { - LOG.log(POILogger.INFO, "Autosize " + i + " - " + Duration.between(start, Instant.now())); + LOG.log(POILogger.INFO, "Autosize ", i, " - ", Duration.between(start, Instant.now())); sheet.autoSizeColumn(i); } for (int i = 0; i < 69 - 35 + 1; ++i) for (int j = 0; j < 8; ++j) { int col = 3 + 2 + i * (8 + 2) + j; - LOG.log(POILogger.INFO, "Autosize " + col + " - " + Duration.between(start, Instant.now())); + LOG.log(POILogger.INFO, "Autosize ", col, " - ", Duration.between(start, Instant.now())); sheet.autoSizeColumn(col); } LOG.log(POILogger.INFO, Duration.between(start, Instant.now())); diff --git a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java index f4a4ed0319..4f2779d97b 100644 --- a/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java +++ b/src/ooxml/testcases/org/apache/poi/xssf/usermodel/TestXSSFSheetMergeRegions.java @@ -43,7 +43,7 @@ public class TestXSSFSheetMergeRegions { if (millis < 2000) { break; } - LOG.log(POILogger.INFO, "Retry " + i + " because run-time is too high: " + millis); + LOG.log(POILogger.INFO, "Retry ", i, " because run-time is too high: ", millis); } boolean inGump = false; -- cgit v1.2.3