summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean-Philippe Lang <jp_lang@yahoo.fr>2014-01-03 19:42:43 +0000
committerJean-Philippe Lang <jp_lang@yahoo.fr>2014-01-03 19:42:43 +0000
commit3c540594dc597c593afebbe31db6262f3a7f13f8 (patch)
tree517037d62c25fc9e11dc758c95fcb4461b30bb0e
parent429b3a5daebe26bec8cac92540e002536384b135 (diff)
downloadredmine-3c540594dc597c593afebbe31db6262f3a7f13f8.tar.gz
redmine-3c540594dc597c593afebbe31db6262f3a7f13f8.zip
Fixed test failure with ruby1.8 (#8842).
git-svn-id: http://svn.redmine.org/redmine/trunk@12479 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r--app/models/query.rb2
-rw-r--r--test/unit/query_test.rb14
2 files changed, 15 insertions, 1 deletions
diff --git a/app/models/query.rb b/app/models/query.rb
index 78c1f72a5..8830cc5b6 100644
--- a/app/models/query.rb
+++ b/app/models/query.rb
@@ -243,7 +243,7 @@ class Query < ActiveRecord::Base
case operator_for(field)
when "=", ">=", "<=", "><"
add_filter_error(field, :invalid) if values_for(field).detect {|v|
- v.present? && (!v.match(/\A\d{4}-\d{2}-\d{2}(T\d{2}((:)?\d{2}){,2}(Z|\d{2}:?\d{2})?)?\z/) || parse_date(v).nil?)
+ v.present? && (!v.match(/\A\d{4}-\d{2}-\d{2}(T\d{2}((:)?\d{2}){0,2}(Z|\d{2}:?\d{2})?)?\z/) || parse_date(v).nil?)
}
when ">t-", "<t-", "t-", ">t+", "<t+", "t+", "><t+", "><t-"
add_filter_error(field, :invalid) if values_for(field).detect {|v| v.present? && !v.match(/^\d+$/) }
diff --git a/test/unit/query_test.rb b/test/unit/query_test.rb
index ee4696cf2..0528f0744 100644
--- a/test/unit/query_test.rb
+++ b/test/unit/query_test.rb
@@ -449,6 +449,13 @@ class QueryTest < ActiveSupport::TestCase
find_issues_with_query(query)
end
+ def test_operator_date_lesser_than_with_timestamp
+ query = IssueQuery.new(:name => '_')
+ query.add_filter('updated_on', '<=', ['2011-07-10T19:13:52'])
+ assert_match /issues\.updated_on <= '2011-07-10 19:13:52/, query.statement
+ find_issues_with_query(query)
+ end
+
def test_operator_date_greater_than
query = IssueQuery.new(:name => '_')
query.add_filter('due_date', '>=', ['2011-07-10'])
@@ -456,6 +463,13 @@ class QueryTest < ActiveSupport::TestCase
find_issues_with_query(query)
end
+ def test_operator_date_greater_than_with_timestamp
+ query = IssueQuery.new(:name => '_')
+ query.add_filter('updated_on', '>=', ['2011-07-10T19:13:52'])
+ assert_match /issues\.updated_on > '2011-07-10 19:13:51'/, query.statement
+ find_issues_with_query(query)
+ end
+
def test_operator_date_between
query = IssueQuery.new(:name => '_')
query.add_filter('due_date', '><', ['2011-06-23', '2011-07-10'])