summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorToshi MARUYAMA <marutosijp2@yahoo.co.jp>2011-03-11 07:34:14 +0000
committerToshi MARUYAMA <marutosijp2@yahoo.co.jp>2011-03-11 07:34:14 +0000
commit0d63e9e8fde36c88cf60095f814e5b76edb54027 (patch)
tree3a6a3ff8262f56e6d23a2fcf5cf614ac0405d49e
parentcb8c2d59bf7569aa2e24ad5b79852a6a82217e88 (diff)
downloadredmine-0d63e9e8fde36c88cf60095f814e5b76edb54027.tar.gz
redmine-0d63e9e8fde36c88cf60095f814e5b76edb54027.zip
scm: mercurial: add :order => 'id DESC' explicitly for MySQL test fails.
Because :order => 'id DESC' is defined at 'has_many', there is no need to set 'order'. But, MySQL test fails. Sqlite3 and PostgreSQL pass. Is this MySQL bug? git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5091 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r--app/models/repository/mercurial.rb11
1 files changed, 9 insertions, 2 deletions
diff --git a/app/models/repository/mercurial.rb b/app/models/repository/mercurial.rb
index 021e60b0d..49fba82cf 100644
--- a/app/models/repository/mercurial.rb
+++ b/app/models/repository/mercurial.rb
@@ -81,16 +81,23 @@ class Repository::Mercurial < Repository
# Returns the latest changesets for +path+; sorted by revision number
# Default behavior is to search in cached changesets
+ #
+ # Because :order => 'id DESC' is defined at 'has_many',
+ # there is no need to set 'order'.
+ # But, MySQL test fails.
+ # Sqlite3 and PostgreSQL pass.
+ # Is this MySQL bug?
def latest_changesets(path, rev, limit=10)
if path.blank?
- changesets.find(:all, :include => :user, :limit => limit)
+ changesets.find(:all, :include => :user, :limit => limit, :order => 'id DESC')
else
changesets.find(:all, :select => "DISTINCT #{Changeset.table_name}.*",
:joins => :changes,
:conditions => ["#{Change.table_name}.path = ? OR #{Change.table_name}.path LIKE ? ESCAPE ?",
path.with_leading_slash,
"#{path.with_leading_slash.gsub(/[%_\\]/) { |s| "\\#{s}" }}/%", '\\'],
- :include => :user, :limit => limit)
+ :include => :user, :limit => limit,
+ :order => "#{Changeset.table_name}.id DESC" )
end
end