diff options
author | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2008-05-14 17:23:40 +0000 |
---|---|---|
committer | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2008-05-14 17:23:40 +0000 |
commit | 4c6b9d9ce506253cae52bfc0d716bd67ecebb29f (patch) | |
tree | 836f389ced76c1e233583fada9ba74b41416dd26 | |
parent | 835cc7ed7c6b9257d7e5e2877f95f26edc013b5b (diff) | |
download | redmine-4c6b9d9ce506253cae52bfc0d716bd67ecebb29f.tar.gz redmine-4c6b9d9ce506253cae52bfc0d716bd67ecebb29f.zip |
Fixed: Check All / Uncheck All in Email Settings doesn't work (#1180).
git-svn-id: http://redmine.rubyforge.org/svn/trunk@1429 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r-- | app/views/settings/_notifications.rhtml | 4 | ||||
-rw-r--r-- | public/javascripts/application.js | 8 |
2 files changed, 6 insertions, 6 deletions
diff --git a/app/views/settings/_notifications.rhtml b/app/views/settings/_notifications.rhtml index ac3213853..1a472d606 100644 --- a/app/views/settings/_notifications.rhtml +++ b/app/views/settings/_notifications.rhtml @@ -9,13 +9,13 @@ <%= hidden_field_tag 'settings[bcc_recipients]', 0 %></p> </div> -<fieldset class="box"><legend><%=l(:text_select_mail_notifications)%></legend> +<fieldset class="box" id="notified_events"><legend><%=l(:text_select_mail_notifications)%></legend> <% @notifiables.each do |notifiable| %> <label><%= check_box_tag 'settings[notified_events][]', notifiable, Setting.notified_events.include?(notifiable) %> <%= l_or_humanize(notifiable) %></label><br /> <% end %> <%= hidden_field_tag 'settings[notified_events][]', '' %> -<p><%= check_all_links('mail-options-form') %></p> +<p><%= check_all_links('notified_events') %></p> </fieldset> <fieldset class="box"><legend><%= l(:setting_emails_footer) %></legend> diff --git a/public/javascripts/application.js b/public/javascripts/application.js index 4e8849842..f3d771a10 100644 --- a/public/javascripts/application.js +++ b/public/javascripts/application.js @@ -2,10 +2,10 @@ Copyright (C) 2006-2008 Jean-Philippe Lang */ function checkAll (id, checked) { - var el = document.getElementById(id); - for (var i = 0; i < el.elements.length; i++) { - if (el.elements[i].disabled==false) { - el.elements[i].checked = checked; + var els = Element.descendants(id); + for (var i = 0; i < els.length; i++) { + if (els[i].disabled==false) { + els[i].checked = checked; } } } |