diff options
| author | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2011-05-29 07:12:38 +0000 |
|---|---|---|
| committer | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2011-05-29 07:12:38 +0000 |
| commit | bf137818bbe1491fd41409d4729f9c35dc6a0ce2 (patch) | |
| tree | 322a38caaf6f2df16ec9f7d1dcb5f32249146646 | |
| parent | add719687ac214df618b3b8b69b1f8a4b7435c92 (diff) | |
| download | redmine-bf137818bbe1491fd41409d4729f9c35dc6a0ce2.tar.gz redmine-bf137818bbe1491fd41409d4729f9c35dc6a0ce2.zip | |
Fixed: activity shows updates of private issues (#8432).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5944 e93f8b46-1217-0410-a6f0-8f06a7374b81
| -rw-r--r-- | app/models/journal.rb | 1 | ||||
| -rw-r--r-- | test/fixtures/journals.yml | 7 | ||||
| -rw-r--r-- | test/unit/activity_test.rb | 3 |
3 files changed, 10 insertions, 1 deletions
diff --git a/app/models/journal.rb b/app/models/journal.rb index cb5aad21a..d0f7cc030 100644 --- a/app/models/journal.rb +++ b/app/models/journal.rb @@ -32,7 +32,6 @@ class Journal < ActiveRecord::Base :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.issue.id, :anchor => "change-#{o.id}"}} acts_as_activity_provider :type => 'issues', - :permission => :view_issues, :author_key => :user_id, :find_options => {:include => [{:issue => :project}, :details, :user], :conditions => "#{Journal.table_name}.journalized_type = 'Issue' AND" + diff --git a/test/fixtures/journals.yml b/test/fixtures/journals.yml index 48280f840..5bc81e41c 100644 --- a/test/fixtures/journals.yml +++ b/test/fixtures/journals.yml @@ -27,3 +27,10 @@ journals_004: journalized_type: Issue user_id: 1 journalized_id: 6 +journals_005: + id: 5 + created_on: <%= 1.days.ago.to_date.to_s(:db) %> + notes: "A comment on a private issue." + user_id: 2 + journalized_type: Issue + journalized_id: 14 diff --git a/test/unit/activity_test.rb b/test/unit/activity_test.rb index 4978142ab..2ecc68848 100644 --- a/test/unit/activity_test.rb +++ b/test/unit/activity_test.rb @@ -52,6 +52,9 @@ class ActivityTest < ActiveSupport::TestCase assert events.include?(Message.find(5)) # Issue of a private project assert !events.include?(Issue.find(4)) + # Private issue and comment + assert !events.include?(Issue.find(14)) + assert !events.include?(Journal.find(5)) end def test_global_activity_logged_user |