diff options
| author | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2012-03-06 18:48:47 +0000 |
|---|---|---|
| committer | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2012-03-06 18:48:47 +0000 |
| commit | bdf6e90f055ae09b7129e73ec062e3e020f01467 (patch) | |
| tree | bd5f68a6218c848bec72c92699399e72bd713dd1 | |
| parent | 6aad82e524c1b2cc8afc3299e129b239f834105b (diff) | |
| download | redmine-bdf6e90f055ae09b7129e73ec062e3e020f01467.tar.gz redmine-bdf6e90f055ae09b7129e73ec062e3e020f01467.zip | |
Prevent mass-assignment when adding a news comment (#10390).
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9129 e93f8b46-1217-0410-a6f0-8f06a7374b81
| -rw-r--r-- | app/controllers/comments_controller.rb | 3 | ||||
| -rw-r--r-- | app/models/comment.rb | 3 |
2 files changed, 5 insertions, 1 deletions
diff --git a/app/controllers/comments_controller.rb b/app/controllers/comments_controller.rb index 3a27b973a..ca9aa1a86 100644 --- a/app/controllers/comments_controller.rb +++ b/app/controllers/comments_controller.rb @@ -25,7 +25,8 @@ class CommentsController < ApplicationController def create raise Unauthorized unless @news.commentable? - @comment = Comment.new(params[:comment]) + @comment = Comment.new + @comment.safe_attributes = params[:comment] @comment.author = User.current if @news.comments << @comment flash[:notice] = l(:label_comment_added) diff --git a/app/models/comment.rb b/app/models/comment.rb index 701f0344e..4b7e098f1 100644 --- a/app/models/comment.rb +++ b/app/models/comment.rb @@ -16,8 +16,11 @@ # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. class Comment < ActiveRecord::Base + include Redmine::SafeAttributes belongs_to :commented, :polymorphic => true, :counter_cache => true belongs_to :author, :class_name => 'User', :foreign_key => 'author_id' validates_presence_of :commented, :author, :comments + + safe_attributes 'comments' end |