diff options
| author | Toshi MARUYAMA <marutosijp2@yahoo.co.jp> | 2019-09-21 15:54:38 +0000 |
|---|---|---|
| committer | Toshi MARUYAMA <marutosijp2@yahoo.co.jp> | 2019-09-21 15:54:38 +0000 |
| commit | 949d80c6d250c26a3b1b71aef2a58b894f3f35a7 (patch) | |
| tree | e7a6740bcd34a1cd7fb24c0a07cdc9ca5d9d791b | |
| parent | f66cc7db809436d16fe6518fab6ebfbe5fce1f9d (diff) | |
| download | redmine-949d80c6d250c26a3b1b71aef2a58b894f3f35a7.tar.gz redmine-949d80c6d250c26a3b1b71aef2a58b894f3f35a7.zip | |
code cleanup: rubocop: fix Performance/Casecmp in lib/redmine/scm/adapters/bazaar_adapter.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@18504 e93f8b46-1217-0410-a6f0-8f06a7374b81
| -rw-r--r-- | .rubocop_todo.yml | 5 | ||||
| -rw-r--r-- | lib/redmine/scm/adapters/bazaar_adapter.rb | 4 |
2 files changed, 2 insertions, 7 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index a0a5b04ef..2d5b6187f 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -724,11 +724,6 @@ Naming/VariableNumber: - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' - 'test/unit/project_test.rb' -# Cop supports --auto-correct. -Performance/Casecmp: - Exclude: - - 'lib/redmine/scm/adapters/bazaar_adapter.rb' - Performance/FixedSize: Exclude: - 'test/integration/api_test/issues_test.rb' diff --git a/lib/redmine/scm/adapters/bazaar_adapter.rb b/lib/redmine/scm/adapters/bazaar_adapter.rb index c342d13ff..cee38b3b6 100644 --- a/lib/redmine/scm/adapters/bazaar_adapter.rb +++ b/lib/redmine/scm/adapters/bazaar_adapter.rb @@ -266,10 +266,10 @@ module Redmine l = line.chomp.to_s if l =~ /^\s*append_revisions_only\s*=\s*(\w+)\s*$/ str_aro = $1 - if str_aro.upcase == "TRUE" + if str_aro.casecmp("TRUE") == 0 @aro = true cnt += 1 - elsif str_aro.upcase == "FALSE" + elsif str_aro.casecmp("FALSE") == 0 @aro = false cnt += 1 end |