Custom field List Link values to URL breaks on entries with spaces (#23067).

git-svn-id: http://svn.redmine.org/redmine/trunk@15539 e93f8b46-1217-0410-a6f0-8f06a7374b81

3 files changed, 14 insertions, 1 deletions

diff --git a/app/views/welcome/index.html.erb b/app/views/welcome/index.html.erb
index ba0924a7c..d6e840ad2 100644
--- a/app/views/welcome/index.html.erb
+++ b/app/views/welcome/index.html.erb
@@ -7,6 +7,9 @@
   <%= call_hook(:view_welcome_index_left) %>
 </div>
 
+<%= link_to "Test", "http://foo/test bar" %>
+<%= link_to "Test", "http://foo/test%20bar" %>
+
 <div class="splitcontentright">
   <% if @news.any? %>
   <div class="news box">
diff --git a/lib/redmine/field_format.rb b/lib/redmine/field_format.rb
index 874220933..0347ca8da 100644
--- a/lib/redmine/field_format.rb
+++ b/lib/redmine/field_format.rb
@@ -15,6 +15,8 @@
 # along with this program; if not, write to the Free Software
 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
 
+require 'uri'
+
 module Redmine
   module FieldFormat
     def self.add(name, klass)
@@ -212,7 +214,7 @@ module Redmine
             end
           end
         end
-        url
+        URI.encode(url)
       end
       protected :url_from_pattern
 
diff --git a/test/unit/lib/redmine/field_format/field_format_test.rb b/test/unit/lib/redmine/field_format/field_format_test.rb
index 1f3bc20ea..13177375b 100644
--- a/test/unit/lib/redmine/field_format/field_format_test.rb
+++ b/test/unit/lib/redmine/field_format/field_format_test.rb
@@ -74,4 +74,12 @@ class Redmine::FieldFormatTest < ActionView::TestCase
     assert_equal "bar", field.format.formatted_custom_value(self, custom_value, false)
     assert_equal '<a href="http://foo/bar">bar</a>', field.format.formatted_custom_value(self, custom_value, true)
   end
+
+  def test_text_field_with_url_pattern_and_value_containing_a_space_should_format_as_link
+    field = IssueCustomField.new(:field_format => 'string', :url_pattern => 'http://foo/%value%')
+    custom_value = CustomValue.new(:custom_field => field, :customized => Issue.new, :value => "foo bar")
+
+    assert_equal "foo bar", field.format.formatted_custom_value(self, custom_value, false)
+    assert_equal '<a href="http://foo/foo%20bar">foo bar</a>', field.format.formatted_custom_value(self, custom_value, true)
+  end
 end