diff options
author | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2015-05-30 08:18:34 +0000 |
---|---|---|
committer | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2015-05-30 08:18:34 +0000 |
commit | c89fa2be5765deaae19e9a6ec1c6a391c54b61ec (patch) | |
tree | a126ec4ac32a17bc9c9cc80343e81601a7606a28 | |
parent | f47b704ebc32cb2ec4c1da478dac67b8825c0a9f (diff) | |
download | redmine-c89fa2be5765deaae19e9a6ec1c6a391c54b61ec.tar.gz redmine-c89fa2be5765deaae19e9a6ec1c6a391c54b61ec.zip |
Connection leak in Redmine.pm (#19956).
Patch by Bruno Orcha GarcĂa.
git-svn-id: http://svn.redmine.org/redmine/trunk@14281 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r-- | extra/svn/Redmine.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/extra/svn/Redmine.pm b/extra/svn/Redmine.pm index ddad660b3..1ec057645 100644 --- a/extra/svn/Redmine.pm +++ b/extra/svn/Redmine.pm @@ -453,7 +453,6 @@ sub is_member { my $redmine_pass = shift; my $r = shift; - my $dbh = connect_database($r); my $project_id = get_project_identifier($r); my $pass_digest = Digest::SHA::sha1_hex($redmine_pass); @@ -466,6 +465,7 @@ sub is_member { $usrprojpass = $cfg->{RedmineCacheCreds}->get($redmine_user.":".$project_id.":".$access_mode); return 1 if (defined $usrprojpass and ($usrprojpass eq $pass_digest)); } + my $dbh = connect_database($r); my $query = $cfg->{RedmineQuery}; my $sth = $dbh->prepare($query); $sth->execute($redmine_user, $project_id); |