summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorToshi MARUYAMA <marutosijp2@yahoo.co.jp>2019-11-16 12:38:38 +0000
committerToshi MARUYAMA <marutosijp2@yahoo.co.jp>2019-11-16 12:38:38 +0000
commit829a14d431d24c07b9d1989691c635bd7671d12b (patch)
tree68e3f35f21a93fb86c901dee6a628b86b1ba9382
parent1220a68cbdfd298ff061249a92ef71610c6f7f17 (diff)
downloadredmine-829a14d431d24c07b9d1989691c635bd7671d12b.tar.gz
redmine-829a14d431d24c07b9d1989691c635bd7671d12b.zip
cleanup: rubocop: fix Lint/ParenthesesAsGroupedExpression and Style/RedundantParentheses and Layout/SpaceAfterNot in test/helpers/application_helper_test.rb
git-svn-id: http://svn.redmine.org/redmine/trunk@19082 e93f8b46-1217-0410-a6f0-8f06a7374b81
-rw-r--r--.rubocop_todo.yml3
-rw-r--r--test/helpers/application_helper_test.rb4
2 files changed, 2 insertions, 5 deletions
diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 349506676..e91e986ef 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -228,7 +228,6 @@ Layout/SpaceAfterNot:
- 'test/functional/repositories_git_controller_test.rb'
- 'test/functional/timelog_controller_test.rb'
- 'test/functional/workflows_controller_test.rb'
- - 'test/helpers/application_helper_test.rb'
- 'test/unit/attachment_test.rb'
- 'test/unit/lib/redmine/export/pdf_test.rb'
- 'test/unit/project_copy_test.rb'
@@ -412,7 +411,6 @@ Lint/ParenthesesAsGroupedExpression:
- 'test/functional/my_controller_test.rb'
- 'test/functional/settings_controller_test.rb'
- 'test/functional/users_controller_test.rb'
- - 'test/helpers/application_helper_test.rb'
- 'test/unit/attachment_test.rb'
- 'test/unit/lib/redmine/export/pdf_test.rb'
@@ -1423,7 +1421,6 @@ Style/RedundantParentheses:
- 'lib/redmine/platform.rb'
- 'lib/redmine/scm/adapters/cvs_adapter.rb'
- 'lib/redmine/scm/adapters/filesystem_adapter.rb'
- - 'test/helpers/application_helper_test.rb'
- 'test/unit/attachment_test.rb'
- 'test/unit/lib/redmine/export/pdf_test.rb'
- 'test/unit/project_test.rb'
diff --git a/test/helpers/application_helper_test.rb b/test/helpers/application_helper_test.rb
index 072c05102..e9a95972c 100644
--- a/test/helpers/application_helper_test.rb
+++ b/test/helpers/application_helper_test.rb
@@ -247,12 +247,12 @@ class ApplicationHelperTest < Redmine::HelperTest
a1 = Attachment.find(16)
assert_equal "testfile.png", a1.filename
assert a1.readable?
- assert (! a1.visible?(User.anonymous))
+ assert_not a1.visible?(User.anonymous)
assert a1.visible?(User.find(2))
a2 = Attachment.find(17)
assert_equal "testfile.PNG", a2.filename
assert a2.readable?
- assert (! a2.visible?(User.anonymous))
+ assert_not a2.visible?(User.anonymous)
assert a2.visible?(User.find(2))
assert a1.created_on < a2.created_on