diff options
| author | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2017-07-02 09:54:24 +0000 |
|---|---|---|
| committer | Jean-Philippe Lang <jp_lang@yahoo.fr> | 2017-07-02 09:54:24 +0000 |
| commit | c7e32aa2024592559391f7bbce99ffc8744e431d (patch) | |
| tree | 5386fc28515b2d48e61f1780c3c40c58f3b9ad1c | |
| parent | c15eaf46db4b95905e3cb7e8d6357ba3c1273ae4 (diff) | |
| download | redmine-c7e32aa2024592559391f7bbce99ffc8744e431d.tar.gz redmine-c7e32aa2024592559391f7bbce99ffc8744e431d.zip | |
"attachment:filename" should generate a link to preview instead of download (#26310, #25988).
git-svn-id: http://svn.redmine.org/redmine/trunk@16738 e93f8b46-1217-0410-a6f0-8f06a7374b81
| -rw-r--r-- | app/helpers/application_helper.rb | 2 | ||||
| -rw-r--r-- | test/unit/helpers/application_helper_test.rb | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 41a8056e8..52a405211 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -975,7 +975,7 @@ module ApplicationHelper attachments = options[:attachments] || [] attachments += obj.attachments if obj.respond_to?(:attachments) if attachments && attachment = Attachment.latest_attach(attachments, name) - link = link_to_attachment(attachment, :only_path => only_path, :download => true, :class => 'attachment') + link = link_to_attachment(attachment, :only_path => only_path, :class => 'attachment') end when 'project' if p = Project.visible.where("identifier = :s OR LOWER(name) = :s", :s => name.downcase).first diff --git a/test/unit/helpers/application_helper_test.rb b/test/unit/helpers/application_helper_test.rb index ca56412f7..020b4636c 100644 --- a/test/unit/helpers/application_helper_test.rb +++ b/test/unit/helpers/application_helper_test.rb @@ -667,7 +667,7 @@ RAW def test_attachment_links text = 'attachment:error281.txt' - result = link_to("error281.txt", "/attachments/download/1/error281.txt", + result = link_to("error281.txt", "/attachments/1/error281.txt", :class => "attachment") assert_equal "<p>#{result}</p>", textilizable(text, @@ -679,7 +679,7 @@ RAW set_tmp_attachments_directory a1 = Attachment.generate!(:filename => "test.txt", :created_on => 1.hour.ago) a2 = Attachment.generate!(:filename => "test.txt") - result = link_to("test.txt", "/attachments/download/#{a2.id}/test.txt", + result = link_to("test.txt", "/attachments/#{a2.id}/test.txt", :class => "attachment") assert_equal "<p>#{result}</p>", textilizable('attachment:test.txt', :attachments => [a1, a2]) |