summaryrefslogtreecommitdiffstats
path: root/app/controllers/settings_controller.rb
diff options
context:
space:
mode:
authorJean-Philippe Lang <jp_lang@yahoo.fr>2013-01-20 13:03:55 +0000
committerJean-Philippe Lang <jp_lang@yahoo.fr>2013-01-20 13:03:55 +0000
commitbb314029391d42dec6c9e14fddbe5a01ec5d94fc (patch)
treeae6ded8b758aa1f434528a6fb0627a030153fc34 /app/controllers/settings_controller.rb
parent253197c598fc50370db9672dc73e1d6a074aa7f7 (diff)
downloadredmine-bb314029391d42dec6c9e14fddbe5a01ec5d94fc.tar.gz
redmine-bb314029391d42dec6c9e14fddbe5a01ec5d94fc.zip
Fix 500 error for requests to the settings path for non-configurable plugins (#12911).
Path by Harry Garrood. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@11216 e93f8b46-1217-0410-a6f0-8f06a7374b81
Diffstat (limited to 'app/controllers/settings_controller.rb')
-rw-r--r--app/controllers/settings_controller.rb5
1 files changed, 5 insertions, 0 deletions
diff --git a/app/controllers/settings_controller.rb b/app/controllers/settings_controller.rb
index 7748b2a1d..3f48d1f75 100644
--- a/app/controllers/settings_controller.rb
+++ b/app/controllers/settings_controller.rb
@@ -52,6 +52,11 @@ class SettingsController < ApplicationController
def plugin
@plugin = Redmine::Plugin.find(params[:id])
+ unless @plugin.configurable?
+ render_404
+ return
+ end
+
if request.post?
Setting.send "plugin_#{@plugin.id}=", params[:settings]
flash[:notice] = l(:notice_successful_update)