diff options
author | Toshi MARUYAMA <marutosijp2@yahoo.co.jp> | 2011-05-04 23:38:11 +0000 |
---|---|---|
committer | Toshi MARUYAMA <marutosijp2@yahoo.co.jp> | 2011-05-04 23:38:11 +0000 |
commit | 23360937395ae464986dff700029f28aa1109f90 (patch) | |
tree | 58ede0cffca7a192c45458fdfb3e3eec5aa1f066 /app/models/repository | |
parent | a7c178f6a6013b4625fb11147648d57b9a257260 (diff) | |
download | redmine-23360937395ae464986dff700029f28aa1109f90.tar.gz redmine-23360937395ae464986dff700029f28aa1109f90.zip |
scm: git: add comments of revision order in fetch_changesets().
Related issues.
#5357, #6013, #7146, #4773, #4547, #1406, #3449, #3567.
git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5644 e93f8b46-1217-0410-a6f0-8f06a7374b81
Diffstat (limited to 'app/models/repository')
-rw-r--r-- | app/models/repository/git.rb | 15 |
1 files changed, 15 insertions, 0 deletions
diff --git a/app/models/repository/git.rb b/app/models/repository/git.rb index 198e39dc9..f8fef9ba8 100644 --- a/app/models/repository/git.rb +++ b/app/models/repository/git.rb @@ -70,6 +70,21 @@ class Repository::Git < Repository changesets.find(:first, :conditions => ['scmid LIKE ?', "#{name}%"]) end + # In Git and Mercurial, revisions are not in date order. + # Mercurial fixed issues. + # * Redmine Takes Too Long On Large Mercurial Repository + # http://www.redmine.org/issues/3449 + # * Sorting for changesets might go wrong on Mercurial repos + # http://www.redmine.org/issues/3567 + # Database revision column is text, so Redmine can not sort by revision. + # Mercurial has revision number, and revision number guarantees revision order. + # Mercurial adapter uses "hg log -r 0:tip --limit 10" + # to get limited revisions from old to new. + # And Mercurial model stored revisions ordered by database id in database. + # So, Mercurial can use correct order revisions. + # + # But, Git 1.7.3.4 does not support --reverse with -n or --skip. + # # With SCM's that have a sequential commit numbering, redmine is able to be # clever and only fetch changesets going forward from the most recent one # it knows about. |