summaryrefslogtreecommitdiffstats
path: root/app
diff options
context:
space:
mode:
authorGo MAEDA <maeda@farend.jp>2021-09-07 14:59:40 +0000
committerGo MAEDA <maeda@farend.jp>2021-09-07 14:59:40 +0000
commitbc3938fca31d9a36e4310df1fb80f6c0690b7461 (patch)
tree2821db056fb74e08a953fedad05fe34710412d1a /app
parent326a1b4dd2e0c877beb1023fa3d6d943bb0275e4 (diff)
downloadredmine-bc3938fca31d9a36e4310df1fb80f6c0690b7461.tar.gz
redmine-bc3938fca31d9a36e4310df1fb80f6c0690b7461.zip
Fix NoMethodError when generating a link to a locked user (#12795, #35823).
git-svn-id: http://svn.redmine.org/redmine/trunk@21217 e93f8b46-1217-0410-a6f0-8f06a7374b81
Diffstat (limited to 'app')
-rw-r--r--app/helpers/application_helper.rb7
-rw-r--r--app/models/group.rb4
2 files changed, 8 insertions, 3 deletions
diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb
index e3c858db4..03fb26d4c 100644
--- a/app/helpers/application_helper.rb
+++ b/app/helpers/application_helper.rb
@@ -60,19 +60,20 @@ module ApplicationHelper
case principal
when User
name = h(principal.name(options[:format]))
+ css_classes = ''
if principal.active? || (User.current.admin? && principal.logged?)
url = user_url(principal, :only_path => only_path)
- css_classes = principal.css_classes
+ css_classes += principal.css_classes
end
when Group
name = h(principal.to_s)
url = group_url(principal, :only_path => only_path)
- css_classes = 'group'
+ css_classes = principal.css_classes
else
name = h(principal.to_s)
end
- css_classes += " #{options[:class]}" if options[:class].present?
+ css_classes += " #{options[:class]}" if css_classes && options[:class].present?
url ? link_to(name, url, :class => css_classes) : name
end
diff --git a/app/models/group.rb b/app/models/group.rb
index a1fd35602..a676816ec 100644
--- a/app/models/group.rb
+++ b/app/models/group.rb
@@ -73,6 +73,10 @@ class Group < Principal
!builtin?
end
+ def css_classes
+ 'group'
+ end
+
def user_added(user)
members.each do |member|
next if member.project.nil?