diff options
| author | Go MAEDA <maeda@farend.jp> | 2023-01-11 13:20:52 +0000 |
|---|---|---|
| committer | Go MAEDA <maeda@farend.jp> | 2023-01-11 13:20:52 +0000 |
| commit | 3942177f49002d50aa65f803be85167d845675dd (patch) | |
| tree | 42fae6f20931876145545c007cb21ddd98ee71cc /lib/redmine/views | |
| parent | 3eb364e45ae11c681677d7b9e3fd13f88d5b1d6b (diff) | |
| download | redmine-3942177f49002d50aa65f803be85167d845675dd.tar.gz redmine-3942177f49002d50aa65f803be85167d845675dd.zip | |
Fix RuboCop offense Performance/BlockGivenWithExplicitBlock (#38146).
git-svn-id: https://svn.redmine.org/redmine/trunk@22027 e93f8b46-1217-0410-a6f0-8f06a7374b81
Diffstat (limited to 'lib/redmine/views')
| -rw-r--r-- | lib/redmine/views/builders.rb | 2 | ||||
| -rw-r--r-- | lib/redmine/views/builders/structure.rb | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/lib/redmine/views/builders.rb b/lib/redmine/views/builders.rb index dda689edc..b8ea9175c 100644 --- a/lib/redmine/views/builders.rb +++ b/lib/redmine/views/builders.rb @@ -34,7 +34,7 @@ module Redmine response.status = 406 return "We couldn't handle your request, sorry. If you were trying to access the API, make sure to append .json or .xml to your request URL.\n" end - if block_given? + if block yield(builder) else builder diff --git a/lib/redmine/views/builders/structure.rb b/lib/redmine/views/builders/structure.rb index c94896117..bfcb6dc62 100644 --- a/lib/redmine/views/builders/structure.rb +++ b/lib/redmine/views/builders/structure.rb @@ -58,7 +58,7 @@ module Redmine else value = encode_value(args.first) if @struct.last.is_a?(Array) - if args.size == 1 && !block_given? + if args.size == 1 && !block @struct.last << value else @struct.last << (args.last || {}).merge(:value => value) @@ -68,7 +68,7 @@ module Redmine end end end - if block_given? + if block @struct << (args.first.is_a?(Hash) ? args.first : {}) yield(self) ret = @struct.pop |