<=> operator should return nil when invoked with an incomparable object (#38772).

Patch by Go MAEDA.


git-svn-id: https://svn.redmine.org/redmine/trunk@22269 e93f8b46-1217-0410-a6f0-8f06a7374b81

2 files changed, 4 insertions, 0 deletions

diff --git a/lib/redmine/plugin.rb b/lib/redmine/plugin.rb
index b7f243354..79e310f31 100644
--- a/lib/redmine/plugin.rb
+++ b/lib/redmine/plugin.rb
@@ -187,6 +187,8 @@ module Redmine
     end
 
     def <=>(plugin)
+      return nil unless plugin.is_a?(Plugin)
+
       self.id.to_s <=> plugin.id.to_s
     end
 
diff --git a/lib/redmine/themes.rb b/lib/redmine/themes.rb
index a73184090..ff51f0083 100644
--- a/lib/redmine/themes.rb
+++ b/lib/redmine/themes.rb
@@ -61,6 +61,8 @@ module Redmine
       end
 
       def <=>(theme)
+        return nil unless theme.is_a?(Theme)
+
         name <=> theme.name
       end