cleanup: rubocop: fix Layout/IndentFirstHashElement in test/functional/projects_controller_test.rb

git-svn-id: http://svn.redmine.org/redmine/trunk@19304 e93f8b46-1217-0410-a6f0-8f06a7374b81

1 files changed, 165 insertions, 191 deletions

diff --git a/test/functional/projects_controller_test.rb b/test/functional/projects_controller_test.rb
index 00c5214a5..52a0dd04e 100644
--- a/test/functional/projects_controller_test.rb
+++ b/test/functional/projects_controller_test.rb
@@ -50,9 +50,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
   end
 
   def test_index_atom
-    get :index, :params => {
-        :format => 'atom'
-      }
+    get(:index, :params => {:format => 'atom'})
     assert_response :success
     assert_select 'feed>title', :text => 'Redmine: Latest projects'
     assert_select 'feed>entry', :count => Project.visible(User.current).count
@@ -210,21 +208,27 @@ class ProjectsControllerTest < Redmine::ControllerTest
   end
 
   def test_autocomplete_js
-    get :autocomplete, :params => {
+    get(
+      :autocomplete,
+      :params => {
         :format => 'js',
         :q => 'coo'
       },
       :xhr => true
+    )
     assert_response :success
     assert_equal 'text/javascript', response.content_type
   end
 
   def test_autocomplete_js_with_blank_search_term
-    get :autocomplete, :params => {
+    get(
+      :autocomplete,
+      :params => {
         :format => 'js',
         :q => ''
       },
       :xhr => true
+    )
     assert_response :success
     assert_equal 'text/javascript', response.content_type
   end
@@ -276,10 +280,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
     Role.find(1).remove_permission! :add_project
     Role.find(1).add_permission! :add_subprojects
     @request.session[:user_id] = 2
-
-    get :new, :params => {
-        :parent_id => 'ecookbook'
-      }
+    get(:new, :params => {:parent_id => 'ecookbook'})
     assert_response :success
 
     assert_select 'select[name=?]', 'project[parent_id]' do
@@ -317,8 +318,9 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   test "#create by admin user should create a new project" do
     @request.session[:user_id] = 1
-
-    post :create, :params => {
+    post(
+      :create,
+      :params => {
         :project => {
           :name => "blog",
           :description => "weblog",
@@ -334,6 +336,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
           :enabled_module_names => ['issue_tracking', 'news', 'repository']
         }
       }
+    )
     assert_redirected_to '/projects/blog/settings'
 
     project = Project.find_by_name('blog')
@@ -351,9 +354,10 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   test "#create by admin user should create a new subproject" do
     @request.session[:user_id] = 1
-
     assert_difference 'Project.count' do
-      post :create, :params => {
+      post(
+        :create,
+        :params => {
           :project => {
             :name => "blog",
             :description => "weblog",
@@ -363,9 +367,9 @@ class ProjectsControllerTest < Redmine::ControllerTest
               '3' => 'Beta'
             },
             :parent_id => 1
-
           }
         }
+      )
       assert_redirected_to '/projects/blog/settings'
     end
 
@@ -376,15 +380,17 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   test "#create by admin user should continue" do
     @request.session[:user_id] = 1
-
     assert_difference 'Project.count' do
-      post :create, :params => {
+      post(
+        :create,
+        :params => {
           :project => {
             :name => "blog",
             :identifier => "blog"
           },
           :continue => 'Create and continue'
         }
+      )
     end
     assert_redirected_to '/projects/new'
   end
@@ -392,8 +398,8 @@ class ProjectsControllerTest < Redmine::ControllerTest
   test "#create by non-admin user with add_project permission should create a new project" do
     Role.non_member.add_permission! :add_project
     @request.session[:user_id] = 9
-
-    post :create, :params => {
+    post(
+      :create, :params => {
         :project => {
           :name => "blog",
           :description => "weblog",
@@ -404,10 +410,9 @@ class ProjectsControllerTest < Redmine::ControllerTest
           },
           :tracker_ids => ['1', '3'],
           :enabled_module_names => ['issue_tracking', 'news', 'repository']
-
         }
       }
-
+    )
     assert_redirected_to '/projects/blog/settings'
 
     project = Project.find_by_name('blog')
@@ -426,9 +431,10 @@ class ProjectsControllerTest < Redmine::ControllerTest
     Role.non_member.add_permission! :add_project
     User.find(9).update! :language => 'en'
     @request.session[:user_id] = 9
-
     assert_no_difference 'Project.count' do
-      post :create, :params => {
+      post(
+        :create,
+        :params => {
           :project => {
             :name => "blog",
             :description => "weblog",
@@ -438,9 +444,9 @@ class ProjectsControllerTest < Redmine::ControllerTest
               '3' => 'Beta'
             },
             :parent_id => 1
-
           }
         }
+      )
     end
     assert_response :success
     assert_select_error /Subproject of is invalid/
@@ -450,8 +456,9 @@ class ProjectsControllerTest < Redmine::ControllerTest
     Role.find(1).remove_permission! :add_project
     Role.find(1).add_permission! :add_subprojects
     @request.session[:user_id] = 2
-
-    post :create, :params => {
+    post(
+      :create,
+      :params => {
         :project => {
           :name => "blog",
           :description => "weblog",
@@ -461,9 +468,9 @@ class ProjectsControllerTest < Redmine::ControllerTest
             '3' => 'Beta'
           },
           :parent_id => 1
-
         }
       }
+    )
     assert_redirected_to '/projects/blog/settings'
     project = Project.find_by_name('blog')
     assert_equal 1, project.parent_id
@@ -473,9 +480,10 @@ class ProjectsControllerTest < Redmine::ControllerTest
     Role.find(1).remove_permission! :add_project
     Role.find(1).add_permission! :add_subprojects
     @request.session[:user_id] = 2
-
     assert_no_difference 'Project.count' do
-      post :create, :params => {
+      post(
+        :create,
+        :params => {
           :project => {
             :name => "blog",
             :description => "weblog",
@@ -484,9 +492,9 @@ class ProjectsControllerTest < Redmine::ControllerTest
             :custom_field_values => {
               '3' => 'Beta'
             }
-
           }
         }
+      )
     end
     assert_response :success
     assert_select_error /Subproject of is invalid/
@@ -496,10 +504,11 @@ class ProjectsControllerTest < Redmine::ControllerTest
     Role.find(1).remove_permission! :add_project
     Role.find(1).add_permission! :add_subprojects
     @request.session[:user_id] = 2
-
     assert !User.find(2).member_of?(Project.find(6))
     assert_no_difference 'Project.count' do
-      post :create, :params => {
+      post(
+        :create,
+        :params => {
           :project => {
             :name => "blog",
             :description => "weblog",
@@ -509,9 +518,9 @@ class ProjectsControllerTest < Redmine::ControllerTest
               '3' => 'Beta'
             },
             :parent_id => 6
-
           }
         }
+      )
     end
     assert_response :success
     assert_select_error /Subproject of is invalid/
@@ -522,30 +531,33 @@ class ProjectsControllerTest < Redmine::ControllerTest
     default_role = Role.generate!(:permissions => [:view_issues, :add_project])
     user = User.generate!
     @request.session[:user_id] = user.id
-
     with_settings :new_project_user_role_id => default_role.id.to_s, :default_projects_modules => %w(news files) do
       project = new_record(Project) do
-        post :create, :params => {
+        post(
+          :create,
+          :params => {
             :project => {
               :name => "blog1",
               :identifier => "blog1",
               :enabled_module_names => ["issue_tracking", "repository"]
-
             }
           }
+        )
       end
       assert_equal %w(files news), project.enabled_module_names.sort
 
       default_role.add_permission!(:select_project_modules)
       project = new_record(Project) do
-        post :create, :params => {
+        post(
+          :create,
+          :params => {
             :project => {
               :name => "blog2",
               :identifier => "blog2",
               :enabled_module_names => ["issue_tracking", "repository"]
-
             }
           }
+        )
       end
       assert_equal %w(issue_tracking repository), project.enabled_module_names.sort
     end
@@ -555,20 +567,20 @@ class ProjectsControllerTest < Redmine::ControllerTest
     Role.find_by_name('Manager').add_permission! :add_subprojects
     parent = Project.find(1)
     @request.session[:user_id] = 2
-
     assert_difference 'Project.count' do
-      post :create, :params => {
+      post(
+        :create,
+        :params => {
           :project => {
             :name => 'inherited',
             :identifier => 'inherited',
             :parent_id => parent.id,
             :inherit_members => '1'
-
           }
         }
+      )
       assert_response 302
     end
-
     project = Project.order('id desc').first
     assert_equal 'inherited', project.name
     assert_equal parent, project.parent
@@ -580,14 +592,16 @@ class ProjectsControllerTest < Redmine::ControllerTest
     with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
       @request.session[:user_id] = 1
       assert_no_difference 'Project.count' do
-        post :create, :params => {
+        post(
+          :create,
+          :params => {
             :project => {
               :name => "blog",
               :identifier => "",
               :enabled_module_names => %w(issue_tracking news)
-
             }
           }
+        )
       end
       assert_response :success
       %w(issue_tracking news).each do |mod|
@@ -598,17 +612,13 @@ class ProjectsControllerTest < Redmine::ControllerTest
   end
 
   def test_show_by_id
-    get :show, :params => {
-        :id => 1
-      }
+    get(:show, :params => {:id => 1})
     assert_response :success
     assert_select '#header h1', :text => "eCookbook"
   end
 
   def test_show_by_identifier
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
+    get(:show, :params => {:id => 'ecookbook'})
     assert_response :success
     assert_select '#header h1', :text => "eCookbook"
   end
@@ -617,31 +627,22 @@ class ProjectsControllerTest < Redmine::ControllerTest
     p = Project.find(1)
     p.enabled_module_names = []
     p.save!
-
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
+    get(:show, :params => {:id => 'ecookbook'})
     assert_response :success
     assert_select '#main.nosidebar'
   end
 
   def test_show_should_display_visible_custom_fields
     ProjectCustomField.find_by_name('Development status').update_attribute :visible, true
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
+    get(:show, :params => {:id => 'ecookbook'})
     assert_response :success
-
     assert_select 'li[class=?]', 'cf_3', :text => /Development status/
   end
 
   def test_show_should_not_display_hidden_custom_fields
     ProjectCustomField.find_by_name('Development status').update_attribute :visible, false
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
+    get(:show, :params => {:id => 'ecookbook'})
     assert_response :success
-
     assert_select 'li', :text => /Development status/, :count => 0
   end
 
@@ -649,43 +650,30 @@ class ProjectsControllerTest < Redmine::ControllerTest
     f1 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Foo Bar), :multiple => true
     f2 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Baz Qux), :multiple => true
     project = Project.generate!(:custom_field_values => {f2.id.to_s => %w(Qux)})
-
-    get :show, :params => {
-        :id => project.id
-      }
+    get(:show, :params => {:id => project.id})
     assert_response :success
-
     assert_select 'li', :text => /#{f1.name}/, :count => 0
     assert_select 'li', :text => /#{f2.name}/
   end
 
   def test_show_should_not_display_blank_text_custom_fields
     f1 = ProjectCustomField.generate! :field_format => 'text'
-
-    get :show, :params => {
-        :id => 1
-      }
+    get(:show, :params => {:id => 1})
     assert_response :success
-
     assert_select 'li', :text => /#{f1.name}/, :count => 0
   end
 
   def test_show_should_not_fail_when_custom_values_are_nil
     project = Project.find_by_identifier('ecookbook')
     project.custom_values.first.update_attribute(:value, nil)
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
+    get(:show, :params => {:id => 'ecookbook'})
     assert_response :success
   end
 
   def test_show_archived_project_should_be_denied
     project = Project.find_by_identifier('ecookbook')
     project.archive
-
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
+    get(:show, :params => {:id => 'ecookbook'})
     assert_response 403
     assert_select 'p', :text => /archived/
     assert_not_include project.name, response.body
@@ -695,36 +683,27 @@ class ProjectsControllerTest < Redmine::ControllerTest
     @request.session[:user_id] = 1
     project = Project.find_by_identifier('ecookbook')
     project.archive
-
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
+    get(:show, :params => {:id => 'ecookbook'})
     assert_response 403
     assert_select 'a', :text => "Unarchive"
   end
 
   def test_show_should_not_show_private_subprojects_that_are_not_visible
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
+    get(:show, :params => {:id => 'ecookbook'})
     assert_response :success
     assert_select 'a', :text => /Private child/, :count => 0
   end
 
   def test_show_should_show_private_subprojects_that_are_visible
     @request.session[:user_id] = 2 # manager who is a member of the private subproject
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
+    get(:show, :params => {:id => 'ecookbook'})
     assert_response :success
     assert_select 'a', :text => /Private child/
   end
 
   def test_show_by_member_on_leaf_project_should_display_issue_counts
     @request.session[:user_id] = 2
-    get :show, :params => {
-        :id => 'onlinestore'
-      }
+    get(:show, :params => {:id => 'onlinestore'})
     assert_response :success
     # Make sure there's a > 0 issue count
     assert_select 'table.issue-report td.total a', :text => %r{\A[1-9]\d*\z}
@@ -732,10 +711,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   def test_show_should_spent_and_estimated_time
     @request.session[:user_id] = 1
-    get :show, :params => {
-        :id => 'ecookbook'
-      }
-
+    get(:show, :params => {:id => 'ecookbook'})
     assert_select 'div.spent_time.box>ul' do
       assert_select '>li:nth-child(1)', :text => 'Estimated time: 203.50 hours'
       assert_select '>li:nth-child(2)', :text => 'Spent time: 162.90 hours'
@@ -744,53 +720,42 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   def test_settings
     @request.session[:user_id] = 2 # manager
-    get :settings, :params => {
-        :id => 1
-      }
+    get(:settings, :params => {:id => 1})
     assert_response :success
-
     assert_select 'input[name=?]', 'project[name]'
   end
 
   def test_settings_of_subproject
     @request.session[:user_id] = 2
-    get :settings, :params => {
-        :id => 'private-child'
-      }
+    get(:settings, :params => {:id => 'private-child'})
     assert_response :success
-
     assert_select 'input[type=checkbox][name=?]', 'project[inherit_members]'
   end
 
   def test_settings_should_be_denied_for_member_on_closed_project
     Project.find(1).close
     @request.session[:user_id] = 2 # manager
-
-    get :settings, :params => {
-        :id => 1
-      }
+    get(:settings, :params => {:id => 1})
     assert_response 403
   end
 
   def test_settings_should_be_denied_for_anonymous_on_closed_project
     Project.find(1).close
-
-    get :settings, :params => {
-        :id => 1
-      }
+    get(:settings, :params => {:id => 1})
     assert_response 403
   end
 
   def test_settings_should_accept_version_status_filter
     @request.session[:user_id] = 2
-
-    get :settings, :params => {
+    get(
+      :settings,
+      :params => {
         :id => 'ecookbook',
         :tab => 'versions',
         :version_status => 'locked'
       }
+    )
     assert_response :success
-
     assert_select 'select[name=version_status]' do
       assert_select 'option[value=locked][selected=selected]'
     end
@@ -803,15 +768,16 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   def test_settings_should_accept_version_name_filter
     @request.session[:user_id] = 2
-
-    get :settings, :params => {
+    get(
+      :settings,
+      :params => {
         :id => 'ecookbook',
         :tab => 'versions',
         :version_status => '',
         :version_name => '.1'
       }
+    )
     assert_response :success
-
     assert_select 'input[name=version_name][value=?]', '.1'
     assert_select 'table.versions tbody' do
       assert_select 'tr', 1
@@ -824,15 +790,15 @@ class ProjectsControllerTest < Redmine::ControllerTest
     project = Project.find(1)
     project.default_version_id = 3
     project.save!
-
     @request.session[:user_id] = 2
-
-    get :settings, :params => {
+    get(
+      :settings,
+      :params => {
         :id => 'ecookbook',
         :tab => 'versions',
       }
+    )
     assert_response :success
-
     assert_select 'table.versions tbody' do
       # asserts that only one version is marked as default
       assert_select 'td.tick span.icon-checked', 1
@@ -847,11 +813,13 @@ class ProjectsControllerTest < Redmine::ControllerTest
     user.lock!
     assert user.reload.locked?
     @request.session[:user_id] = 2
-
-    get :settings, :params => {
+    get(
+      :settings,
+      :params => {
         :id => 'ecookbook',
         :tab => 'members'
       }
+    )
     assert_response :success
     assert_select "tr#member-#{member.id}"
   end
@@ -860,18 +828,13 @@ class ProjectsControllerTest < Redmine::ControllerTest
     @request.session[:user_id] = 3
     project = Project.find(1)
     role = User.find(3).roles_for_project(project).first
-
     role.permissions = []
     role.save
-    get :settings, :params => {
-      :id => project.id
-    }
+    get(:settings, :params => {:id => project.id})
     assert_response 403
 
     role.add_permission! :manage_repository, :manage_boards, :manage_project_activities
-    get :settings, :params => {
-      :id => project.id
-    }
+    get(:settings, :params => {:id => project.id})
     assert_response :success
     assert_select 'a[id^=tab-]', 3
     assert_select 'a#tab-repositories'
@@ -881,25 +844,29 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   def test_settings_should_not_display_custom_fields_not_visible_for_user
     @request.session[:user_id] = 2
-
     ProjectCustomField.find_by_name('Development status').update_attribute :visible, false
-    get :settings, :params => {
+    get(
+      :settings,
+      :params => {
         :id => 'ecookbook'
       }
+    )
     assert_response :success
-
     assert_select 'select#project_custom_field_values_3', :count => 0
   end
 
   def test_update
     @request.session[:user_id] = 2 # manager
-    post :update, :params => {
+    post(
+      :update,
+      :params => {
         :id => 1,
         :project => {
           :name => 'Test changed name',
           :issue_custom_field_ids => ['']
         }
       }
+    )
     assert_redirected_to '/projects/ecookbook/settings'
     project = Project.find(1)
     assert_equal 'Test changed name', project.name
@@ -907,12 +874,15 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   def test_update_with_failure
     @request.session[:user_id] = 2 # manager
-    post :update, :params => {
+    post(
+      :update,
+      :params => {
         :id => 1,
         :project => {
           :name => ''
         }
       }
+    )
     assert_response :success
     assert_select_error /name cannot be blank/i
   end
@@ -920,26 +890,30 @@ class ProjectsControllerTest < Redmine::ControllerTest
   def test_update_should_be_denied_for_member_on_closed_project
     Project.find(1).close
     @request.session[:user_id] = 2 # manager
-
-    post :update, :params => {
+    post(
+      :update,
+      :params => {
         :id => 1,
         :project => {
           :name => 'Closed'
         }
       }
+    )
     assert_response 403
     assert_equal 'eCookbook', Project.find(1).name
   end
 
   def test_update_should_be_denied_for_anonymous_on_closed_project
     Project.find(1).close
-
-    post :update, :params => {
+    post(
+      :update,
+      :params => {
         :id => 1,
         :project => {
           :name => 'Closed'
         }
       }
+    )
     assert_response 403
     assert_equal 'eCookbook', Project.find(1).name
   end
@@ -949,13 +923,15 @@ class ProjectsControllerTest < Redmine::ControllerTest
     user = User.generate!
     User.add_to_project(user, child, Role.generate!(:permissions => [:edit_project]))
     @request.session[:user_id] = user.id
-
-    post :update, :params => {
+    post(
+      :update,
+      :params => {
         :id => child.id,
         :project => {
           :name => 'Updated'
         }
       }
+    )
     assert_response 302
     assert_match /Successful update/, flash[:notice]
   end
@@ -964,12 +940,15 @@ class ProjectsControllerTest < Redmine::ControllerTest
     @request.session[:user_id] = 2
     Project.find(1).enabled_module_names = ['issue_tracking', 'news']
 
-    post :update, :params => {
+    post(
+      :update,
+      :params => {
         :id => 1,
         :project => {
           :enabled_module_names => ['issue_tracking', 'repository', 'documents']
         }
       }
+    )
     assert_redirected_to '/projects/ecookbook/settings'
     assert_equal ['documents', 'issue_tracking', 'repository'], Project.find(1).enabled_module_names.sort
   end
@@ -978,9 +957,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
     @request.session[:user_id] = 1 # admin
 
     assert_no_difference 'Project.count' do
-      delete :destroy, :params => {
-          :id => 2
-        }
+      delete(:destroy, :params => {:id => 2})
       assert_response :success
     end
     assert_select '.warning', :text => /Are you sure you want to delete this project/
@@ -991,9 +968,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
     @request.session[:user_id] = 1 # admin
 
     assert_no_difference 'Project.count' do
-      delete :destroy, :params => {
-          :id => 1
-        }
+      delete(:destroy, :params => {:id => 1})
       assert_response :success
     end
     assert_select 'strong',
@@ -1007,10 +982,13 @@ class ProjectsControllerTest < Redmine::ControllerTest
     @request.session[:user_id] = 1 # admin
 
     assert_difference 'Project.count', -5 do
-      delete :destroy, :params => {
+      delete(
+        :destroy,
+        :params => {
           :id => 1,
           :confirm => 1
         }
+      )
       assert_redirected_to '/admin/projects'
     end
     assert_nil Project.find_by_id(1)
@@ -1018,9 +996,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   def test_archive
     @request.session[:user_id] = 1 # admin
-    post :archive, :params => {
-        :id => 1
-      }
+    post(:archive, :params => {:id => 1})
     assert_redirected_to '/admin/projects'
     assert !Project.find(1).active?
   end
@@ -1028,9 +1004,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
   def test_archive_with_failure
     @request.session[:user_id] = 1
     Project.any_instance.stubs(:archive).returns(false)
-    post :archive, :params => {
-        :id => 1
-      }
+    post(:archive, :params => {:id => 1})
     assert_redirected_to '/admin/projects'
     assert_match /project cannot be archived/i, flash[:error]
   end
@@ -1038,18 +1012,14 @@ class ProjectsControllerTest < Redmine::ControllerTest
   def test_unarchive
     @request.session[:user_id] = 1 # admin
     Project.find(1).archive
-    post :unarchive, :params => {
-        :id => 1
-      }
+    post(:unarchive, :params => {:id => 1})
     assert_redirected_to '/admin/projects'
     assert Project.find(1).active?
   end
 
   def test_close
     @request.session[:user_id] = 2
-    post :close, :params => {
-        :id => 1
-      }
+    post(:close, :params => {:id => 1})
     assert_redirected_to '/projects/ecookbook'
     assert_equal Project::STATUS_CLOSED, Project.find(1).status
   end
@@ -1057,9 +1027,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
   def test_reopen
     Project.find(1).close
     @request.session[:user_id] = 2
-    post :reopen, :params => {
-        :id => 1
-      }
+    post(:reopen, :params => {:id => 1})
     assert_redirected_to '/projects/ecookbook'
     assert Project.find(1).active?
   end
@@ -1069,9 +1037,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
     parent = nil
     6.times do |i|
       p = Project.generate_with_parent!(parent)
-      get :show, :params => {
-          :id => p
-        }
+      get(:show, :params => {:id => p})
       assert_select '#header h1' do
         assert_select 'a', :count => [i, 3].min
       end
@@ -1083,10 +1049,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
   def test_get_copy
     @request.session[:user_id] = 1 # admin
     orig = Project.find(1)
-
-    get :copy, :params => {
-        :id => orig.id
-      }
+    get(:copy, :params => {:id => orig.id})
     assert_response :success
 
     assert_select 'textarea[name=?]', 'project[description]', :text => orig.description
@@ -1095,9 +1058,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   def test_get_copy_with_invalid_source_should_respond_with_404
     @request.session[:user_id] = 1
-    get :copy, :params => {
-        :id => 99
-      }
+    get(:copy, :params => {:id => 99})
     assert_response 404
   end
 
@@ -1107,9 +1068,7 @@ class ProjectsControllerTest < Redmine::ControllerTest
     source = Project.generate!(:issue_custom_fields => [field1])
     @request.session[:user_id] = 1
 
-    get :copy, :params => {
-        :id => source.id
-      }
+    get(:copy, :params => {:id => source.id})
     assert_response :success
     assert_select 'input[type=hidden][name=?][value=?]', 'project[issue_custom_field_ids][]', field1.id.to_s
     assert_select 'input[type=hidden][name=?][value=?]', 'project[issue_custom_field_ids][]', field2.id.to_s, 0
@@ -1120,17 +1079,19 @@ class ProjectsControllerTest < Redmine::ControllerTest
     CustomField.delete_all
 
     assert_difference 'Project.count' do
-      post :copy, :params => {
+      post(
+        :copy,
+        :params => {
           :id => 1,
           :project => {
             :name => 'Copy',
             :identifier => 'unique-copy',
             :tracker_ids => ['1', '2', '3', ''],
             :enabled_module_names => %w(issue_tracking time_tracking)
-
           },
           :only => %w(issues versions)
         }
+      )
     end
     project = Project.find('unique-copy')
     source = Project.find(1)
@@ -1143,26 +1104,32 @@ class ProjectsControllerTest < Redmine::ControllerTest
 
   def test_post_copy_should_redirect_to_settings_when_successful
     @request.session[:user_id] = 1 # admin
-    post :copy, :params => {
+    post(
+      :copy,
+      :params => {
         :id => 1,
         :project => {
           :name => 'Copy',
           :identifier => 'unique-copy'
         }
       }
+    )
     assert_response :redirect
     assert_redirected_to :controller => 'projects', :action => 'settings', :id => 'unique-copy'
   end
 
   def test_post_copy_with_failure
     @request.session[:user_id] = 1
-    post :copy, :params => {
+    post(
+      :copy,
+      :params => {
         :id => 1,
         :project => {
           :name => 'Copy',
           :identifier => ''
         }
       }
+    )
     assert_response :success
     assert_select_error /Identifier cannot be blank/
   end
@@ -1189,47 +1156,54 @@ class ProjectsControllerTest < Redmine::ControllerTest
   end
 
   def test_index_jump_without_project_id_should_redirect_to_active_tab
-    get :index, :params => {
-        :jump => 'issues'
-      }
+    get(:index, :params => {:jump => 'issues'})
     assert_redirected_to '/issues'
   end
 
   def test_index_jump_should_not_redirect_to_unknown_tab
-    get :index, :params => {
+    get(
+      :index,
+      :params => {
         :jump => 'foobar'
       }
+    )
     assert_response :success
   end
 
   def test_show_jump_should_redirect_to_active_tab
-    get :show, :params => {
+    get(
+      :show,
+      :params => {
         :id => 1,
         :jump => 'issues'
       }
+    )
     assert_redirected_to '/projects/ecookbook/issues'
   end
 
   def test_show_jump_should_not_redirect_to_inactive_tab
-    get :show, :params => {
+    get(
+      :show, :params => {
         :id => 3,
         :jump => 'documents'
       }
+    )
     assert_response :success
   end
 
   def test_show_jump_should_not_redirect_to_unknown_tab
-    get :show, :params => {
+    get(
+      :show,
+      :params => {
         :id => 3,
         :jump => 'foobar'
       }
+    )
     assert_response :success
   end
 
   def test_body_should_have_project_css_class
-    get :show, :params => {
-        :id => 1
-      }
+    get(:show, :params => {:id => 1})
     assert_select 'body.project-ecookbook'
   end