Do not build a projects_by_role Hash that gets updated when accessing a key that is not present (#11662).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@10242 e93f8b46-1217-0410-a6f0-8f06a7374b81

1 files changed, 7 insertions, 0 deletions

diff --git a/test/unit/user_test.rb b/test/unit/user_test.rb
index 51a49de01..7b4dac725 100644
--- a/test/unit/user_test.rb
+++ b/test/unit/user_test.rb
@@ -744,6 +744,13 @@ class UserTest < ActiveSupport::TestCase
     assert_equal [2], user.projects_by_role[Role.find(2)].collect(&:id).sort
   end
 
+  def test_accessing_projects_by_role_with_no_projects_should_return_an_empty_array
+    user = User.find(2)
+    assert_equal [], user.projects_by_role[Role.find(3)]
+    # should not update the hash
+    assert_nil user.projects_by_role.values.detect(&:blank?)
+  end
+
   def test_projects_by_role_for_user_with_no_role
     user = User.generate!
     assert_equal({}, user.projects_by_role)