REST API for project memberships (#7420).

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@8798 e93f8b46-1217-0410-a6f0-8f06a7374b81

2 files changed, 210 insertions, 0 deletions

diff --git a/test/integration/api_test/memberships_test.rb b/test/integration/api_test/memberships_test.rb
new file mode 100644
index 000000000..04696962a
--- /dev/null
+++ b/test/integration/api_test/memberships_test.rb
@@ -0,0 +1,190 @@
+# Redmine - project management software
+# Copyright (C) 2006-2012  Jean-Philippe Lang
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+
+require File.expand_path('../../../test_helper', __FILE__)
+
+class ApiTest::MembershipsTest < ActionController::IntegrationTest
+  fixtures :projects, :users, :roles, :members, :member_roles
+
+  def setup
+    Setting.rest_api_enabled = '1'
+  end
+
+  context "/projects/:project_id/memberships" do
+    context "GET" do
+      context "xml" do
+        should "return memberships" do
+          get '/projects/1/memberships.xml', {}, credentials('jsmith')
+
+          assert_response :success
+          assert_equal 'application/xml', @response.content_type
+          assert_tag :tag => 'memberships',
+            :attributes => {:type => 'array'},
+            :child => {
+              :tag => 'membership',
+              :child => {
+                :tag => 'id',
+                :content => '2',
+                :sibling => {
+                  :tag => 'user',
+                  :attributes => {:id => '3', :name => 'Dave Lopper'},
+                  :sibling => {
+                    :tag => 'roles',
+                    :child => {
+                      :tag => 'role',
+                      :attributes => {:id => '2', :name => 'Developer'}
+                    }
+                  }
+                }
+              }
+            }
+        end
+      end
+
+      context "json" do
+        should "return memberships" do
+          get '/projects/1/memberships.json', {}, credentials('jsmith')
+
+          assert_response :success
+          assert_equal 'application/json', @response.content_type
+          json = ActiveSupport::JSON.decode(response.body)
+          assert_equal({
+            "memberships" =>
+              [{"id"=>1,
+                "project" => {"name"=>"eCookbook", "id"=>1},
+                "roles" => [{"name"=>"Manager", "id"=>1}],
+                "user" => {"name"=>"John Smith", "id"=>2}},
+               {"id"=>2,
+                "project" => {"name"=>"eCookbook", "id"=>1},
+                "roles" => [{"name"=>"Developer", "id"=>2}],
+                "user" => {"name"=>"Dave Lopper", "id"=>3}}],
+           "limit" => 25,
+           "total_count" => 2,
+           "offset" => 0},
+           json)
+        end
+      end
+    end
+
+    context "POST" do
+      context "xml" do
+        should "create membership" do
+          assert_difference 'Member.count' do
+            post '/projects/1/memberships.xml', {:membership => {:user_id => 7, :role_ids => [2,3]}}, credentials('jsmith')
+
+            assert_response :created
+          end
+        end
+
+        should "return errors on failure" do
+          assert_no_difference 'Member.count' do
+            post '/projects/1/memberships.xml', {:membership => {:role_ids => [2,3]}}, credentials('jsmith')
+
+            assert_response :unprocessable_entity
+            assert_equal 'application/xml', @response.content_type
+            assert_tag 'errors', :child => {:tag => 'error', :content => "Principal can't be blank"}
+          end
+        end
+      end
+    end
+  end
+
+  context "/memberships/:id" do
+    context "GET" do
+      context "xml" do
+        should "return the membership" do
+          get '/memberships/2.xml', {}, credentials('jsmith')
+
+          assert_response :success
+          assert_equal 'application/xml', @response.content_type
+          assert_tag :tag => 'membership',
+            :child => {
+              :tag => 'id',
+              :content => '2',
+              :sibling => {
+                :tag => 'user',
+                :attributes => {:id => '3', :name => 'Dave Lopper'},
+                :sibling => {
+                  :tag => 'roles',
+                  :child => {
+                    :tag => 'role',
+                    :attributes => {:id => '2', :name => 'Developer'}
+                  }
+                }
+              }
+            }
+        end
+      end
+
+      context "json" do
+        should "return the membership" do
+          get '/memberships/2.json', {}, credentials('jsmith')
+
+          assert_response :success
+          assert_equal 'application/json', @response.content_type
+          json = ActiveSupport::JSON.decode(response.body)
+          assert_equal(
+            {"membership" => {
+              "id" => 2,
+              "project" => {"name"=>"eCookbook", "id"=>1},
+              "roles" => [{"name"=>"Developer", "id"=>2}],
+              "user" => {"name"=>"Dave Lopper", "id"=>3}}
+            },
+            json)
+        end
+      end
+    end
+
+    context "PUT" do
+      context "xml" do
+        should "update membership" do
+          assert_not_equal [1,2], Member.find(2).role_ids.sort
+          assert_no_difference 'Member.count' do
+            put '/memberships/2.xml', {:membership => {:user_id => 3, :role_ids => [1,266]}}, credentials('jsmith')
+
+            assert_response :ok
+          end
+          member = Member.find(2)
+          assert_equal [1,2], member.role_ids.sort
+        end
+      end
+    end
+
+    context "DELETE" do
+      context "xml" do
+        should "destroy membership" do
+          assert_difference 'Member.count', -1 do
+            delete '/memberships/2.xml', {}, credentials('jsmith')
+
+            assert_response :ok
+          end
+          assert_nil Member.find_by_id(2)
+        end
+
+        should "respond with 422 on failure" do
+          assert_no_difference 'Member.count' do
+            # A membership with an inherited role can't be deleted
+            Member.find(2).member_roles.first.update_attribute :inherited_from, 99
+            delete '/memberships/2.xml', {}, credentials('jsmith')
+
+            assert_response :unprocessable_entity
+          end
+        end
+      end
+    end
+  end
+end
diff --git a/test/integration/routing/members_test.rb b/test/integration/routing/members_test.rb
index 4c78b15c7..87181b089 100644
--- a/test/integration/routing/members_test.rb
+++ b/test/integration/routing/members_test.rb
@@ -20,18 +20,38 @@ require File.expand_path('../../../test_helper', __FILE__)
 class RoutingMembersTest < ActionController::IntegrationTest
   def test_members
     assert_routing(
+        { :method => 'get', :path => "/projects/5234/memberships.xml" },
+        { :controller => 'members', :action => 'index', :project_id => '5234', :format => 'xml' }
+      )
+    assert_routing(
+        { :method => 'get', :path => "/memberships/5234.xml" },
+        { :controller => 'members', :action => 'show', :id => '5234', :format => 'xml' }
+      )
+    assert_routing(
         { :method => 'post', :path => "/projects/5234/memberships" },
         { :controller => 'members', :action => 'create', :project_id => '5234' }
       )
     assert_routing(
+        { :method => 'post', :path => "/projects/5234/memberships.xml" },
+        { :controller => 'members', :action => 'create', :project_id => '5234', :format => 'xml' }
+      )
+    assert_routing(
         { :method => 'put', :path => "/memberships/5234" },
         { :controller => 'members', :action => 'update', :id => '5234' }
       )
     assert_routing(
+        { :method => 'put', :path => "/memberships/5234.xml" },
+        { :controller => 'members', :action => 'update', :id => '5234', :format => 'xml' }
+      )
+    assert_routing(
         { :method => 'delete', :path => "/memberships/5234" },
         { :controller => 'members', :action => 'destroy', :id => '5234' }
       )
     assert_routing(
+        { :method => 'delete', :path => "/memberships/5234.xml" },
+        { :controller => 'members', :action => 'destroy', :id => '5234', :format => 'xml' }
+      )
+    assert_routing(
         { :method => 'get', :path => "/projects/5234/memberships/autocomplete" },
         { :controller => 'members', :action => 'autocomplete', :project_id => '5234' }
       )