diff options
| -rw-r--r-- | app/models/issue_query.rb | 2 | ||||
| -rw-r--r-- | test/unit/query_test.rb | 16 |
2 files changed, 16 insertions, 2 deletions
diff --git a/app/models/issue_query.rb b/app/models/issue_query.rb index 42d6df40f..417b98b2a 100644 --- a/app/models/issue_query.rb +++ b/app/models/issue_query.rb @@ -550,7 +550,7 @@ class IssueQuery < Query if relation_options[:sym] == field && !options[:reverse] sqls = [sql, sql_for_relations(field, operator, value, :reverse => true)] - sql = sqls.join(["!", "!*", "!p"].include?(operator) ? " AND " : " OR ") + sql = sqls.join(["!", "!*", "!p", '!o'].include?(operator) ? " AND " : " OR ") end "(#{sql})" end diff --git a/test/unit/query_test.rb b/test/unit/query_test.rb index 206677c26..9e4c76417 100644 --- a/test/unit/query_test.rb +++ b/test/unit/query_test.rb @@ -897,7 +897,7 @@ class QueryTest < ActiveSupport::TestCase assert_include 2, ids end - def test_filter_on_relations_with_no_open_issues + def test_filter_on_blocked_by_no_open_issues IssueRelation.delete_all # Issue 1 is blocked by 8, which is closed IssueRelation.create!(:relation_type => "blocked", :issue_from => Issue.find(1), :issue_to => Issue.find(8)) @@ -911,6 +911,20 @@ class QueryTest < ActiveSupport::TestCase assert_include 1, ids end + def test_filter_on_related_with_no_open_issues + IssueRelation.delete_all + # Issue 1 is blocked by 8, which is closed + IssueRelation.create!(relation_type: 'relates', issue_from: Issue.find(1), issue_to: Issue.find(8)) + # Issue 2 is blocked by 3, which is open + IssueRelation.create!(relation_type: 'relates', issue_from: Issue.find(2), issue_to: Issue.find(3)) + + query = IssueQuery.new(:name => '_') + query.filters = { 'relates' => { operator: '!o', values: [''] } } + ids = find_issues_with_query(query).map(&:id) + assert_equal [], ids & [2] + assert_include 1, ids + end + def test_filter_on_relations_with_no_issues IssueRelation.delete_all IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(2)) |