summaryrefslogtreecommitdiffstats
path: root/app/models
Commit message (Collapse)AuthorAgeFilesLines
* FrozenError when using SQLite3 gem version 2.0.0 or later (#41860).Go MAEDA2024-11-251-2/+1
| | | | | | | Patch by Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@23308 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fixes project query scope that does not take into account limit and offset ↵Marius Balteanu2024-11-231-1/+3
| | | | | | options (#41791). git-svn-id: https://svn.redmine.org/redmine/trunk@23300 e93f8b46-1217-0410-a6f0-8f06a7374b81
* @ProjectQuery#results_scope@ should return @Project::ActiveRecord_Relation@ ↵Marius Balteanu2024-11-031-2/+1
| | | | | | | | | | to keep the backward compatibility (#41678, #23954). Patch by Nishida Yuya (user:nishidayuya). git-svn-id: https://svn.redmine.org/redmine/trunk@23187 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix: "Import issues" and "Import time entries" pages are visible to users ↵Go MAEDA2024-11-032-2/+2
| | | | | | | | | without "Add issues" and "Log spent time" permissions (#41465). Patch by Kenta Kumojima (user:kumojima). git-svn-id: https://svn.redmine.org/redmine/trunk@23178 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix: `updated_by_id` in Journal points to a deleted user instead of an ↵Go MAEDA2024-10-291-0/+1
| | | | | | | | | anonymous user (#41572). Patch by Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@23169 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix CSV import file encoding auto-detection failure with multibyte ↵Go MAEDA2024-10-201-1/+15
| | | | | | | | | characters (#41464). Patch by Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@23150 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Include attachment filename in "File added" email notification subject (#41450).Go MAEDA2024-10-201-1/+4
| | | | | | | Patch by minoura makoto (user:minoura). git-svn-id: https://svn.redmine.org/redmine/trunk@23148 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Lint/SafeNavigationConsistency (#39887).Go MAEDA2024-10-162-2/+2
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@23134 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Replace custom email normalization logic with Rails' `normalizes` method ↵Go MAEDA2024-09-201-9/+7
| | | | | | (#29208). git-svn-id: https://svn.redmine.org/redmine/trunk@23064 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Add "Author / Previous assignee" group to assignee dropdown in issue form ↵Go MAEDA2024-09-151-0/+12
| | | | | | | | | (#16045). Patch by Luka Lüdicke (user:dkd-luedicke), Mizuki ISHIKAWA (user:ishikawa999), and Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@23059 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix NoMethodError in Issue#blocked? due to invalid issue_from_id in ↵Go MAEDA2024-09-101-1/+1
| | | | | | | | | Issue#relations_from (#8539). Patch by Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@23048 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Remove unnecessary rubocop:disable directive for Style/EmptyLiteral (#39887).Go MAEDA2024-09-051-2/+2
| | | | | | | RuboCop’s Style/EmptyLiteral false positive for `Hash.new([])` was resolved in RuboCop 1.66.1. This commit updates the RuboCop version to 1.66.1 and removes the now-unnecessary `rubocop:disable` directives. git-svn-id: https://svn.redmine.org/redmine/trunk@23013 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Style/StringChars (#39887).Go MAEDA2024-09-011-1/+1
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@23009 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Revert r23002 (#39887).Go MAEDA2024-09-011-2/+2
| | | | | | | | | | | | | | The change caused a test failure: ``` Failure: UserTest#test_accessing_projects_by_role_with_no_projects_should_return_an_empty_array [test/unit/user_test.rb:1048]: Expected: [] Actual: nil ``` git-svn-id: https://svn.redmine.org/redmine/trunk@23006 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Disable RuboCop Lint/InterpolationCheck for USER_FORMATS in ↵Go MAEDA2024-09-011-0/+2
| | | | | | app/models/user.rb (#39887). git-svn-id: https://svn.redmine.org/redmine/trunk@23005 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Style/EmptyLiteral (#39887).Go MAEDA2024-09-011-2/+2
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@23002 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Style/RedundantInterpolationUnfreeze (#39887).Go MAEDA2024-09-012-2/+2
| | | | | | | Since interpolated strings are always unfrozen in Ruby 3.0 and later, the use of `+""` is now redundant. git-svn-id: https://svn.redmine.org/redmine/trunk@23001 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix precision issues in TimeEntry#hours calculation by returning Rational ↵Go MAEDA2024-08-311-1/+8
| | | | | | | | | instead of Float (#40914). Patch by Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@23000 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offenses Style/NegatedIf and Style/NegatedWhile (#39887, #7770).Go MAEDA2024-08-255-7/+9
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22987 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Style/ClassEqualityComparison (#39887).Go MAEDA2024-08-211-1/+1
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22978 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Introduce `active?` method to Group via Principal model (#27510).Go MAEDA2024-08-212-4/+4
| | | | | | | Patch by Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@22976 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Add filters for "Author's group" and "Author's role" to issues list (#7867).Go MAEDA2024-08-211-0/+38
| | | | | | | Patch by Takenori TAKAKI (user:takenory). git-svn-id: https://svn.redmine.org/redmine/trunk@22975 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Use anonymous block forwarding introduced in Ruby 3.1 (#38585).Go MAEDA2024-08-215-10/+10
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22973 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Use Array#intersect? introduced in Ruby 3.1 (#38585).Go MAEDA2024-08-206-6/+6
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22972 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Add filters for "User's group" and "User's role" to Spent time list (#41053).Go MAEDA2024-08-161-0/+59
| | | | | | | Patch by Takenori TAKAKI (user:takenory). git-svn-id: https://svn.redmine.org/redmine/trunk@22958 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Layout/SpaceInsideParens, one of the offenses enabled in ↵Go MAEDA2024-08-122-2/+2
| | | | | | rubocop-rails-omakase (#39887). git-svn-id: https://svn.redmine.org/redmine/trunk@22954 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Layout/EmptyLinesAroundMethodBody, one of the offenses ↵Go MAEDA2024-08-121-1/+0
| | | | | | enabled in rubocop-rails-omakase (#39887). git-svn-id: https://svn.redmine.org/redmine/trunk@22950 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix incorrect sorting of users grouped by status in issue filters for ↵Go MAEDA2024-08-111-3/+3
| | | | | | | | | administrators (#41079). Patch by Vladislav Moiseev (user:vladdy.moses). git-svn-id: https://svn.redmine.org/redmine/trunk@22947 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Add project identifier to List-Id header in notification emails (#13359).Go MAEDA2024-07-261-3/+12
| | | | | | | Patch by Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@22944 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Set default age parameter for User.prune method to 30 days (#41023).Go MAEDA2024-07-191-1/+1
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22938 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Add an option to render Integer and Float custom fields with thousands ↵Go MAEDA2024-07-181-1/+7
| | | | | | | | | delimiters (#39997). Patch by Go MAEDA (user:maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@22935 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Check view watchers permission when copying issues (#40946).Marius Balteanu2024-07-081-2/+2
| | | | | | | Patch by Jens Kraemer (@jkraemer). git-svn-id: https://svn.redmine.org/redmine/trunk@22914 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Truncate git authors to 255 characters (#40948).Marius Balteanu2024-07-081-1/+1
| | | | | | | | | | The committer column in the database allows max 255 characters. With longer authors, this would result in a schema violation. By manually truncating the author field, we can avoid this. Patch by Holger Just (@hjust). git-svn-id: https://svn.redmine.org/redmine/trunk@22910 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Expose project updated_on column and filter in project query (#40829).Go MAEDA2024-06-271-0/+2
| | | | | | | Patch by Felix Schäfer (@felix). git-svn-id: https://svn.redmine.org/redmine/trunk@22899 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Creating a new issue fails with an internal error if no issue priorities are ↵Go MAEDA2024-06-251-1/+1
| | | | | | | | | defined (#40860). Patch by Holger Just (@hjust). git-svn-id: https://svn.redmine.org/redmine/trunk@22895 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Reject passwords that are the same as login, first name, last name, or email ↵Go MAEDA2024-06-211-0/+11
| | | | | | | | | (#37279). Patch by Go MAEDA (@maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@22888 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Optimize Version#behind_schedule? by avoiding the call to completed_percent ↵Go MAEDA2024-06-171-8/+5
| | | | | | | | | when due_date or start_date is nil (#40798). Patch by Go MAEDA (@maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@22882 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Optimize FixedIssuesExtension#closed_percent by bypassing issues_progress ↵Go MAEDA2024-06-171-0/+1
| | | | | | | | | when all issues are closed (#40798). Patch by Go MAEDA (@maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@22881 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Optimize Version model by reducing redundant SQL count queries (#40798).Go MAEDA2024-06-171-14/+10
| | | | | | | Patch by Go MAEDA (@maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@22880 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Rails/ActiveRecordCallbacksOrder (#39889).Go MAEDA2024-06-1711-16/+16
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22879 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Suppress RuboCop false positive for Security/Open (#39887).Go MAEDA2024-06-061-1/+1
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22862 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Naming/MemoizedInstanceVariableName (#37862, #1671).Go MAEDA2024-06-051-1/+1
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22860 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Adds estimated remaining time to version page (#37862, #1671).Marius Balteanu2024-06-041-0/+12
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22858 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Move logic for estimated remaining hours from @QueryColumn@ to @Issue@ (#37862).Marius Balteanu2024-06-042-18/+10
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22857 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Adds description field to custom queries (#9309).Marius Balteanu2024-06-041-0/+1
| | | | | | | Patch by Go MAEDA (@maeda). git-svn-id: https://svn.redmine.org/redmine/trunk@22855 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Style/SuperArguments (#39887).Go MAEDA2024-05-236-8/+8
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22842 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Ignore statuses in Project#rolled_up_statuses which only have an identity ↵Go MAEDA2024-05-161-0/+1
| | | | | | | | | transition defined (#40693). Patch by Holger Just (@hjust). git-svn-id: https://svn.redmine.org/redmine/trunk@22833 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Explicitly reference table name in Project#like scope to avoid ambiguity ↵Go MAEDA2024-05-141-1/+1
| | | | | | | | | (#40691). Patch by Vincent Robert (@Nanego). git-svn-id: https://svn.redmine.org/redmine/trunk@22830 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fix RuboCop offense Style/RedundantSelfAssignment (#40412).Go MAEDA2024-05-131-1/+1
| | | | git-svn-id: https://svn.redmine.org/redmine/trunk@22826 e93f8b46-1217-0410-a6f0-8f06a7374b81
* Fixes issue list filter "Watched by: me" only shows issues watched via group ↵Marius Balteanu2024-05-111-1/+3
| | | | | | for projects with the @view_issue_watchers@ permission (#40412). git-svn-id: https://svn.redmine.org/redmine/trunk@22819 e93f8b46-1217-0410-a6f0-8f06a7374b81