From 319eeae14d02bad302b83b49aeac85aec4c24fd2 Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Tue, 22 Oct 2019 12:41:09 +0000 Subject: code cleanup: rubocop: fix Performance/RedundantBlockCall in lib/redmine/scm/adapters/abstract_adapter.rb git-svn-id: http://svn.redmine.org/redmine/trunk@18820 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop_todo.yml | 1 - lib/redmine/scm/adapters/abstract_adapter.rb | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index bb54e92d8..14e1519ce 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -530,7 +530,6 @@ Performance/FixedSize: Performance/RedundantBlockCall: Exclude: - 'app/controllers/application_controller.rb' - - 'lib/redmine/scm/adapters/abstract_adapter.rb' # Cop supports --auto-correct. Performance/RedundantMatch: diff --git a/lib/redmine/scm/adapters/abstract_adapter.rb b/lib/redmine/scm/adapters/abstract_adapter.rb index 67a1f17a3..14f8f09c4 100644 --- a/lib/redmine/scm/adapters/abstract_adapter.rb +++ b/lib/redmine/scm/adapters/abstract_adapter.rb @@ -249,7 +249,7 @@ module Redmine IO.popen(cmd, mode) do |io| io.set_encoding("ASCII-8BIT") if io.respond_to?(:set_encoding) io.close_write unless options[:write_stdin] - block.call(io) if block_given? + yield(io) if block_given? end rescue => e msg = strip_credential(e.message) -- cgit v1.2.3