From d4edf7cda6ad9625e32ea208ade149757302e792 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Sun, 14 Mar 2021 06:59:31 +0000 Subject: Merged r20783 from trunk to 4.0-stable (#33548). git-svn-id: http://svn.redmine.org/redmine/branches/4.0-stable@20785 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/query.rb | 2 +- test/unit/query_test.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/models/query.rb b/app/models/query.rb index 796480f3a..ff07a077e 100644 --- a/app/models/query.rb +++ b/app/models/query.rb @@ -48,7 +48,7 @@ class QueryColumn # Returns true if the column is sortable, otherwise false def sortable? - !@sortable.nil? + @sortable.present? end def sortable diff --git a/test/unit/query_test.rb b/test/unit/query_test.rb index 597168fb8..6a059ca8e 100644 --- a/test/unit/query_test.rb +++ b/test/unit/query_test.rb @@ -1485,6 +1485,16 @@ class QueryTest < ActiveSupport::TestCase assert !q.sortable_columns['cf_1'] end + def test_sortable_should_return_false_for_multi_custom_field + field = CustomField.find(1) + field.update_attribute :multiple, true + + q = IssueQuery.new + + field_column = q.available_columns.detect {|c| c.name==:cf_1} + assert !field_column.sortable? + end + def test_default_sort q = IssueQuery.new assert_equal [['id', 'desc']], q.sort_criteria -- cgit v1.2.3