From e3ffb1f23b778e95833dccaa4d121753a2bfa760 Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Sat, 24 Jan 2015 10:25:05 +0000 Subject: Use journalized attachments to prevent a query when displaying added file. git-svn-id: http://svn.redmine.org/redmine/trunk@13937 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/helpers/issues_helper.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'app/helpers') diff --git a/app/helpers/issues_helper.rb b/app/helpers/issues_helper.rb index a112d76af..c16ce5022 100644 --- a/app/helpers/issues_helper.rb +++ b/app/helpers/issues_helper.rb @@ -356,7 +356,8 @@ module IssuesHelper if detail.old_value && detail.value.blank? && detail.property != 'relation' old_value = content_tag("del", old_value) end - if detail.property == 'attachment' && !value.blank? && atta = Attachment.find_by_id(detail.prop_key) + if detail.property == 'attachment' && value.present? && + atta = detail.journal.journalized.attachments.detect {|a| a.id == detail.prop_key.to_i} # Link to the attachment if it has not been removed value = link_to_attachment(atta, :download => true, :only_path => options[:only_path]) if options[:only_path] != false && atta.is_text? -- cgit v1.2.3