From e159928e6b81c02001411e7e886208533178c0ba Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Sat, 6 Oct 2018 16:03:26 +0000 Subject: Use find_by instead of where.first to remove unnecessary sorting (#26747). Patch by Yuichi HARADA. git-svn-id: http://svn.redmine.org/redmine/trunk@17586 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- app/models/repository/git.rb | 4 ++-- app/models/repository/mercurial.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'app/models/repository') diff --git a/app/models/repository/git.rb b/app/models/repository/git.rb index 4cb16e524..e48d36490 100644 --- a/app/models/repository/git.rb +++ b/app/models/repository/git.rb @@ -45,7 +45,7 @@ class Repository::Git < Repository return false if v.nil? v.to_s != '0' end - + def report_last_commit=(arg) merge_extra_info "extra_report_last_commit" => arg end @@ -89,7 +89,7 @@ class Repository::Git < Repository def find_changeset_by_name(name) if name.present? - changesets.where(:revision => name.to_s).first || + changesets.find_by(:revision => name.to_s) || changesets.where('scmid LIKE ?', "#{name}%").first end end diff --git a/app/models/repository/mercurial.rb b/app/models/repository/mercurial.rb index 922893a6a..2a8079ca0 100644 --- a/app/models/repository/mercurial.rb +++ b/app/models/repository/mercurial.rb @@ -99,7 +99,7 @@ class Repository::Mercurial < Repository if /[^\d]/ =~ s or s.size > 8 cs = changesets.where(:scmid => s).first else - cs = changesets.where(:revision => s).first + cs = changesets.find_by(:revision => s) end return cs if cs changesets.where('scmid LIKE ?', "#{s}%").first -- cgit v1.2.3