From 0b72c5bfa7f28eb1528759ee720a4c3fc6a21b75 Mon Sep 17 00:00:00 2001 From: Marius Balteanu Date: Sat, 3 Dec 2022 13:21:17 +0000 Subject: Fix mentioning users with certain characters renders incorrectly (#37755). Patch Mizuki ISHIKAWA. git-svn-id: https://svn.redmine.org/redmine/trunk@21986 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- test/helpers/application_helper_test.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'test/helpers') diff --git a/test/helpers/application_helper_test.rb b/test/helpers/application_helper_test.rb index a5c533a4f..b4d194da9 100644 --- a/test/helpers/application_helper_test.rb +++ b/test/helpers/application_helper_test.rb @@ -1841,6 +1841,16 @@ class ApplicationHelperTest < Redmine::HelperTest assert_equal result, link_to_principal(unknown_principal, :class => 'bar') end + def test_link_to_principal_should_escape_principal_name + user = User.generate!(firstname: "firstname<>'", lastname: 'lastname&"') + group = Group.generate!(lastname: "group<>'&") + + assert_include "firstname<>' lastname&"", link_to_principal(user) + assert_include "@firstname<>' lastname&"", link_to_principal(user, { mention: true }) + assert_include "group<>'&", link_to_principal(group) + assert_include "<>'&", link_to_principal("<>'&") + end + def test_link_to_group_should_return_only_group_name_for_non_admin_users User.current = nil group = Group.find(10) -- cgit v1.2.3