From ba25d27e3ade01f0bb9fb4dee960caea823e81ca Mon Sep 17 00:00:00 2001 From: Toshi MARUYAMA Date: Sat, 2 Jun 2012 18:36:23 +0000 Subject: scm: git: skip Latin-1 path tests on Git for Windows above 1.7.10 Git for Windows (msysGit) changed internal API from ANSI to Unicode in 1.7.10. http://code.google.com/p/msysgit/issues/detail?id=80 So, Latin-1 path tests fail on Japanese Windows git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9750 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- test/unit/lib/redmine/scm/adapters/git_adapter_test.rb | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'test/unit/lib') diff --git a/test/unit/lib/redmine/scm/adapters/git_adapter_test.rb b/test/unit/lib/redmine/scm/adapters/git_adapter_test.rb index c5353457e..50100d1ff 100644 --- a/test/unit/lib/redmine/scm/adapters/git_adapter_test.rb +++ b/test/unit/lib/redmine/scm/adapters/git_adapter_test.rb @@ -13,8 +13,12 @@ begin ## Ruby uses ANSI api to fork a process on Windows. ## Japanese Shift_JIS and Traditional Chinese Big5 have 0x5c(backslash) problem ## and these are incompatible with ASCII. - # WINDOWS_PASS = Redmine::Platform.mswin? - WINDOWS_PASS = false + ## Git for Windows (msysGit) changed internal API from ANSI to Unicode in 1.7.10 + ## http://code.google.com/p/msysgit/issues/detail?id=80 + ## So, Latin-1 path tests fail on Japanese Windows + WINDOWS_PASS = (Redmine::Platform.mswin? && + Redmine::Scm::Adapters::GitAdapter.client_version_above?([1, 7, 10])) + WINDOWS_SKIP_STR = "TODO: This test fails in Git for Windows above 1.7.10" ## Git, Mercurial and CVS path encodings are binary. ## Subversion supports URL encoding for path. @@ -391,7 +395,7 @@ begin def test_latin_1_path if WINDOWS_PASS - # + puts WINDOWS_SKIP_STR elsif JRUBY_SKIP puts JRUBY_SKIP_STR else @@ -453,7 +457,7 @@ begin def test_entries_latin_1_dir if WINDOWS_PASS - # + puts WINDOWS_SKIP_STR elsif JRUBY_SKIP puts JRUBY_SKIP_STR else -- cgit v1.2.3