From 1fd5346c3c6069e1648ccab363e25aa8e917fb5f Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Sat, 24 May 2014 09:55:39 +0000 Subject: Fixed that Member#destroy triggers after_destroy callbacks twice (#16795). git-svn-id: http://svn.redmine.org/redmine/trunk@13140 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- test/unit/member_test.rb | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) (limited to 'test/unit') diff --git a/test/unit/member_test.rb b/test/unit/member_test.rb index 586964b52..6ba9717c4 100644 --- a/test/unit/member_test.rb +++ b/test/unit/member_test.rb @@ -107,6 +107,23 @@ class MemberTest < ActiveSupport::TestCase assert_nil category1.assigned_to_id end + def test_destroy_should_trigger_callbacks_only_once + Member.class_eval { def destroy_test_callback; end} + Member.after_destroy :destroy_test_callback + + m = Member.create!(:user_id => 1, :project_id => 1, :role_ids => [1,3]) + + Member.any_instance.expects(:destroy_test_callback).once + assert_difference 'Member.count', -1 do + assert_difference 'MemberRole.count', -2 do + m.destroy + end + end + assert m.destroyed? + ensure + Member._destroy_callbacks.reject! {|c| c.filter==:destroy_test_callback} + end + def test_sort_without_roles a = Member.new(:roles => [Role.first]) b = Member.new -- cgit v1.2.3