1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
|
# frozen_string_literal: true
# Redmine - project management software
# Copyright (C) 2006-2019 Jean-Philippe Lang
#
# This program is free software; you can redistribute it and/or
# modify it under the terms of the GNU General Public License
# as published by the Free Software Foundation; either version 2
# of the License, or (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
require File.expand_path('../../test_helper', __FILE__)
class TimelogCustomFieldsVisibilityTest < Redmine::ControllerTest
tests TimelogController
fixtures :projects,
:users, :email_addresses,
:roles,
:members,
:member_roles,
:issues, :issue_statuses,
:trackers,
:projects_trackers,
:enabled_modules,
:time_entries, :enumerations,
:workflows,
:custom_fields, :custom_values, :custom_fields_trackers
def test_index_should_show_visible_custom_fields_only
prepare_test_data
@users_to_test.each do |user, fields|
@request.session[:user_id] = user.id
get :index, :params => {
:project_id => 1,
:issue_id => @issue.id,
:c => (['hours'] + @fields.map{|f| "issue.cf_#{f.id}"})
}
@fields.each_with_index do |field, i|
if fields.include?(field)
assert_select 'td', {:text => "Value#{i}", :count => 1}, "User #{user.id} was not able to view #{field.name}"
else
assert_select 'td', {:text => "Value#{i}", :count => 0}, "User #{user.id} was able to view #{field.name}"
end
end
end
end
def test_index_as_csv_should_show_visible_custom_fields_only
prepare_test_data
@users_to_test.each do |user, fields|
@request.session[:user_id] = user.id
get :index, :params => {
:project_id => 1,
:issue_id => @issue.id,
:c => (['hours'] + @fields.map{|f| "issue.cf_#{f.id}"}),
:format => 'csv'
}
@fields.each_with_index do |field, i|
if fields.include?(field)
assert_include "Value#{i}", response.body, "User #{user.id} was not able to view #{field.name} in CSV"
else
assert_not_include "Value#{i}", response.body, "User #{user.id} was able to view #{field.name} in CSV"
end
end
end
end
def test_index_with_partial_custom_field_visibility_should_show_visible_custom_fields_only
prepare_test_data
Issue.delete_all
TimeEntry.delete_all
CustomValue.delete_all
p1 = Project.generate!
p2 = Project.generate!
user = User.generate!
User.add_to_project(user, p1, Role.where(:id => [1, 3]).to_a)
User.add_to_project(user, p2, Role.where(:id => 3).to_a)
TimeEntry.generate!(
:issue => Issue.generate!(:project => p1, :tracker_id => 1,
:custom_field_values => {@field2.id => 'ValueA'}))
TimeEntry.generate!(
:issue => Issue.generate!(:project => p2, :tracker_id => 1,
:custom_field_values => {@field2.id => 'ValueB'}))
TimeEntry.generate!(
:issue => Issue.generate!(:project => p1, :tracker_id => 1,
:custom_field_values => {@field2.id => 'ValueC'}))
@request.session[:user_id] = user.id
get :index, :params => {:c => ["hours", "issue.cf_#{@field2.id}"]}
assert_select 'td', {:text => 'ValueA'}, "ValueA not found in:\n#{response.body}"
assert_select 'td', :text => 'ValueB', :count => 0
assert_select 'td', {:text => 'ValueC'}, "ValueC not found in:\n#{response.body}"
get :index, :params => {:set_filter => '1', "issue.cf_#{@field2.id}" => '*', :c => ["issue.cf_#{@field2.id}"]}
assert_select 'td', :text => "ValueA"
assert_select 'td', :text => "ValueC"
assert_select 'td', :text => "ValueB", :count => 0
end
def test_edit_should_not_show_custom_fields_not_visible_for_user
time_entry_cf = TimeEntryCustomField.find(10)
time_entry_cf.visible = false
time_entry_cf.role_ids = [2]
time_entry_cf.save!
@request.session[:user_id] = 2
get :edit, :params => {
:id => 3,
:project_id => 1
}
assert_response :success
assert_select 'select#time_entry_custom_field_values_10', 0
end
private
def prepare_test_data
field_attributes = {:field_format => 'string', :is_for_all => true, :is_filter => true, :trackers => Tracker.all}
@fields = []
@fields << (@field1 = IssueCustomField.create!(field_attributes.merge(:name => 'Field 1', :visible => true)))
@fields << (@field2 = IssueCustomField.create!(field_attributes.merge(:name => 'Field 2', :visible => false, :role_ids => [1, 2])))
@fields << (@field3 = IssueCustomField.create!(field_attributes.merge(:name => 'Field 3', :visible => false, :role_ids => [1, 3])))
@issue = Issue.generate!(
:author_id => 1,
:project_id => 1,
:tracker_id => 1,
:custom_field_values => {@field1.id => 'Value0', @field2.id => 'Value1', @field3.id => 'Value2'}
)
TimeEntry.generate!(:issue => @issue)
@user_with_role_on_other_project = User.generate!
User.add_to_project(@user_with_role_on_other_project, Project.find(2), Role.find(3))
@users_to_test = {
User.find(1) => [@field1, @field2, @field3],
User.find(3) => [@field1, @field2],
@user_with_role_on_other_project => [@field1], # should see field1 only on Project 1
User.generate! => [@field1],
User.anonymous => [@field1]
}
Member.where(:project_id => 1).each do |member|
member.destroy unless @users_to_test.key?(member.principal)
end
end
end
|
