summaryrefslogtreecommitdiffstats
path: root/src/libmime
diff options
context:
space:
mode:
authorVsevolod Stakhov <vsevolod@highsecure.ru>2017-01-15 20:23:35 +0000
committerVsevolod Stakhov <vsevolod@highsecure.ru>2017-01-15 20:23:35 +0000
commit0e270dbe709e743ec840999c05e35f4d63be69b4 (patch)
tree810753d3258d55c35efc599f279d560accb6fe40 /src/libmime
parente0446369d13269d07cecb5711fbab7d7bc64398a (diff)
downloadrspamd-0e270dbe709e743ec840999c05e35f4d63be69b4.tar.gz
rspamd-0e270dbe709e743ec840999c05e35f4d63be69b4.zip
[Fix] Fix couple of issues
Found by: Coverity
Diffstat (limited to 'src/libmime')
-rw-r--r--src/libmime/archives.c2
-rw-r--r--src/libmime/content_type.c3
-rw-r--r--src/libmime/message.c2
3 files changed, 4 insertions, 3 deletions
diff --git a/src/libmime/archives.c b/src/libmime/archives.c
index c78b8c976..4187e86fa 100644
--- a/src/libmime/archives.c
+++ b/src/libmime/archives.c
@@ -244,7 +244,7 @@ rspamd_archive_rar_read_vint (const guchar *start, gsize remain, guint64 *res)
msg_debug_task ("rar archive is invalid (bad int32)"); \
return; \
} \
- n = p[0] + (p[1] << 8) + (p[2] << 16) + (p[3] << 24); \
+ n = (guint)p[0] + ((guint)p[1] << 8) + ((guint)p[2] << 16) + ((guint)p[3] << 24); \
p += sizeof (guint32); \
} while (0)
diff --git a/src/libmime/content_type.c b/src/libmime/content_type.c
index 9f37a8782..ba4807e0f 100644
--- a/src/libmime/content_type.c
+++ b/src/libmime/content_type.c
@@ -184,12 +184,13 @@ rspamd_content_disposition_add_param (rspamd_mempool_t *pool,
nparam->name.len = name_end - name_start;
decoded = rspamd_mime_header_decode (pool, value_start, value_end - value_start);
RSPAMD_FTOK_FROM_STR (&nparam->value, decoded);
- DL_APPEND (found, nparam);
if (!found) {
g_hash_table_insert (cd->attrs, &nparam->name, nparam);
}
+ DL_APPEND (found, nparam);
+
srch.begin = "filename";
srch.len = 8;
diff --git a/src/libmime/message.c b/src/libmime/message.c
index eba213898..6692c76e2 100644
--- a/src/libmime/message.c
+++ b/src/libmime/message.c
@@ -692,7 +692,7 @@ rspamd_message_parse (struct rspamd_task *task)
rspamd_images_process (task);
rspamd_archives_process (task);
- if (task->received && task->received->len > 0) {
+ if (task->received->len > 0) {
gboolean need_recv_correction = FALSE;
rspamd_inet_addr_t *raddr;