1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
|
/*
* Copyright (c) 2015, Vsevolod Stakhov
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY AUTHOR ''AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL AUTHOR BE LIABLE FOR ANY
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
#include "printf_check.h"
#include "clang/AST/AST.h"
#include "clang/AST/Expr.h"
#include "clang/AST/ASTConsumer.h"
#include "clang/AST/RecursiveASTVisitor.h"
#include <unordered_map>
#include <vector>
#include <sstream>
#include <ctype.h>
using namespace clang;
namespace rspamd {
struct PrintfArgChecker;
using arg_parser_t = bool (*) (const Expr *, struct PrintfArgChecker *);
static void
print_error (const std::string &err, const Expr *e, const ASTContext *ast)
{
auto const &sm = ast->getSourceManager ();
auto loc = e->getExprLoc ();
llvm::errs() << err << " at " << loc.printToString (sm) << "\n";
}
/* Handles %s */
static bool
cstring_arg_handler (const Expr *arg, struct PrintfArgChecker *ctx)
{
return true;
}
static bool
int_arg_handler (const Expr *arg, struct PrintfArgChecker *ctx)
{
return true;
}
struct PrintfArgChecker {
private:
arg_parser_t parser;
public:
int width;
int precision;
PrintfArgChecker (arg_parser_t _p) : parser(_p) {}
virtual ~PrintfArgChecker () {}
bool operator () (const Expr *e)
{
return parser (e, this);
}
};
class PrintfCheckVisitor::impl {
std::unordered_map<std::string, int> printf_functions;
ASTContext *pcontext;
std::unique_ptr<PrintfArgChecker> parseFlags (const std::string &flags)
{
auto type = flags.back();
switch (type) {
case 's':
return llvm::make_unique<PrintfArgChecker>(cstring_arg_handler);
case 'd':
return llvm::make_unique<PrintfArgChecker>(int_arg_handler);
default:
llvm::errs () << "unknown parser flag: " << type << "\n";
break;
}
return nullptr;
}
std::shared_ptr<std::vector<PrintfArgChecker> >
genParsers (const StringRef query)
{
enum {
ignore_chars = 0,
read_percent,
read_width,
read_precision,
read_arg
} state = ignore_chars;
int width, precision;
std::string flags;
auto res = std::make_shared<std::vector<PrintfArgChecker> >();
for (const auto c : query) {
switch (state) {
case ignore_chars:
if (c == '%') {
state = read_percent;
flags.clear ();
width = precision = 0;
}
break;
case read_percent:
if (isdigit (c)) {
state = read_width;
width = c - '0';
}
else if (c == '.') {
state = read_precision;
precision = c - '0';
}
else if (c == '*') {
/* %*s - need integer argument */
res->emplace_back (int_arg_handler);
state = read_arg;
}
else if (c == '%') {
/* Percent character, ignore */
state = ignore_chars;
}
else {
flags.push_back (c);
state = read_arg;
}
break;
case read_width:
if (isdigit (c)) {
width *= 10;
width += c - '0';
}
else if (c == '.') {
state = read_precision;
precision = c - '0';
}
else {
flags.push_back (c);
state = read_arg;
}
break;
case read_precision:
if (isdigit (c)) {
precision *= 10;
precision += c - '0';
}
else if (c == '*') {
res->emplace_back (int_arg_handler);
state = read_arg;
}
else {
flags.push_back (c);
state = read_arg;
}
break;
case read_arg:
if (!isalpha (c)) {
auto handler = parseFlags (flags);
if (handler) {
auto handler_copy = *handler;
res->emplace_back (std::move (handler_copy));
}
else {
llvm::errs () << "invalid modifier\n";
return nullptr;
}
state = ignore_chars;
}
else {
flags.push_back (c);
}
break;
}
}
if (state == read_arg) {
auto handler = parseFlags (flags);
if (handler) {
auto handler_copy = *handler;
res->emplace_back (std::move (handler_copy));
}
else {
llvm::errs () << "invalid modifier\n";
return nullptr;
}
}
return res;
}
public:
impl (ASTContext *_ctx) : pcontext(_ctx)
{
/* name -> format string position */
printf_functions = {
{"rspamd_printf", 0},
{"rspamd_default_log_function", 4},
{"rspamd_snprintf", 2},
{"rspamd_fprintf", 1}
};
};
bool VisitCallExpr (CallExpr *E)
{
auto callee = dyn_cast<NamedDecl> (E->getCalleeDecl ());
if (callee == NULL) {
llvm::errs () << "Bad callee\n";
return false;
}
auto fname = callee->getNameAsString ();
auto pos_it = printf_functions.find (fname);
if (pos_it != printf_functions.end ()) {
const auto args = E->getArgs ();
auto pos = pos_it->second;
auto query = args[pos];
if (!query->isEvaluatable (*pcontext)) {
llvm::errs () << "Cannot evaluate query\n";
return false;
}
clang::Expr::EvalResult r;
if (!query->EvaluateAsRValue (r, *pcontext)) {
llvm::errs () << "Cannot evaluate query\n";
return false;
}
auto qval = dyn_cast<StringLiteral> (
r.Val.getLValueBase ().get<const Expr *> ());
if (qval) {
llvm::errs () << "query string: "
<< qval->getString () << "\n";
}
else {
llvm::errs () << "Bad or absent query string\n";
return false;
}
auto parsers = genParsers (qval->getString ());
if (parsers) {
if (parsers->size () != E->getNumArgs () - (pos + 1)) {
std::ostringstream err_buf;
err_buf << "number of arguments for " << fname
<< " missmatches query string '" <<
qval->getString().str()
<< "', expected " << parsers->size () << " args"
<< ", got " << (E->getNumArgs () - (pos + 1))
<< " args";
print_error (err_buf.str (), E, this->pcontext);
return false;
}
else {
for (auto i = pos + 1; i < E->getNumArgs (); i++) {
auto arg = args[i];
if (arg) {
if (!parsers->at(i - (pos + 1))(arg)) {
return false;
}
}
}
}
}
}
return true;
}
};
PrintfCheckVisitor::PrintfCheckVisitor (ASTContext *ctx) :
pimpl { new impl(ctx) }
{
}
PrintfCheckVisitor::~PrintfCheckVisitor ()
{
}
bool PrintfCheckVisitor::VisitCallExpr (clang::CallExpr *E)
{
return pimpl->VisitCallExpr (E);
}
};
|