diff options
author | Julien Lancelot <julien.lancelot@sonarsource.com> | 2014-03-07 13:25:42 +0100 |
---|---|---|
committer | Julien Lancelot <julien.lancelot@sonarsource.com> | 2014-03-07 13:25:42 +0100 |
commit | 6b0986efbfcbac2048f18ff9e9eae55f0d18b616 (patch) | |
tree | dad4116fede50a74d2c927803ccfb4473bfea00e | |
parent | 81e4712486a4ac4562c34cabfb25abc610119f4a (diff) | |
download | sonarqube-6b0986efbfcbac2048f18ff9e9eae55f0d18b616.tar.gz sonarqube-6b0986efbfcbac2048f18ff9e9eae55f0d18b616.zip |
Fix quality flaws
-rw-r--r-- | sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/WorkDuration.java | 2 | ||||
-rw-r--r-- | sonar-server/src/main/java/org/sonar/server/rule/RuleRegistration.java | 1 |
2 files changed, 2 insertions, 1 deletions
diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/WorkDuration.java b/sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/WorkDuration.java index c6c0319495f..4fbdf272c65 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/WorkDuration.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/utils/internal/WorkDuration.java @@ -100,7 +100,7 @@ public class WorkDuration implements Serializable { } static WorkDuration createFromMinutes(long duration, int hoursInDay) { - int days = ((Double) (duration / hoursInDay / 60d)).intValue(); + int days = ((Double) ((double) duration / hoursInDay / 60d)).intValue(); Long currentDurationInMinutes = duration - (60L * days * hoursInDay); int hours = ((Double) (currentDurationInMinutes / 60d)).intValue(); currentDurationInMinutes = currentDurationInMinutes - (60L * hours); diff --git a/sonar-server/src/main/java/org/sonar/server/rule/RuleRegistration.java b/sonar-server/src/main/java/org/sonar/server/rule/RuleRegistration.java index e615bc7b138..24fd9f7448c 100644 --- a/sonar-server/src/main/java/org/sonar/server/rule/RuleRegistration.java +++ b/sonar-server/src/main/java/org/sonar/server/rule/RuleRegistration.java @@ -258,6 +258,7 @@ public class RuleRegistration implements Startable { boolean changed = false; CharacteristicDto characteristic = findCharacteristic(characteristicDtos, def); + // Debt definitions are set to null if the characteristic is null or unknown Integer characteristicId = characteristic != null ? characteristic.getId() : null; RemediationFunction remediationFunction = characteristic != null ? def.remediationFunction() : null; String remediationFactor = characteristic != null ? def.remediationFactor() : null; |