diff options
| author | Simon Brandhof <simon.brandhof@gmail.com> | 2013-07-16 10:07:21 +0200 |
|---|---|---|
| committer | Simon Brandhof <simon.brandhof@gmail.com> | 2013-07-16 10:07:50 +0200 |
| commit | 8e18a11789e29c4204d543c0225dd6011dac6c83 (patch) | |
| tree | 1a3484b8efed765399cdb9e57fc8223054283867 | |
| parent | 92e6b1f28edf80cae4e9f20792b2e2791d22e7fa (diff) | |
| download | sonarqube-8e18a11789e29c4204d543c0225dd6011dac6c83.tar.gz sonarqube-8e18a11789e29c4204d543c0225dd6011dac6c83.zip | |
Fix some Java quality flaws
3 files changed, 6 insertions, 4 deletions
diff --git a/sonar-core/src/main/java/org/sonar/core/issue/IssueNotifications.java b/sonar-core/src/main/java/org/sonar/core/issue/IssueNotifications.java index 28fbe6b268c..93d67e5c62d 100644 --- a/sonar-core/src/main/java/org/sonar/core/issue/IssueNotifications.java +++ b/sonar-core/src/main/java/org/sonar/core/issue/IssueNotifications.java @@ -86,7 +86,8 @@ public class IssueNotifications implements BatchComponent, ServerComponent { } @CheckForNull - private Notification createChangeNotification(DefaultIssue issue, IssueChangeContext context, Rule rule, Component project, @Nullable Component component, @Nullable String comment) { + private Notification createChangeNotification(DefaultIssue issue, IssueChangeContext context, Rule rule, Component project, + @Nullable Component component, @Nullable String comment) { FieldDiffs currentChange = issue.currentChange(); if (comment == null && (currentChange == null || currentChange.diffs().isEmpty())) { return null; diff --git a/sonar-core/src/main/java/org/sonar/core/persistence/DryRunDatabaseFactory.java b/sonar-core/src/main/java/org/sonar/core/persistence/DryRunDatabaseFactory.java index 5f89ef9895f..27a8445f42b 100644 --- a/sonar-core/src/main/java/org/sonar/core/persistence/DryRunDatabaseFactory.java +++ b/sonar-core/src/main/java/org/sonar/core/persistence/DryRunDatabaseFactory.java @@ -81,7 +81,8 @@ public class DryRunDatabaseFactory implements ServerComponent { .copyTable(source, dest, "alerts"); if (projectId != null) { String snapshotCondition = "islast=" + database.getDialect().getTrueSqlValue() + " and (project_id=" + projectId + " or root_project_id=" + projectId + ")"; - template.copyTable(source, dest, "projects", "id in (select project_id from snapshots where " + snapshotCondition + ") or (id=" + projectId + " or root_id=" + projectId + ")"); + template.copyTable(source, dest, "projects", + "id in (select project_id from snapshots where " + snapshotCondition + ") or (id=" + projectId + " or root_id=" + projectId + ")"); template.copyTable(source, dest, "snapshots", snapshotCondition); String forRootModule = "(root_component_id in (select id from projects where id=" + projectId + " and qualifier='TRK'))"; diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/FileLinesContext.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/FileLinesContext.java index 46e10d62f94..b88d0c6f001 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/FileLinesContext.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/FileLinesContext.java @@ -34,8 +34,8 @@ import com.google.common.annotations.Beta; * Also note that you can't update what already was saved, however it is safe to call {@link #save()} several times. * <p> * Instances of this interface can be obtained using {@link FileLinesContextFactory}. - * - * <p>This interface is not intended to be implemented by clients.</p> + * <p/> + * This interface is not intended to be implemented by clients. * * @since 2.14 */ |